- 09 Jan, 2014 30 commits
-
-
Larry Finger authored
Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: expected unsigned short *ipxSocketAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:123: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:99: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:101: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: expected unsigned short *ipxSocketAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:714:121: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: expected unsigned int *ipxNetAddr drivers/staging/rtl8188eu/core/rtw_br_ext.c:721:99: got restricted __be32 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:749:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:762:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:783:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: expected unsigned short *network drivers/staging/rtl8188eu/core/rtw_br_ext.c:795:83: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: warning: incorrect type in assignment (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: expected unsigned short [unsigned] [short] <noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:849:57: got restricted __be16 [usertype] <noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:92:23: warning: restricted __be16 degrades to integer drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: expected unsigned short *sid drivers/staging/rtl8188eu/core/rtw_br_ext.c:876:95: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:912:45: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: expected unsigned short *sid drivers/staging/rtl8188eu/core/rtw_br_ext.c:944:112: got restricted __be16 *<noident> drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: warning: incorrect type in argument 3 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: expected unsigned int [unsigned] [usertype] len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1019:84: got restricted __be16 [usertype] payload_len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: expected int [signed] len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1021:110: got restricted __be16 [usertype] payload_len drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1145:54: warning: cast to restricted __be32 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1148:70: warning: restricted __be16 degrades to integer drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: warning: invalid assignment: |= drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: left side has type unsigned short drivers/staging/rtl8188eu/core/rtw_br_ext.c:1154:70: right side has type restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 drivers/staging/rtl8188eu/core/rtw_br_ext.c:1157:64: warning: cast to restricted __be16 Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Sparse reports the following warning: CHECK drivers/staging/rtl8188eu/core/rtw_xmit.c drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: warning: incorrect type in initializer (different base types) drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: expected unsigned short [usertype] *fctrl drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: got restricted __le16 *<noident> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol 'rtw_free_pwrctrl_priv' was not declared. Should it be static? That routine is not used and has been deleted. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_sta_mgt.c drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:152:6: warning: symbol 'rtw_mfree_all_stainfo' was not declared. Should it be static? Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
There are two different enum statements that have been combined. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This driver only handles RTL8188EU with USB interface, thus several hardware defines and macros can be removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This driver only works with the USB bus. Accordingly, enum odm_interface_def can be removed along with all code that uses ODM_ITRF_XXX, where XXX is not USB. In enum odm_ic_type, only ODM_RTL8188E is used. Remove the enum, all references to the others, and define the needed value. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This header contains a number of routines that do not to be available globally. Once this change was made, a number of the routines were not used, and could be removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This member of struct odm_dm_struct is always set to ODM_RTL8188E for this driver. Accordingly, the code can be simplified. A number of routines now are no longer needed and are deleted. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This member of struct odm_dm_struct is always set to ODM_CE in this driver. As a result, a number of switch and if statements can be simplified. In addition, a number of routines are no longer used and can be removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This patch removes the following: odm_DynamicTxPowerAP odm_RSSIMonitorCheckMP odm_RSSIMonitorCheckAP odm_TXPowerTrackingCheckMP odm_TXPowerTrackingCheckAP odm_SwAntDivInit ODM_SwAntDivChkPerPktRssi odm_SwAntDivChkAntSwitch ODM_SwAntDivRestAfterLink dm_GlobalAdapterCheck odm_dtc Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This batch includes ODM_StartWorkItem ODM_StopWorkItem ODM_FreeWorkItem ODM_AcquireSpinLoc ODM_ReleaseSpinLock ODM_ReleaseTimer ODM_ReleaseAllTimers Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
These routines include: ODM_StartWorkItem() ODM_StopWorkItem() ODM_FreeWorkItem() ODM_ScheduleWorkItem() ODM_IsWorkItemScheduled() Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This is equivalent to PHY_GetBBReg. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This is the same as macro PHY_SetBBReg. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This one is a duplicate od macro PHY_QueryRFReg. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
It is a duplicate of macro PHY_SetRFReg. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
This one is a duplicate of PHY_QueryBBReg. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
It is essentially a duplicate of macro PHY_SetBBReg Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Any routines that are empty as a result of these changes are also removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
The current kernels do not include this entry point. Delete the call. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
staging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uninit, rtw_lock_suspend, and rtw_unlock_suspend All of these routines are empty. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
a simple yield() is sufficient. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Each of the uses in the code asks for a sleep of 100 usec or so. On Linux, these are converted to msleep(1). Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 08 Jan, 2014 10 commits
-
-
Matthias Oefelein authored
This patch replaces C99-style with C89-style comments. Additionally, code fragments that have been commented out are removed; the same applies to meaningless comments. Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Matthias Oefelein authored
In InterfaceRx.c, opening braces of (if-)conditionals are mostly dislocated, meaning they are found behind an extra line break after the conditional statement. This patch moves the opening braces accordingly as specified by the official conding style guidelines. Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Matthias Oefelein authored
Most spaces before opening parentheses (where required) are missing here. This patch adds spaces at the appropriate spots. Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Matthias Oefelein authored
Checkpatch reports a lot of spaces at the beginning of lines and other wrong indentations. This patch fixes these issues. Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Matthias Oefelein authored
This fix adds missing spaces after commas in function calls/definitions. Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Matthias Oefelein authored
Checkpatch reports missing spaces around operators; this patch introduces spaces where needed. Spaces before semicolons are prohibited by the official coding style guidelines, those have been fixed as well. Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ralph Mueck authored
Checkpatch complains about the use of //-comments, thus they are replaced by C89-style comments. Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ralph Mueck authored
This corrects the position of (opening) braces in if-conditionals to make checkpatch shut up. Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ralph Mueck authored
This patch adds spaces before the opening parentheses of if-conditionals to comply with offical code styling guidelines. Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ralph Mueck authored
This patch takes care of the following issues: - missing spaces at variable assignments - missing spaces between function arguments - spaces at the beginning of a line where tabs should be - prohibited spaces before a (semi)colon Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-