- 12 Oct, 2007 40 commits
-
-
Jesper Juhl authored
The Coverity checker spotted two potential memory leaks in drivers/message/fusion/mptbase.c::mpt_attach(). There are two returns that may leak the storage allocated for 'ioc' (sizeof(MPT_ADAPTER) bytes). A simple fix would be to simply add two kfree() calls before the return statements, but a better fix (that this patch implements) is to reorder the code so that if we hit the first return condition we don't have to do the allocation at all and then just add a kfree() call for the second case. Signed-off-by:
Jesper Juhl <jesper.juhl@gmail.com> Acked-by:
"Moore, Eric Dean" <Eric.Moore@lsil.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
James Bottomley <James.Bottomley@SteelEye.com>
-
Mariusz Kozlowski authored
This patch does kmalloc + memset conversion to kzalloc anSigned-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> d simplifies mptctl_probe(). drivers/message/fusion/mptctl.c | 82092 -> 81884 (-208 bytes) drivers/message/fusion/mptctl.o | 201784 -> 200648 (-1136 bytes) Signed-off-by:
Mariusz Kozlowski <m.kozlowski@tuxland.pl> Acked-by:
-
Jan Engelhardt authored
Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. Signed-off-by:
Jan Engelhardt <jengelh@gmx.de> Acked-by:
-
FUJITA Tomonori authored
srp transport works for target drivers without supported_mode attribute but it would be better to use it explicitly. Signed-off-by:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Signed-off-by:
-
FUJITA Tomonori authored
This adds minimum target driver support like the srp transport does: - fc_remote_port_{rolechg,delete} calls scsi_tgt_it_nexus_{create,destroy} for target drivers. - add callbacks to notify target drivers of the nexus and tmf operation results to fc_function_template. Signed-off-by:Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:
-
FUJITA Tomonori authored
This adds supported_mode and active_mode attributes to /sys/class/sys_host/hostX/ for specifying the mode that a lld supports and the currently activated mode. The output format is similar to fc rport roles: luce:/sys/class/scsi_host/host0$ cat supported_mode Initiator luce:/sys/class/scsi_host/host0$ cat active_mode Initiator The mode values uses bitmap since we would support dual-mode llds in the future like this: luce:/sys/class/scsi_host/host0$ cat supported_mode Initiator, Target The supported_mode attribute looks at a scsi_host_template and the active_mode attribute looks at a scsi_host. We would add a hook to a scsi_host_template to change the active_mode attribute dynamically. But now there is no hook since no lld supports that feature. Signed-off-by:
-
FUJITA Tomonori authored
should use host->can_queue instead of host->hostt->can_queue. Signed-off-by:
-
Gilbert Wu authored
Add new HBA PCI ID (0x416) for ASC58300 which has eight port SAS and SATA PCI-X 133MHz low profile host bus adapter with two mini SAS 4x external connectors. Signed-off-by:
Gilbert Wu <gilbert_wu@adaptec.com> Signed-off-by:
-
Salyzyn, Mark authored
Add the SMC LP, SUN EM and Adaptec 5405 cards to the aacraid documentation list of supported products. These cards are picked up with family match, so no associated code changes. Signed-off-by:
Mark Salyzyn <aacraid@adaptec.com> Signed-off-by:
-
HighPoint Linux Team authored
updated patch based on Jeff Garzik's comments. - check adapter firmware version and use appropriate interface accordingly - add new PCI device IDs and use PCI_VDEVICE macro - update driver version string - remove unused data structures - remove unnecessary typecasts Signed-off-by:
HighPoint Linux Team <linux@highpoint-tech.com> Signed-off-by:
-
Christof Schmitt authored
Already register the debug feature before the zfcp adapter is set online. This allows to use the debug feature to investigate the online/offline sequence. Signed-off-by:
Christof Schmitt <christof.schmitt@de.ibm.com> Signed-off-by:
Swen Schillig <swen@vnet.ibm.com> Signed-off-by:
-
Swen Schillig authored
cleanup, using ERP request mempool for all ERP versions of the exchange functions (exchange_config (ECD), exchange_port (EPD) ) providing individual versions of the ECD, EPD functions for ERP and other purposes (_sync). Signed-off-by:
-
Christof Schmitt authored
This change has already been discussed on linux-scsi: http://marc.info/?t=118771096400003 http://marc.info/?t=118760913100005Signed-off-by:
James Smart <James.Smart@Emulex.Com> Signed-off-by:
-
Christof Schmitt authored
Remove braces for only one statement Signed-off-by:
-
Christof Schmitt authored
zfcp_adapter_enqueue initialized adapter->ccw_device twice with the same value. Remove the second assignment, since it is not necessary. Signed-off-by:
-
Heiko Carstens authored
Avoid "if (whatever) ;" constructs since they seem to confuse people, even if there is a comment. Signed-off-by:
Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:
-
Christof Schmitt authored
correct indentation for nested if-else Signed-off-by:
-
Mariusz Kozlowski authored
In NCR_D700, a4000t, aic7xxx_old, bvme6000, dpt_i2o, gdth, lpfc, megaraid, mvme16x osst, pluto, qla2xxx, zorro7xx Signed-off-by:
-
Prakash, Sathya authored
Recently LSI Logic Corp was renamed as LSI Corp, so whereever there is a reference of LSI Logic, it is changed to LSI in mpt fusion driver code. signed-off-by:
Sathya Prakash <sathya.prakash@lsi.com> Acked-by:
Eric Moore <Eric.Moore@lsi.com> Signed-off-by:
-
Prakash, Sathya authored
When there is state change in FC links, a message is displayed with old and new link speed. signed-off-by:
-
Prakash, Sathya authored
The data structure definitions from mptsas.c are moved to a new header file mptsas.h signed-off-by:
-
Prakash, Sathya authored
The call back index requires only u8 but in lot of places it is referred as int, now everywhere the call back index variables are declared as u8 with uniform name cb_idx signed-off-by:
-
Prakash, Sathya authored
Added support for sending the task management requests through High priority request FIFO instead of Doorbell writes when firmware support High priority FIFO. signed-off-by:
-
Eric Moore authored
Per request from Matthew Wilcox - using PCI_VENDOR_ATTO. Add support for ATTO UL4D, they are rebranded 53C1030. The changes are 1. Adding a new PCI vendor ID in pci table 2. The spi_port_page_2 is in different format than that of LSI generic spi_port_page_2 and hence mapping code is added. signed-off-by:
-
Eric Moore authored
A new PCI_VENDOR_ID for pci_ids.h. signed-off-by:
-
Alan Cox authored
Signed-off-by:
Alan Cox <alan@redhat.com> Signed-off-by:
-
Adrian Bunk authored
Signed-off-by:
Adrian Bunk <bunk@stusta.de> Signed-off-by:
-
Gabriel C authored
In file included from drivers/scsi/g_NCR5380_mmio.c:9: drivers/scsi/g_NCR5380.c:559:5: warning: "NCR53C400_PSEUDO_DMA" is not defined Signed-off-by:
Gabriel Craciunescu <nix.or.die@googlemail.com> Signed-off-by:
-
Adrian Bunk authored
Every file should #include the headers containing the prototypes for its global functions (in this case for scsi_schedule_eh()). Signed-off-by:
-
Andrew Morton authored
drivers/scsi/ips.c: In function 'ips_insert_device': drivers/scsi/ips.c:6957: warning: 'index' may be used uninitialized in this function Signed-off-by:
-
Jesper Juhl authored
Signed-off-by:
-
Andrew Morton authored
Too generic, clashes with ISDN. Signed-off-by:
-
Jesper Juhl authored
The Coverity checker noticed that we may overrun a statically allocated array in drivers/scsi/lpfc/lpfc_sli.c::lpfc_sli_hbqbuf_find(). The case is this; In 'struct lpfc_hba' we have #define LPFC_MAX_HBQS 4 ... struct lpfc_hba { ... struct hbq_s hbqs[LPFC_MAX_HBQS]; ... }; But then in lpfc_sli_hbqbuf_find() we have this code hbqno = tag >> 16; if (hbqno > LPFC_MAX_HBQS) return NULL; if 'hbqno' ends up as exactely 4, then we won't return, and then this list_for_each_entry(d_buf, &phba->hbqs[hbqno].hbq_buffer_list, list) { will cause an overflow of the statically allocated array at index 4, since the valid indices are only 0-3. I propose this patch, that simply changes the 'hbqno > LPFC_MAX_HBQS' into 'hbqno >= LPFC_MAX_HBQS' as a possible fix. Signed-off-by: -
FUJITA Tomonori authored
- remove the unnecessary map_single path. - convert to use the new accessors for the sg lists and the parameters. Signed-off-by:
-
Matthew Wilcox authored
The 700+-line comment at the top of the advansys driver fits more comfortably in Documentation/scsi. Delete the sections on: - kernels supported - other files modified (obsolete) - source comments (obsolete) - tests to run - release history (that's what a VCS is for) - contacting connectcom (the domain has expired and the phone number is now in use by another organisation) Known problems/fix list is moved down to the section where jejb put his FIXME. Signed-off-by:
Matthew Wilcox <matthew@wil.cx> Signed-off-by:
-
Matthew Wilcox authored
Use memcpy to initialise eep_config instead of a loop. For AdvInitFrom38C1600EEP where we need to modify the default EEPROM configuration, do it after the loop, and do it using the structure definition, not by finding the right byte. I think it was wrong for big-endian machines. Also delete some non-useful comments and prototypes. Signed-off-by:
-
Matthew Wilcox authored
The driver kept a copy of the PCI config address; refer to the pci_dev associated with the card instead. Signed-off-by:
-
Matthew Wilcox authored
Convert adv_isr_callback, adv_async_callback and asc_isr_callback into direct calls. Remove the unused asc_exe_callback. Signed-off-by:
-
Matthew Wilcox authored
The cfg structures are supposed to be disposable after initialisation; with the 'dev' used for DMA mapping in there, that's not possible. Move the dev to the board. Also inline AscInitFromAscDvcVar into its only caller, remove some unnecessary prototypes and sort out a few minor formatting issues. Signed-off-by:
-
Matthew Wilcox authored
n_io_port isn't suitable for advansys because some of the boards have more than 255 bytes of io port space. There's already a driver-private replacement, asc_n_io_port, but for some reason the driver was still setting and occasionally reporting n_io_port. Signed-off-by:
-
