- 28 Jan, 2008 40 commits
-
-
David Woodhouse authored
Signed-off-by:
David Woodhouse <dwmw2@infradead.org> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
David Woodhouse authored
sizeof(*cmd) is going to give the total size of the data structure that we allocated, more often than not. But the size of the command to be _sent_ could be a lot smaller, as it is in the KEY_MATERIAL and SUBSCRIBE_EVENT commands for example. So swap them round; let the caller set the _command_ size explicitly in the header, and infer the maximum response size from the data structure. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
We don't necessarily want to reset the device on a TX timeout. But more often than not, the real cause is that the firmware has crapped itself, not just that the network is busy. So submit any harmless command, and if _that_ times out, then the error handling code will reset the module, as appropriate. Signed-off-by:
-
David Woodhouse authored
Even if it fails, we want to wait a while and try again, with an ultimate timeout if it the condition persists. So again, just use the standard command timeout behaviour. Signed-off-by:
-
David Woodhouse authored
When the firmware returns 0x0004, it wants us to try again later. We can achieve that simply by throwing out the response and letting the command timeout code kick in. Signed-off-by:
-
David Woodhouse authored
If we don't scribble over the command we sent, then we can retry it when the firmware responds with 0x0004 (which means -EAGAIN). Signed-off-by:
-
David Woodhouse authored
We have a local variable 'resp' which we use for this. So use it, instead of typing the whole thing. In preparation for actually using priv->upld_buf for the responses instead... Signed-off-by:
-
David Woodhouse authored
Move the various firmware setup bits into a separate function, which used to do just boot2 version. Signed-off-by:
-
David Woodhouse authored
Otherwise, we go into an endless busy loop trying to enable PS mode when the command queue is empty, dealing with the error response, and then trying to enable PS mode again because the command queue is empty.... it doesn't really save much power. Signed-off-by:
-
David Woodhouse authored
lbs_send_confirmwake() is a bit ugly but matches the way we confirm sleep. We'll deal with that whole thing later. Signed-off-by:
-
David Woodhouse authored
DNLD_RES_RECEIVED is a bit of a misnomer -- we never wait for the result to be received; it's purely representing the state of the TX path, and in this case the TX path is definitely busy. Of course, that means that we don't actually care about DATA_SENT vs. CMD_SENT either, but that's a can of worms for another day... Signed-off-by:
-
David Woodhouse authored
Commit 5b8845345e7385d2eb37fac22ba9ab6905988be5 (or, in case the git workflow is broken and patches get recommitted, the commit entitled 'libertas: rename and re-type bufvirtualaddr to cmdbuf' by dcbw), introduced a number of bugs where we once had a pointer to a command _payload_, but now we use the pointer to the command header instead. The fix isn't wonderfully pretty for now, but it'll get better when we finish converting all commands so the structures include the header. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
If we return the channel number in a 'ret' variable where anything non-zero is later interpreted as an error, that isn't nice. It breaks WPA, for a start. OLPC trac #5485 Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
And handle the case where it times out more than once, too, instead of locking up for ever. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
... at least for users of __lbs_cmd(). Signed-off-by:
-
David Woodhouse authored
We can use the callback_arg for it; that's the way we're heading anyway... Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Move the wakeup into lbs_complete_command(), and leave the other bits in __lbs_cleanup_and_insert_cmd() which was the only caller now anyway. There are two remaining direct callers of lbs_cleanup_and_insert_cmd(), and they are both fine without the wakeup. Signed-off-by:
-
David Woodhouse authored
We initialise it when we add it to the queue. No need to do it again. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
We allocate them all at the same time, at startup. If they go missing, we have more serious things to worry about, and the resulting oops will be a perfectly acceptable result. Signed-off-by:
-
David Woodhouse authored
We're about to change semantics, leaving callers of lbs_prepare_and_send_command() with the old broken priv->cur_cmd_retcode crap. The existence of the callback command will be the trigger for the new semantics when handling the response. Signed-off-by:
-
David Woodhouse authored
Call it lbs_submit_command(), remove a bunch of things which can be (or, in the case of zeroing ->cmdwaitqwoken, already are) done elsewhere. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
It was just getting on my tits, really. Signed-off-by:
-
David Woodhouse authored
It wasn't working anyway -- by the time we get into if_usb_disconnect() the USB core has already stopped us talking to the thing; even if it's just on unload and the device still exists. Signed-off-by:
-
David Woodhouse authored
The kthread code can't cope with a thread exiting of its own accord and then someone calling kthread_stop() for it. When the thread detects that it needs to die, make it wait for kthread_stop() to be called. Signed-off-by:
-
Larry Finger authored
This fixes Bug #9414 for b43legacy. This patch is the equivalent of one submitted earlier for b43. Since addition of the rfkill callback, the LED associated with the off switch on the radio has not worked for several reasons: (1) Essential data in the rfkill structure were missing. (2) The rfkill structure was initialized after the LED initialization. (3) There was a minor memory leak if the radio LED structure was inited. Once the above problems were fixed, additional difficulties were noted: (4) The radio LED was in the wrong state at startup. (5) The radio switch had to be manipulated twice for each state change. (6) A circular mutex locking situation existed. (7) If rfkill-input is built as a module, it is not automatically loaded. This patch fixes all of the above and removes a couple of sparse warnings. Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
Stefano Brivio <stefano.brivio@polimi.it> Signed-off-by:
-
Ramkrishna Vepa authored
Multiple transmit fifo initialization - - Assigned equal scheduling priority for all configured FIFO's. - Modularized transmit traffic interrupt initialization since it is executed in s2io_card_up and s2io_link. Enable continuous tx interrupt when link is UP and vice verse. - Enable transmit interrupts for all configured transmit fifos. - Fixed typo errors. Signed-off-by:Surjit Reang <surjit.reang@neterion.com> Signed-off-by:
Sreenivasa Honnur <sreenivasa.honnur@neterion.com> Signed-off-by:
Ramkrishna Vepa <ram.vepa@neterion.com> Signed-off-by:
Jeff Garzik <jeff@garzik.org>
-
Surjit Reang authored
Fixes to enable multiple transmit fifos (upto a maximum of eight). - Moved single tx_lock from struct s2io_nic to struct fifo_info. - Moved single ufo_in_band_v structure from struct s2io_nic to struct fifo_info. - Assign the respective interrupt number for the transmitting fifo in the transmit descriptor (TXD). - Added boundary checks for number of FIFOs enabled and FIFO length. Signed-off-by:David S. Miller <davem@davemloft.net>
-
