1. 12 Apr, 2011 3 commits
    • Eric Dumazet's avatar
      inetpeer: reduce stack usage · 66944e1c
      Eric Dumazet authored
      On 64bit arches, we use 752 bytes of stack when cleanup_once() is called
      from inet_getpeer().
      
      Lets share the avl stack to save ~376 bytes.
      
      Before patch :
      
      # objdump -d net/ipv4/inetpeer.o | scripts/checkstack.pl
      
      0x000006c3 unlink_from_pool [inetpeer.o]:		376
      0x00000721 unlink_from_pool [inetpeer.o]:		376
      0x00000cb1 inet_getpeer [inetpeer.o]:			376
      0x00000e6d inet_getpeer [inetpeer.o]:			376
      0x0004 inet_initpeers [inetpeer.o]:			112
      # size net/ipv4/inetpeer.o
         text	   data	    bss	    dec	    hex	filename
         5320	    432	     21	   5773	   168d	net/ipv4/inetpeer.o
      
      After patch :
      
      objdump -d net/ipv4/inetpeer.o | scripts/checkstack.pl
      0x00000c11 inet_getpeer [inetpeer.o]:			376
      0x00000dcd inet_getpeer [inetpeer.o]:			376
      0x00000ab9 peer_check_expire [inetpeer.o]:		328
      0x00000b7f peer_check_expire [inetpeer.o]:		328
      0x0004 inet_initpeers [inetpeer.o]:			112
      # size net/ipv4/inetpeer.o
         text	   data	    bss	    dec	    hex	filename
         5163	    432	     21	   5616	   15f0	net/ipv4/inetpeer.o
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      Cc: Scot Doyle <lkml@scotdoyle.com>
      Cc: Stephen Hemminger <shemminger@vyatta.com>
      Cc: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
      Reviewed-by: default avatarHiroaki SHIMODA <shimoda.hiroaki@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      66944e1c
    • Eric Dumazet's avatar
      bridge: reset IPCB in br_parse_ip_options · f8e9881c
      Eric Dumazet authored
      Commit 462fb2af (bridge : Sanitize skb before it enters the IP
      stack), missed one IPCB init before calling ip_options_compile()
      
      Thanks to Scot Doyle for his tests and bug reports.
      Reported-by: default avatarScot Doyle <lkml@scotdoyle.com>
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      Cc: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
      Acked-by: default avatarBandan Das <bandan.das@stratus.com>
      Acked-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Cc: Jan Lübbe <jluebbe@debian.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f8e9881c
    • David S. Miller's avatar
      llc: Fix length check in llc_fixup_skb(). · aa867359
      David S. Miller authored
      Fixes bugzilla #32872
      
      The LLC stack pretends to support non-linear skbs but there is a
      direct use of skb_tail_pointer() in llc_fixup_skb().
      
      Use pskb_may_pull() to see if data_size bytes remain and can be
      accessed linearly in the packet, instead of direct pointer checks.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aa867359
  2. 11 Apr, 2011 16 commits
  3. 10 Apr, 2011 1 commit
  4. 09 Apr, 2011 3 commits
  5. 08 Apr, 2011 8 commits
  6. 07 Apr, 2011 9 commits