- 12 Feb, 2016 20 commits
-
-
Erik Arfvidson authored
This patch simply cleans up all checkpatch comment issues Signed-off-by:
Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Janani Ravichandran authored
Remove parentheses on the right hand side of assignment as they are not needed. Semantic patch used: @@ expression a, b, c, d; @@ ( a = (c == d) | a = - ( b - ) ) Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
For some reason I had an old linux.com address in these TODO files, point to my linuxfoundation.org address as that works properly here. Reported-by:
Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by:
-
Roger H. Newell authored
This patch fixes spelling warnings generated by checkpatch.pl Signed-off-by:
Roger H. Newell <newell.roger@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Remove parentheses around the right hand side of assignments. They are unnecessary. Semantic patch: @@ expression a, b, c; @@ ( a = (b == c) | a = - ( b - ) ) Signed-off-by:
-
Alison Schofield authored
Remove the unnecessary parens on right hand side of assignment. Found using Coccinelle: @@ identifier x; expression e1, e2; @@ - x = (e1 << e2) + x = e1 << e2 Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Chaehyun Lim authored
This patch renames the name of counter variable to i. This change makes more readability because wilc_send_config_pkt has a similar argument name as count. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
There is no need to set to 0 for counter variable before entering next for-loop statement because counter is initialized again in for-loop statement, so just remove it. Signed-off-by:
-
Chaehyun Lim authored
counter is used as for-loop control variable and indicating index of struct wid array so that it is better to use int type. There is no need to set to 0 when it is declared at the top of this function. It is initialized as 0 in for-loop statement. Signed-off-by:
-
Chaehyun Lim authored
wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return value of wilc_wlan_cfg_set or wilc_wlan_cfg_set. It is better to use int type to represent linux standard error code. Signed-off-by:
-
Dan Carpenter authored
There was a missing curly brace so this function returns failure instead of succeeding. Fixes: 06fb9336 ('staging: wilc1000: wilc_wfi_cfgoperations.c: replaces PRINT_ER with netdev_err') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Oleg Drokin authored
LUSTRE_VERSION_ALLOWED_OFFSET is only used on the server to disallow connection of old userspace clients. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Oleg Drokin authored
While initial code drop was corresponding to 2.3.64, lots of different changes went in since then, and also quite a bunch of fixes, but almost none of the new features. Code-wise we are almost at 2.5.0, so let's call it 2.4.60 - this is a version that was never reached in the actual pre-2.5 development, so it should be a clear distinction of where we are now. Signed-off-by:
-
Oleg Drokin authored
New test scripts expect spaces around state names and square brackets when parsing debugfs output, so add them to avoid false failures. Signed-off-by:
-
Oleg Drokin authored
When gettng an invalid create request in echo code (wrong group, or no group at all), just return an error instead of crashing. Signed-off-by:
-
Oleg Drokin authored
Dan Carpenter noticed that since we already checked for (oa->o_valid & OBD_MD_FLID) == 0, that means (oa->o_valid & OBD_MD_FLID) is always true after that so no point in checking for it. Signed-off-by:
-
Janani Ravichandran authored
Take the size of a dereference to a variable rather than the associated type, to make the code more resistant to type changes in the future. The type of the pointer variable here is the same as the type in the argument that is being replaced in sizeof(). Signed-off-by:
-
Rakhi Sharma authored
Remove unusefull return at the end of void function. WARNING: void function return statements are not generally useful. Signed-off-by:
Rakhi Sharma <rakhish1994@gmail.com> Changes in v3: shortened the subject line and make the discription more clear. Signed-off-by:
-
Bhumika Goyal authored
Replaced explicit NULL comparision with its simplier form. Found using coccinelle: @replace_rule@ expression e; @@ -e == NULL + !e Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Daniel Chromik authored
There is an anonymous struct which is actually used as a bitmap. So convert the struct to a bitmap and change code accordingly where needed. This also allows for a cleanup of set_data_bits and set_ctrl_bits as they can use a common helper now. The helper can also be converted to a for loop instead of doing bit OR. And given it is a for loop now, bit masking (using BIT_MSK) is moved from the callers there too. Signed-off-by:
Daniel Chromik <daniel.chromik@seznam.cz> Signed-off-by:
Jiri Slaby <jslaby@suse.cz> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Acked-by:
Willy Tarreau <willy@haproxy.com> Signed-off-by:
-
- 10 Feb, 2016 7 commits
-
-
Janani Ravichandran authored
Remove parantheses on the right hand side of assignments as they are not needed. Coccinelle patch used: @@ expression a, b, c, d; @@ ( a = (c == d) | a = - ( b - ) ) Signed-off-by:
-
Janani Ravichandran authored
Remove this comment as it does not have a meaning here. Signed-off-by:
-
Janani Ravichandran authored
Change null comparisons of the form x == NULL to !x. This was suggested by checkpatch. Signed-off-by:
-
Janani Ravichandran authored
Use kcalloc rather than kzalloc when multiplied by size to prevent integer overflows. This change also makes code nicer to read. Signed-off-by:
-
Haneen Mohammed authored
This patch removes unnecessary parantheses around rtsx->pci->dev. Signed-off-by:
Haneen Mohammed <hamohammed.sa@gmail.com> Acked-by:
-
Haneen Mohammed authored
use dma_mapping_error() instead of comparing the returned address with zero after dma_map_single(). Signed-off-by:
-
Bhumika Goyal authored
The last two lines of these functions are compressed into one. Also removed the variable ret as it is now not used. Found using coccinelle: @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by:
-
- 08 Feb, 2016 13 commits
-
-
Anjali Menon authored
Allignment matched to the open parenthesis to avoid the check detected by the checkpatch.pl. CHECK: Alignment should match open parenthesis Signed-off-by:
Anjali Menon <cse.anjalimenon@gmail.com> Signed-off-by:
-
Larry Finger authored
In routine rtl8192_tx_isr(), pointer skb is dereferenced before it is checked for NULL. This patch has only been compile-tested, as I do not have the hardware. This problem was reported at https://bugzilla.kernel.org/show_bug.cgi?id=109951. Fixes: bugzilla.kernel.org: #109951 Reported-by:
Yong Shi <brave_shi@163.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Cc: Yong Shi <brave_shi@163.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
Fix the following checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Saatvik Arya authored
fixed warnings about comment block coding style Signed-off-by:
Saatvik Arya <aryasaatvik@gmail.com> Signed-off-by:
-
Benoit Hiller authored
Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by:
Benoit Hiller <benoit.hiller@gmail.com> Signed-off-by:
-
Manuel Pégourié-Gonnard authored
The existing kerneldoc blocs had a few issues: - some of them didn't start with /** - some used -- instead of - to separate the short description - some descriptions had text looking like section headers - some descriptions started with "to" while some used the imperative: use the imperative everywhere - some had a "with:" at the end of the shortdesc that didn't make sense once formatted by kernel-docs - two argument names where out of sync with the prototype Signed-off-by:
Manuel Pégourié-Gonnard <mpg@elzevir.fr> Signed-off-by:
-
Manuel Pégourié-Gonnard authored
Using the coma operator for multiple assignments is unnecessary and just looks weird here. Signed-off-by:
-
Manuel Pégourié-Gonnard authored
The pointer is unconditionally dereferenced a few lines later, we need to make sure it isn't NULL. Signed-off-by:
-
Shraddha Barke authored
Replace bit shifting on 1 with the BIT(x) macro Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
-
Shraddha Barke authored
Remove extra blank line which is not necessary. Warning detected using checkpatch. Signed-off-by:
-
Shraddha Barke authored
Fix the checkpatch warning "No space is necessary after cast" Signed-off-by:
-
Shraddha Barke authored
Fix checkpatch issue: "CHECK: spinlock_t definition without comment". Signed-off-by:
-
Shraddha Barke authored
Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by:
-
