- 12 Apr, 2019 7 commits
-
-
Thomas Bogendoerfer authored
sysfs entries added by rtc_add_group are called with the rtc device as argument and not the underlying device. Fixed by using the dev->parent Fixes: cfb74916 ("rtc: ds1685: use rtc_add_group") Signed-off-by:
Thomas Bogendoerfer <tbogendoerfer@suse.de> Signed-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: -
Alexandre Belloni authored
Use .set_time instead of the deprecated .set_mmss. Signed-off-by: -
Alexandre Belloni authored
Call the 64bit versions of rtc_tm time conversion now that the range is enforced by the core. Signed-off-by: -
Alexandre Belloni authored
Move the optional IRQ setup to a single location. Signed-off-by: -
Alexandre Belloni authored
The LPC32xx RTC is a 32bit second counter. Signed-off-by: -
Alexandre Belloni authored
This allows further improvement of the driver. Signed-off-by:
-
- 11 Apr, 2019 16 commits
-
-
Anson Huang authored
With calling dev_pm_set_wake_irq() to set MXC_V2 RTC as wakeup source for suspend, generic wake irq mechanism will automatically enable it as wakeup source when suspend, then the suspend/resume callback which are ONLY for enabling/disabling irq wake can be removed, it simplifies the code. Signed-off-by:
Anson Huang <Anson.Huang@nxp.com> Signed-off-by:
-
Anson Huang authored
With calling dev_pm_set_wake_irq() to set MXC RTC as wakeup source for suspend, generic wake irq mechanism will automatically enable it as wakeup source when suspend, then the suspend/resume callback which are ONLY for enabling/disabling irq wake can be removed, it simplifies the code. Signed-off-by:
-
Andy Shevchenko authored
The commit 1921cab1 ("rtc: rx8025: Switch to use %ptR") converted the driver to use new %p extension, but actually used wrong type of the parameter in one case. Fix a parameter to %ptR in rx8025_read_alarm(). Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
-
YueHaibing authored
Fix sparse warning: drivers/rtc/rtc-sirfsoc.c:282:28: warning: symbol 'sysrtc_regmap_config' was not declared. Should it be static? Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Signed-off-by:
-
Alexandre Belloni authored
Use SPDX-License-Identifier instead of the custom license line. Reviewed-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
-
Alexandre Belloni authored
Use .set_time instead of the deprecated .set_mmss64. Reviewed-by:
-
Alexandre Belloni authored
The ab3100 has a 48bit counter running at 65536 Hz (despite one of the comment). The max value is then (2^48 - 1)/2^16 == 2^32 - 1. Reviewed-by:
-
Alexandre Belloni authored
Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: -
Alexandre Belloni authored
It is not necessary to forward declare pcf85363_driver as it is not used before being declared. Signed-off-by: -
Alexandre Belloni authored
regmap is abstracting the i2c functionalities the best it can, there is no need to check. Signed-off-by: -
Alexandre Belloni authored
This is a standard BCD RTC that will fail in 2100. Signed-off-by: -
Alexandre Belloni authored
pcf85363->dev is unused, remove it. Signed-off-by: -
Alexandre Belloni authored
Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: -
Alexandre Belloni authored
Use .set_time instead of the deprecated .set_mmss. Signed-off-by: -
Alexandre Belloni authored
Call the 64bit versions of rtc_tm time conversion now that the range is enforced by the core. Signed-off-by: -
Alexandre Belloni authored
From the datasheet: "HW_RTC_SECONDS provides access to the 32-bit real-time seconds counter." Signed-off-by:
-
- 08 Apr, 2019 16 commits
-
-
Alexandre Belloni authored
Use SPDX-License-Identifier instead of a verbose license text. Acked-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
-
Alexandre Belloni authored
Call the 64bit versions of rtc_tm time conversion now that the range is enforced by the core. Acked-by:
-
Alexandre Belloni authored
The Tegra 20 RTC is a 32bit seconds counter (with an unused millisecond counter). Acked-by:
-
Alexandre Belloni authored
Use SPDX-License-Identifier instead of the custom license line. Reviewed-by:
-
Alexandre Belloni authored
Use .set_time instead of the deprecated .set_mmss. Acked-by:
-
Alexandre Belloni authored
Call the 64bit versions of rtc_tm time conversion now that the range is enforced by the core. Acked-by:
-
Alexandre Belloni authored
The COH 901 331 is a 32bit seconds counter. Acked-by:
-
Alexandre Belloni authored
Use %ptR to simplify debug message. Signed-off-by: -
Alexandre Belloni authored
Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: -
Alexandre Belloni authored
Use .set_time instead of the deprecated .set_mmss. Signed-off-by: -
Alexandre Belloni authored
Use the 64bit version of rtc_time_to_tm.rtc_time_to_tm. Signed-off-by: -
Alexandre Belloni authored
ds1672_get_datetime and ds1672_set_mmss are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: -
Alexandre Belloni authored
Remove the control sysfs file as it is not documented, read only and was only used to provide the oscillator state. Signed-off-by: -
Alexandre Belloni authored
Return -EINVAL when trying to read an invalid time instead of just probe because this is a useful information for userspace. Signed-off-by: -
Alexandre Belloni authored
The ds1672 is a 32bit seconds counter. Also remove erroneous comment claiming that epoch is set to 2000, it was not. Signed-off-by: -
Alexandre Belloni authored
Use .set_time instead of the deprecated .set_mmss64. Signed-off-by:
-
- 06 Apr, 2019 1 commit
-
-
Xuefeng Wang authored
When setting rtc alarm (RTC_WKALM_SET), the tm_year is not checked if it is in suiteable range. Use INT_MAX - 1900 to check it. UBSAN: Undefined behaviour in drivers/rtc/rtc-lib.c:119:30 signed integer overflow: 2147483647 + 1900 cannot be represented in type 'int' CPU: 1 PID: 20994 Comm: syz-executor0 Not tainted 4.19.18-514.55.6.9.x86_64 + #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 ubsan_epilogue+0xe/0x81 lib/ubsan.c:159 handle_overflow+0x193/0x1e2 lib/ubsan.c:190 rtc_tm_to_time64+0x267/0x280 drivers/rtc/rtc-lib.c:119 rtc_tm_to_ktime+0x16/0x70 drivers/rtc/rtc-lib.c:129 rtc_set_alarm+0x1a9/0x2d0 drivers/rtc/interface.c:466 rtc_dev_ioctl+0x6db/0x810 drivers/rtc/rtc-dev.c:380 vfs_ioctl fs/ioctl.c:46 [inline] do_vfs_ioctl+0x1a5/0x10b0 fs/ioctl.c:690 ksys_ioctl+0x89/0xa0 fs/ioctl.c:705 __do_sys_ioctl fs/ioctl.c:712 [inline] __se_sys_ioctl fs/ioctl.c:710 [inline] __x64_sys_ioctl+0x74/0xb0 fs/ioctl.c:710 do_syscall_64+0xc8/0x580 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x462589 Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f5348896c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 000000000072bf00 RCX: 0000000000462589 RDX: 0000000020000000 RSI: 000000004028700f RDI: 0000000000000003 RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f53488976bc R13: 00000000004bf67e R14: 00000000006f96e0 R15: 00000000ffffffff ========================================================================== Signed-off-by:
Xuefeng Wang <wxf.wang@hisilicon.com> Signed-off-by:
-
