- 10 Sep, 2004 40 commits
-
-
James Bottomley authored
sizeof() != int Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Douglas Gilbert <dougg@torque.net> The patch only touches two files: scsi.h and scsi_lib.c It adds the proposed facility and then uses it in scsi_lib in roughly 4 locations. IMO there were 3 sense processing errors: - block SG_IO did not get passed back deferred errors [SG_IO is a __pass-through__ interface!!] - MEDIUM_ERRORs _do_ get processed for deferred sense errors in scsi_io_completion() which seems unintended [I did not fix this one.] - invalid command operation code handling in __scsi_mode_sense() was just wrong If people think this is a reasonable approach, then the rest of the scsi mid-level and upper level driver could be converted. As Kai pointed we may need some general routines to pick up the sense data "extras". The benefit of doing this conversion is that it may well highlight a lot more sense data processing errors (if the above is any guide). Changes: - add structure to receive normalized sense data from either fixed or descriptor format sense data - add scsi_normalize_sense() function to populate that structure - add scsi_sense_is_deferred() function so deferred errors can be ignored in many contexts - apply new mechanism to sense data processing within the scsi_lib.c file Patch reformatted by: Christoph Hellwig <hch@lst.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Douglas Gilbert authored
Douglas Gilbert wrote: > It has been reported that the change to sg.c in lk 2.6.9-rc1-bk5 > to use library jiffy functions breaks sg (albeit under vmware). > Evidentally sg devices are no longer recognised after that change. > > Reverting that changeset removes the problem. Strange, it is not > obvious why. > > At some stage I must have detected negative time spans (yeh yeh it > never happens) and my versions returned 0 in this case; otherwise > the implementations look very similar. The following patch fixes the problem. It is against lk 2.6.9-rc1-bk7 (i.e. after "standard" jiffy_to_millisecs macros replaced sg versions). Change: - make sure a (large) user supplied timeout value does not result in a negative timeout passed to the midlevel Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
Olaf Hering noticed that SG_IO was no-longer working correctly on some CD-ROMS. The reason is a change in behaviour induced by switching to the new scsi_test_unit_ready() API. Apparently the CD-ROM special case needs to ignore both UNIT_ATTENTION and NOT_READY for removable media. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Adam Radford authored
- Remove deprecated SCSI_IOCTL_SEND_COMMAND interface. - Remove deprecated /proc/scsi/3w-xxxx interface. - Convert entire driver to pci_driver format. - Remove all mdelays, replace w/msleep to fix possible watchdog timer issues. - Make all register accesses macros. - Remove all prototypes from header file, reorder functions to eliminate all prototypes but one. - Add sysfs 'queue_depth' setting attribute. - Add sysfs 'stats' attribute. - Fix spinlocks everywhere, remove tw_lock spinlock. - Remove all bitfields, add bitmask access macros. - Remove un-needed scsi_eh_abort entrypoint. Controller does not support aborting invididual IO's, scsi_eh_reset sufficient. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Update version number to 8.00.00b21-k. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Resync with latest released firmware -- 3.03.02 Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Rework interrupt-handler registration in anticipation of future chip types. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
o Always set an TCQ modifier for each command submitted. o Always (re)-initialize NVRAM during execution. o Add pci_disable_device() calls to proper locations during pci-probe failure and pci-remove. o Do not begin processing until the DPC has been marked 'active'. o Fix off-by-one error while copying sense-data. o Fix bus-reset issue during back-door execution. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Rework driver DMA allocations to use the DMA pool APIs to minimize potential run-time allocation failures. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Fixed up rejections and replaced the schedule_timeout's in the patch with msleep Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Dynamically resize request-queue during initialization based on the amount of memory available to the ISP. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
So much rearranging to just propagate the pci_module_init return value.. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Olaf Hering authored
On Wed, Aug 25, Christoph Hellwig wrote: > mesh is only present on older 32bit pmac boards and doesn't compile > on ppc64. This applies also to the other pmac-only scsi driver: Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
There's no reason to keep people from building it into their kernels statically. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
we only need <scsi/scsi_host.h> here Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
This patch adds the two devices from the private blacklist in tmscsim to the generic one. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
this one I still had in my pipe. This greatly streamlines the setup code. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Dave Jones authored
Spotted with the source checker from Coverity.com. Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Dave Jones authored
Spotted with the source checker from Coverity.com. Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Dave Jones authored
Spotted with the source checker from Coverity.com. Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Dave Jones authored
ahc_alloc already frees the 'name' if ahc=NULL Spotted with the source checker from Coverity.com. Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> incremental patch adds missing include. Signed-off-by: Domen Puncer <domen@coderock.org> Signed-off-by: Max Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Replaces schedule_timeout() with msleep() to guarantee task delays as desired. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Replace schedule_timeout() with msleep() to guarantee the task delays as desired. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Maximilian Attems authored
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time. Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Morton authored
From: Joshua Kwan <joshk@triplehelix.org> Debian's initial ramdisk creation scripts rely on the content of /proc/scsi to determine which module is needed for the ramdisk. Unfortunately, bad things happen when a bazillion different drivers use the _exact same name_ for /proc, namely the esp family. Give them all unique names. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Morton authored
From: Adrian Bunk <bunk@fs.tum.de> CC drivers/scsi/qla2xxx/qla_os.o drivers/scsi/qla2xxx/qla_os.c: In function `qla2x00_queuecommand': drivers/scsi/qla2xxx/qla_os.c:315: sorry, unimplemented: inlining failed in call to 'qla2x00_callback': function not considered for inlining drivers/scsi/qla2xxx/qla_os.c:269: sorry, unimplemented: called from here drivers/scsi/qla2xxx/qla_os.c:315: sorry, unimplemented: inlining failed in call to 'qla2x00_callback': function not considered for inlining drivers/scsi/qla2xxx/qla_os.c:269: sorry, unimplemented: called from here make[3]: *** [drivers/scsi/qla2xxx/qla_os.o] Error 1 ... CC drivers/scsi/qla2xxx/qla_rscn.o drivers/scsi/qla2xxx/qla_rscn.c: In function `qla2x00_cancel_io_descriptors': drivers/scsi/qla2xxx/qla_rscn.c:320: sorry, unimplemented: inlining failed in call to 'qla2x00_remove_iodesc_timer': function not considered for inlining drivers/scsi/qla2xxx/qla_rscn.c:257: sorry, unimplemented: called from here make[3]: *** [drivers/scsi/qla2xxx/qla_rscn.o] Error 1 Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Jeremy Higdon authored
On Sat, Aug 28, 2004 at 02:39:45AM -0700, Jeremy Higdon wrote: > > Jeremy, > > You could use a (block scope) static and only print out > > the warning the first time it is detected. > > > > Doug Gilbert > > Yes, that's a good idea -- I'll add a rate limiter and also print > out the process name like James does in his recent deprecated > ioctl warning patch. I'll send a new patch out later this weekend. > Sorry for the churn. > > thanks > > jeremy Okay, I'm pretty happy with this. I get this kind of output: sg_write: data in/out 512/512 bytes for SCSI command 0x8--guessing data in; program java not setting count and/or reply_len properly printk: 11 messages suppressed. sg_write: data in/out 512/512 bytes for SCSI command 0x8--guessing data in; program java not setting count and/or reply_len properly printk: 4 messages suppressed. signed-off-by: jeremy@sgi.com Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
- switch to a normal lists.h list for all hbas - merge BusLogic_DetectHostAdapter and BusLogic_init - move scsi_remove_host into BusLogic_ReleaseHostAdapter instead of a second iteration over all hosts Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
thanks to Mark Morschh\"auser for testing. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Douglas Gilbert authored
To check descriptor format sense data handling we need a source. Clean up some other problems and improve support for st. Changes: - add 'dsense' option to generate descriptor sense data format (default still fixed format) - correct unit attention generation (only INQUIRY, REQUEST_SENSE and REPORT_LUNS ignore it) - better information sent to log in "noisy" mode (i.e. opts=1) - correct and expand standard INQUIRY response, include version descriptors - filter MODE_SENSE command so that subpage!=0 generates error - add REWIND (SSC) command support (NOP) Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Alan Stern authored
This patch adds the BLIST_INQUIRY_36 flag to all the SCSI blacklist entries for USB devices. While it may not be strictly necessary for all of them, it doesn't hurt: Since the usb-storage driver doesn't use any of the INQUIRY data after the first 36 bytes, there's no reason to try reading any more of it. And some devices crash when we try to read more, even though they advertise that more bytes are available. The usb-storage driver does try to set the flag automatically, but the blacklist entries override that setting. Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-