1. 16 Jul, 2011 1 commit
    • Alan Stern's avatar
      USB: OHCI: fix another regression for NVIDIA controllers · 6ea12a04
      Alan Stern authored
      The NVIDIA series of OHCI controllers continues to be troublesome.  A
      few people using the MCP67 chipset have reported that even with the
      most recent kernels, the OHCI controller fails to handle new
      connections and spams the system log with "unable to enumerate USB
      port" messages.  This is different from the other problems previously
      reported for NVIDIA OHCI controllers, although it is probably related.
      
      It turns out that the MCP67 controller does not like to be kept in the
      RESET state very long.  After only a few seconds, it decides not to
      work any more.  This patch (as1479) changes the PCI initialization
      quirk code so that NVIDIA controllers are switched into the SUSPEND
      state after 50 ms of RESET.  With no interrupts enabled and all the
      downstream devices reset, and thus unable to send wakeup requests,
      this should be perfectly safe (even for non-NVIDIA hardware).
      
      The removal code in ohci-hcd hasn't been changed; it will still leave
      the controller in the RESET state.  As a result, if someone unloads
      ohci-hcd and then reloads it, the controller won't work again until
      the system is rebooted.  If anybody complains about this, the removal
      code can be updated similarly.
      
      This fixes Bugzilla #22052.
      Tested-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Cc: stable <stable@kernel.org>
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      6ea12a04
  2. 08 Jul, 2011 32 commits
  3. 05 Jul, 2011 6 commits
    • Sebastian Andrzej Siewior's avatar
      usb: gadget: fix up depencies · ac17317d
      Sebastian Andrzej Siewior authored
      Both fusb300 and langwell udcs seem to only
      work with 32-bit address space.
      Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      ac17317d
    • Sebastian Andrzej Siewior's avatar
      usb: gadget: fusb300_udc: fix compile warnings · 1425b80e
      Sebastian Andrzej Siewior authored
      - remove pointer u32 abuse in fusb300_fill_idma_prdtbl().
        It is assigned the dma_addr to a pointer and then back.
        Poor families may have to recycle variables but we don't
      
      - don't free req.buf in error case. We don't do it in the
        ok case so it is probably wrong to do it in error case.
      
      - return in error case. There is no reason to continue
        without data and performing ops on an invalid pointer.
      
      - The if (d) statement is bogus since an invalid DMA pointer
        is ~0 on some architecutres. And since we return for the
        invalid case we don't need it.
      Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      1425b80e
    • Sebastian Andrzej Siewior's avatar
      usb: gadget: ci13xx_udc.c: fix compile warning · c2b65f84
      Sebastian Andrzej Siewior authored
      Fix the following compile warning:
      
      | usb/gadget/ci13xxx_udc.c: In function 'show_registers':
      | usb/gadget/ci13xxx_udc.c:1242:1: warning: the frame size of 2064 bytes is larger than 1024 bytes
      Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      c2b65f84
    • Felipe Balbi's avatar
      usb: gadget: net2272: fix compile warnings · 7b30d19a
      Felipe Balbi authored
      This patch fixes the following compile warnings:
      
      drivers/usb/gadget/net2272.c: In function ‘net2272_kick_dma’:
      drivers/usb/gadget/net2272.c:740:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat]
      drivers/usb/gadget/net2272.c: In function ‘net2272_queue’:
      drivers/usb/gadget/net2272.c:859:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 8 has type ‘dma_addr_t’ [-Wformat]
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      7b30d19a
    • Felipe Balbi's avatar
      usb: gadget: langwell_udc: fix compile warnings · b9af9ea4
      Felipe Balbi authored
      This patch fixes the following compile warnings:
      
      drivers/usb/gadget/langwell_udc.c: In function ‘queue_dtd’:
      drivers/usb/gadget/langwell_udc.c:596:2: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/usb/gadget/langwell_udc.c: In function ‘langwell_udc_probe’:
      drivers/usb/gadget/langwell_udc.c:3274:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat]
      drivers/usb/gadget/langwell_udc.c:3289:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat]
      drivers/usb/gadget/langwell_udc.c: In function ‘langwell_udc_resume’:
      drivers/usb/gadget/langwell_udc.c:3473:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat]
      drivers/usb/gadget/langwell_udc.c:3487:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat]
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      b9af9ea4
    • Felipe Balbi's avatar
      usb: gadget: fusb300_udc: drop dead code · 4dbafd3d
      Felipe Balbi authored
      that code has been dead forever. Since the
      first commit (0fe6f1d1) the use of that code
      has been commented out. Let's drop the dead
      code already and fix the following compile
      warning:
      
      | drivers/usb/gadget/fusb300_udc.c: At top level:
      | drivers/usb/gadget/fusb300_udc.c:771:13: warning: ‘fusb300_wrfifo’ defined but not used [-Wunused-function]
      | drivers/usb/gadget/fusb300_udc.c:1027:13: warning: ‘fusb300_set_ep_bycnt’ defined but not used [-Wunused-function]
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      4dbafd3d
  4. 01 Jul, 2011 1 commit