- 10 Jan, 2004 4 commits
-
-
François Romieu authored
- endianness is kept in a fscked state as it is in the original code (will be adressed in a later patch); - buf_addr of an unmapped descriptor is always set to the same value (cf rtl8169_unmap_tx_skb); - nothing fancy, really.
-
François Romieu authored
- it forgot to update stats if the skb couldn't be expanded; - it didn't free it either if the descriptor was not available; - move the spin_unlock nearer of the exit point instead of duplicating it in the new branch.
-
François Romieu authored
- endianness is kept in a fscked state as it is in the original code (will be adressed in a later patch); - rtl8169_rx_clear() walks the buffer ring and releases the allocated data buffers. It needs to be used in two places: - rtl8169_init_ring() failure path; - normal device release (i.e. rtl8169_close); - rtl8169_free_rx_skb() releases a Rx data buffer. Mostly an helper for rtl8169_rx_clear(). As such it must: - unmap the memory area; - release the skb; - prevent the ring descriptor from being used again; - rtl8169_alloc_rx_skb() prepares a Rx data buffer for use. As such it must: - allocate an skb; - map the memory area; - reflect the changes in the ring descriptor. This function is balanced by rtl8169_free_rx_skb(). - rtl8169_unmap_rx() simply helps with the 80-columns limit. - rtl8169_rx_fill() walks a given range of the buffer ring and try to turn any descriptor into a ready to use one. It returns the count of modified descriptors and exits if an allocation fails. It can be seen as balanced by rtl8169_rx_clear(). Motivation: - partially abstract the (usually big) piece of code for the refill logic at the end of the Rx interrupt; - factorize the refill logic and the initial ring setup. - simple conversion of rtl8169_rx_interrupt() without rx_copybreak (will be adressed in a later patch).
-
François Romieu authored
- use pci_alloc_consistent() for Rx/Tx descriptors in rtl8169_open() (balanced by pci_free_consistent() on error path as well as in rtl8169_close()); - removal of the fields {Rx/Tx}DescArrays in struct rtl8169_private as there is no need to store a non-256 bytes aligned address any more; - fix for rtl8169_open() leak when RxBufferRings allocation fails. Said allocation is pushed to rtl8169_init_ring() as part of an evil cunning plan.
-
- 09 Jan, 2004 3 commits
-
-
bk://linux-dj.bkbits.net/agpgartLinus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
Dave Jones authored
Spotted by Matteo Croce
-
bk://kernel.bkbits.net/davem/sparc-2.6Linus Torvalds authored
into home.osdl.org:/home/torvalds/v2.5/linux
-
- 08 Jan, 2004 33 commits
-
-
David S. Miller authored
-
Ben Collins authored
-
Jean Tourrilhes authored
-
Jean Tourrilhes authored
From Martin Diehl.
-
Jean Tourrilhes authored
From Martin Diehl.
-
Jean Tourrilhes authored
Also, make sir-dev locking compatible with irport. From Martin Diehl.
-
Jean Tourrilhes authored
-
Kurt Garloff authored
-
Chas Williams authored
[ATM]: br2684 incorrectly handles frames recvd with FCS (by Alex Zeffertt <ajz@cambridgebroadband.com>)
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Stephen Hemminger authored
-
Keith M. Wesolowski authored
-
Keith M. Wesolowski authored
-
David S. Miller authored
-
Linus Torvalds authored
-
Dave Jones authored
Spotted by Andreas Henriksson <andreas@scream.fjortis.info>
-
bk://linux.bkbits.net/linux-2.5Nathan Scott authored
into lips.borg.umn.edu:/export/music/bkroot/xfs-linux-2.6
-
Linus Torvalds authored
We must not mark the process TASK_STOPPED early, because that might allow a signal to wake it up before we actually got to the "wake_up_forked_process()" state. Total confusion would happen. Make wake_up_forked_process() verify the new world order.
-