- 12 Feb, 2016 40 commits
-
-
Ian Abbott authored
Remove `struct comedi_trig` and some associated macros, `TRIG_DITHER`, `TRIG_DEGLITCH`, `TRIG_CONFIG`, and ioctl code `COMEDI_TRIG`. These have been obsolete since COMEDI release 0.7.61 back in November 2001. The userspace COMEDILIB library still has some deprecated code that may attempt to use these, but it uses its own, compatible version of "comedi.h", so isn't affected by their removal from the kernel copy. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ian Abbott authored
Add "kernel-doc"-formatted comments to the COMEDI `struct` declarations used with ioctls. Don't bother documenting `struct comedi_trig` as it is obsolete and not supported. Signed-off-by:
-
Ian Abbott authored
Add "kernel-doc"-formatted comments to COMEDI's general-purpose `enum` type declarations. Don't bother documenting the low-level driver-specific ones for now. Move the declaration of `enum comedi_counter_status_flags` next to the other general-purpose `enum` types. Signed-off-by:
-
Ian Abbott authored
The wording at the start of the header comment is a bit misleading, particularly the part in parentheses: "(installed as /usr/include/comedi.h)". This version of "comedi.h" certainly won't be installed as that pathname. Fix it. Signed-off-by:
-
Aaro Koskinen authored
Refactor RGMII 10 Mbps preamble error checking. The current implementation does not work correctly in phydev mode since only the link status changes trigger the callback, and if we stay on 10 Mbps operation the periodic checks for error counters are never done. Provide a periodic worker also during the phydev operation, and notify the link status changes through the phydev instead of the inband status change interrupt. This also has the benefit that we don't need to use legacy CVMX MDIO calls to check the PHY state, and we can avoid races that trigger bogus "Using 10Mbps with software preamble removal" logs when interfaces are being bringed up. It also avoids some corner-case crashes when the in-band interrupt triggers while the interface is being taken down. Tested on EdgeRouter Lite & D-Link DSR-1000N. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Janani Ravichandran authored
Remove parentheses around the right hand side of assignments as they are not needed. Semantic patch used: @@ expression a, b, c; @@ ( a = (b == c) | a = - ( b - ) ) Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Add spaces around operators for better readability. Change suggested by checkpatch. Signed-off-by:
-
Sudip Mukherjee authored
We were returning ENOMEM on all types of errors. Lets return the actual error code. At the same time remove the label which became unused as a result of this patch. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Sudip Mukherjee authored
On error we were returning retval, but retval is not having the error value. We will get the error value using PTR_ERR. Signed-off-by:
-
Janani Ravichandran authored
Boolean variables should be assigned true/false rather than 1/0. This patch makes a correction on such a variable which has boolean values assigned in all other places within the file. Signed-off-by:
-
Janani Ravichandran authored
Remove parentheses on the right hand side of assignment as they are not needed. Semantic patch used: @@ expression a, b, c, d; @@ ( a = (c == d) | a = - ( b - ) ) Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Benjamin Romer authored
parser_param_start() had a goto Away, which went to nothing but a return statement. Remove the goto, the CamelCased label, and just return directly. Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Erik Arfvidson authored
This patch fixes the following types of check patch warnings: else is not generally useful after a break or return Signed-off-by:
Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by:
-
Erik Arfvidson authored
This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by:
-
Erik Arfvidson authored
This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by:
-
Erik Arfvidson authored
This patch fixes the following types of check patch warnings: Block comments use a trailing */ on a separate line Comment alignments Signed-off-by:
-
Erik Arfvidson authored
This patch fixes checkpatch's no space is necessary after a cast Signed-off-by:
-
Erik Arfvidson authored
this patch removes the following checkpatch warnings: please use a blank line after … Please don’t use multiple blank lines Signed-off-by:
-
Erik Arfvidson authored
This patch fixes the following type of check patch warnings: Comparison to NULL could be written Signed-off-by:
-
Erik Arfvidson authored
This patch fixes the following checkpatch warning: spaces preferred around that ‘*’ or ‘|’ Signed-off-by:
-
Erik Arfvidson authored
This patch fixes all the Block comments by using a trailing */ on a separate line Signed-off-by:
-
Erik Arfvidson authored
Fixes checkpatch trailing */ comment in vbusdeviceinfo.h Signed-off-by:
-
Erik Arfvidson authored
This patches resolves the NULL comparison checkpatch warnings Signed-off-by:
-
Erik Arfvidson authored
This patch simply fixes all trailing */ by modifying the comments structures while trying to reduce the total number of lines Signed-off-by:
-
Erik Arfvidson authored
This patch simply cleans up all checkpatch comment issues Signed-off-by:
-
Janani Ravichandran authored
Remove parentheses on the right hand side of assignment as they are not needed. Semantic patch used: @@ expression a, b, c, d; @@ ( a = (c == d) | a = - ( b - ) ) Signed-off-by:
-
Greg Kroah-Hartman authored
For some reason I had an old linux.com address in these TODO files, point to my linuxfoundation.org address as that works properly here. Reported-by:
Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by:
-
Roger H. Newell authored
This patch fixes spelling warnings generated by checkpatch.pl Signed-off-by:
Roger H. Newell <newell.roger@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Remove parentheses around the right hand side of assignments. They are unnecessary. Semantic patch: @@ expression a, b, c; @@ ( a = (b == c) | a = - ( b - ) ) Signed-off-by:
-
Alison Schofield authored
Remove the unnecessary parens on right hand side of assignment. Found using Coccinelle: @@ identifier x; expression e1, e2; @@ - x = (e1 << e2) + x = e1 << e2 Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Acked-by:
-
Chaehyun Lim authored
This patch renames the name of counter variable to i. This change makes more readability because wilc_send_config_pkt has a similar argument name as count. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
There is no need to set to 0 for counter variable before entering next for-loop statement because counter is initialized again in for-loop statement, so just remove it. Signed-off-by:
-
Chaehyun Lim authored
counter is used as for-loop control variable and indicating index of struct wid array so that it is better to use int type. There is no need to set to 0 when it is declared at the top of this function. It is initialized as 0 in for-loop statement. Signed-off-by:
-
Chaehyun Lim authored
wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return value of wilc_wlan_cfg_set or wilc_wlan_cfg_set. It is better to use int type to represent linux standard error code. Signed-off-by:
-
Dan Carpenter authored
There was a missing curly brace so this function returns failure instead of succeeding. Fixes: 06fb9336 ('staging: wilc1000: wilc_wfi_cfgoperations.c: replaces PRINT_ER with netdev_err') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Oleg Drokin authored
LUSTRE_VERSION_ALLOWED_OFFSET is only used on the server to disallow connection of old userspace clients. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Oleg Drokin authored
While initial code drop was corresponding to 2.3.64, lots of different changes went in since then, and also quite a bunch of fixes, but almost none of the new features. Code-wise we are almost at 2.5.0, so let's call it 2.4.60 - this is a version that was never reached in the actual pre-2.5 development, so it should be a clear distinction of where we are now. Signed-off-by:
-
Oleg Drokin authored
New test scripts expect spaces around state names and square brackets when parsing debugfs output, so add them to avoid false failures. Signed-off-by:
-
Oleg Drokin authored
When gettng an invalid create request in echo code (wrong group, or no group at all), just return an error instead of crashing. Signed-off-by:
-
Oleg Drokin authored
Dan Carpenter noticed that since we already checked for (oa->o_valid & OBD_MD_FLID) == 0, that means (oa->o_valid & OBD_MD_FLID) is always true after that so no point in checking for it. Signed-off-by:
-
