An error occurred fetching the project authors.
  1. 16 Jan, 2004 1 commit
    • Alan Stern's avatar
      [PATCH] USB Storage: Remove non s-g pathway from subdriver READ/WRITE · 760c3b3a
      Alan Stern authored
      This patch does what you suggested.  The read/write routines from the
      updated subdrivers are changed so they don't bother to differentiate
      between transfers that do or do not use scatter-gather.  The low-level
      usb_stor_access_xfer_buf routine will Do The Right Thing regardless, and
      there probably won't ever be more than a few non s-g calls.  (What about
      filesystem I/O requests to access metadata?)
      
      It turns out that in addition to removing some comments and a few tests,
      this change allowed me to remove the buffer and use_sg arguments passed to
      the read/write routines as well.  So the simplification ended up being a
      bit bigger than I expected.
      
      While writing this patch, I noticed spots in several drivers that still
      need to be changed -- they slipped past me before.  These drivers handle
      things like READ-CAPACITY or REQUEST-SENSE by copying the data directly to
      srb->request_buffer, which is obviously wrong if s-g is being used.  I'll
      send in changes next week that convert them to use the
      usb_stor_set_xfer_buf function.  Like you said, it's going to be handy in
      more places than originally intended!
      760c3b3a
  2. 09 Dec, 2003 2 commits
    • Alan Stern's avatar
      [PATCH] USB storage: Add comments explaining new s-g usage · 343f4be5
      Alan Stern authored
      On Sun, 30 Nov 2003, Matthew Dharm wrote:
      > I'm going to pass this one along to Greg, but I think some places in this
      > could really use some better comments.  Especially the way you use a single
      > buffer inside the loop -- it took me a few minutes to figure out how your
      > logic to refresh the buffer with new data worked.
      >
      > I'm also wondering if the access_xfer_buf() function could use some more
      > header comments, stating why this is needed (i.e. spelling out the
      > kmap()-isms).
      
      Okay, here it is.  This patch basically just adds comments.  Each routine
      that uses the new scatter-gather function gets a brief explanation of
      what's going on, and access_xfer_buf() itself gets detailed comments
      saying what it's doing and why it's necessary.  You may even want to cut
      some of it back; I was pretty verbose.
      343f4be5
    • Alan Stern's avatar
      [PATCH] USB storage: Convert sddr55 to use the new s-g routines · fb56d31d
      Alan Stern authored
      This patch changes the sddr55 driver to make it use the new scatter-gather
      routines.  It has not been tested, but perhaps Andries Brouwer will be
      able to try it out.
      fb56d31d
  3. 16 Jul, 2003 1 commit
  4. 05 Nov, 2002 1 commit
  5. 13 Oct, 2002 2 commits
  6. 26 Sep, 2002 1 commit
    • Tim Schmielau's avatar
      [PATCH] fix compares of jiffies · d19b3a36
      Tim Schmielau authored
      on rechecking the current stable kernel code, I found some places where jiffies
      were compared in a way that seems to break when they wrap. For these,
      I made up patches to use the macros "time_before()" or "time_after()"
      that are supposed to handle wraparound correctly.
      d19b3a36
  7. 23 Sep, 2002 1 commit
    • Alan Stern's avatar
      [PATCH] usb-storage: fix return codes... · 0d80c6f5
      Alan Stern authored
      Like the header says, this patch fixes up the various Transfer- and
      Transport-level return codes.  There were a lot of places in the various
      subdrivers that were not particularly careful about distinguishing the
      two; it would help if the people currently maintaining those drivers could
      take a look at my changes to make sure I haven't screwed anything up.
      
      # Converted US_BULK_TRANSFER_xxx to USB_STOR_XFER_xxx, to make it more
      # easily distinguishable from USB_STOR_TRANSPORT_xxx.  (Also, in the
      # future these codes may apply to control transfers as well as to bulk
      # transfers.)
      #
      # Changed USB_STOR_XFER_FAILED to USB_STOR_XFER_ERROR, since it implies
      # a transport error rather than a transport failure.
      #
      # Added a USB_STOR_XFER_STALLED code, to indicate a transfer that was
      # terminated by an endpoint stall.
      
      This patch is in preparation for one in which usb_stor_transfer_partial()
      and usb_stor_transfer() are replaced by usb_stor_bulk_transfer_buf() and
      usb_stor_bulk_transfer_srb() respectively, with slightly different
      argument lists.  Ultimately the subdrivers will be able to use these
      routines in place of the slightly specialized versions they have now and
      in place of the ones in raw_bulk.c.
      0d80c6f5
  8. 22 May, 2002 1 commit
    • Rusty Russell's avatar
      [PATCH] jiffies.h · a58a8db0
      Rusty Russell authored
      Trivial patch update against 2.5.17:
      Tim Schmielau <tim@physik3.uni-rostock.de>: move jiffies from sched.h to it's own jiffies.h:
        Move 'jiffies' from sched.h to their own header.
        Then pull the sched.h dependency from 67 files that include sched.h for
        no apparent reason other than the jiffies declaration.
      
        Move the time_[before,after}{_eq}() macros from timer.h to jiffies.h,
        since there are *no* files using them that don't also use jiffies.
      
        Many more sched.h dependencies can be killed after capable(),
        request_irq(), and free_irq() are moved out of <linux/sched.h>.
      
      
        Tim Schmielau <tim@physik3.uni-rostock.de>
      a58a8db0
  9. 21 May, 2002 1 commit
    • Andries E. Brouwer's avatar
      [PATCH] usb-storage · eae28375
      Andries E. Brouwer authored
      Created the first of a series of usb-storage patches
      this afternoon. Please find it below or on ftp.XX.kernel.org
      under people/aeb/2.5.16-us-patch .
      It removes 5% of the usb-storage code, but should, if I made
      no mistake, not affect the behaviour of the code.
      
      (This is the introduction of raw_bulk.c to hold USB-bulk
      and scatter-gather code that was repeated three-five times
      in various drivers. The next patch is smartmedia.c.)
      eae28375
  10. 11 May, 2002 1 commit