1. 26 Sep, 2014 40 commits
    • Mauro Carvalho Chehab's avatar
      [media] usb drivers: use %zu instead of %zd · 7983b773
      Mauro Carvalho Chehab authored
      size_t is unsigned.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      7983b773
    • Mauro Carvalho Chehab's avatar
      [media] pci drivers: use %zu instead of %zd · 339f06c5
      Mauro Carvalho Chehab authored
      size_t is unsigned.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      339f06c5
    • Mauro Carvalho Chehab's avatar
      [media] dvb-frontends: use %zu instead of %zd · 35f30f36
      Mauro Carvalho Chehab authored
      size_t is unsigned.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      35f30f36
    • Mauro Carvalho Chehab's avatar
      [media] s5p-mfc: Fix several printk warnings · 03ce7816
      Mauro Carvalho Chehab authored
      drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c:192:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘dma_addr_t’ [-Wformat=]
      drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c:196:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘dma_addr_t’ [-Wformat=]
      drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c:196:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat=]
      drivers/media/platform/s5p-mfc/s5p_mfc_dec.c:1206:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/media/platform/s5p-mfc/s5p_mfc_dec.c:1206:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:1757:3: warning: format ‘%zx’ expects argument of type ‘size_t’, but argument 6 has type ‘dma_addr_t’ [-Wformat=]
      drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:1879:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media/platform/s5p-mfc/s5p_mfc_dec.c:1206:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      drivers/media/platform/s5p-mfc/s5p_mfc_dec.c:1206:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      03ce7816
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc_opr: Fix warnings · f1a0c185
      Mauro Carvalho Chehab authored
        CC      drivers/media//platform/s5p-mfc/s5p_mfc_opr.o
      drivers/media//platform/s5p-mfc/s5p_mfc_opr.c: In function ‘s5p_mfc_alloc_priv_buf’:
      drivers/media//platform/s5p-mfc/s5p_mfc_opr.c:44:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
        mfc_debug(3, "Allocating priv: %d\n", b->size);
        ^
      drivers/media//platform/s5p-mfc/s5p_mfc_opr.c:53:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat=]
        mfc_debug(3, "Allocated addr %p %08x\n", b->virt, b->dma);
        ^
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      f1a0c185
    • Mauro Carvalho Chehab's avatar
      [media] ti-vpe: Fix typecast · 5b31d9e0
      Mauro Carvalho Chehab authored
      Addresses have the same size of unsigned long, and not u32.
      
      That removes a warning on 64 bits compilation:
      drivers/media//platform/ti-vpe/vpdma.c:332:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        WARN_ON(((u32) buf->addr & VPDMA_DESC_ALIGN) != 0);
                 ^
      include/asm-generic/bug.h:86:25: note: in definition of macro ‘WARN_ON’
        int __ret_warn_on = !!(condition);    \
                               ^
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      5b31d9e0
    • Mauro Carvalho Chehab's avatar
      [media] s3c-camif: fix dma_addr_t printks · c0a566f3
      Mauro Carvalho Chehab authored
      drivers/media//platform/s3c-camif/camif-capture.c: In function ‘camif_prepare_addr’:
      include/linux/dynamic_debug.h:64:16: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat=]
        static struct _ddebug  __aligned(8)   \
                      ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:266:2: note: in expansion of macro ‘dynamic_pr_debug’
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      drivers/media//platform/s3c-camif/camif-capture.c:283:2: note: in expansion of macro ‘pr_debug’
        pr_debug("DMA address: y: %#x  cb: %#x cr: %#x\n",
        ^
      include/linux/dynamic_debug.h:64:16: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat=]
        static struct _ddebug  __aligned(8)   \
                      ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:266:2: note: in expansion of macro ‘dynamic_pr_debug’
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      drivers/media//platform/s3c-camif/camif-capture.c:283:2: note: in expansion of macro ‘pr_debug’
        pr_debug("DMA address: y: %#x  cb: %#x cr: %#x\n",
        ^
      include/linux/dynamic_debug.h:64:16: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat=]
        static struct _ddebug  __aligned(8)   \
                      ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:266:2: note: in expansion of macro ‘dynamic_pr_debug’
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      drivers/media//platform/s3c-camif/camif-capture.c:283:2: note: in expansion of macro ‘pr_debug’
        pr_debug("DMA address: y: %#x  cb: %#x cr: %#x\n",
        ^
      include/linux/dynamic_debug.h:64:16: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat=]
        static struct _ddebug  __aligned(8)   \
                      ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:266:2: note: in expansion of macro ‘dynamic_pr_debug’
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      drivers/media//platform/s3c-camif/camif-regs.c:217:2: note: in expansion of macro ‘pr_debug’
        pr_debug("dst_buf[%d]: %#X, cb: %#X, cr: %#X\n",
        ^
      include/linux/dynamic_debug.h:64:16: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat=]
        static struct _ddebug  __aligned(8)   \
                      ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:266:2: note: in expansion of macro ‘dynamic_pr_debug’
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      drivers/media//platform/s3c-camif/camif-regs.c:217:2: note: in expansion of macro ‘pr_debug’
        pr_debug("dst_buf[%d]: %#X, cb: %#X, cr: %#X\n",
        ^
      include/linux/dynamic_debug.h:64:16: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 8 has type ‘dma_addr_t’ [-Wformat=]
        static struct _ddebug  __aligned(8)   \
                      ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:266:2: note: in expansion of macro ‘dynamic_pr_debug’
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      drivers/media//platform/s3c-camif/camif-regs.c:217:2: note: in expansion of macro ‘pr_debug’
        pr_debug("dst_buf[%d]: %#X, cb: %#X, cr: %#X\n",
        ^
      Acked-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      c0a566f3
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc_opr_v6: get rid of warnings when compiled with 64 bits · 4966bac1
      Mauro Carvalho Chehab authored
      There are several errors related to size_t size and the usage of
      unsigned int for pointers:
      
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_alloc_codec_buffers_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:103:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
         mfc_debug(2, "recon luma size: %d chroma size: %d\n",
         ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:103:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_set_dec_frame_buffer_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:472:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘size_t’ [-Wformat=]
         mfc_debug(2, "Luma %d: %x\n", i,
         ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:476:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘size_t’ [-Wformat=]
         mfc_debug(2, "\tChroma %d: %x\n", i,
         ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:490:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ [-Wformat=]
          mfc_debug(2, "\tBuf1: %x, size: %d\n",
          ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:498:2: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ [-Wformat=]
        mfc_debug(2, "Buf1: %u, buf_size1: %d (frames %d)\n",
        ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_set_enc_ref_buffer_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:596:2: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ [-Wformat=]
        mfc_debug(2, "Buf1: %u, buf_size1: %d (ref frames %d)\n",
        ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_write_info_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:1883:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        writel(data, (volatile void __iomem *)ofs);
                     ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_read_info_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:1893:14: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        ret = readl((volatile void __iomem *)ofs);
                    ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_get_pic_type_top_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2022:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         (__force unsigned int) ctx->dev->mfc_regs->d_ret_picture_tag_top);
         ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_get_pic_type_bot_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2028:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         (__force unsigned int) ctx->dev->mfc_regs->d_ret_picture_tag_bot);
         ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_get_crop_info_h_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2034:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         (__force unsigned int) ctx->dev->mfc_regs->d_display_crop_info1);
         ^
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c: In function ‘s5p_mfc_get_crop_info_v_v6’:
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2040:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         (__force unsigned int) ctx->dev->mfc_regs->d_display_crop_info2);
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      4966bac1
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc_opr_v5: Fix lots of warnings on x86_64 · e13f7d5a
      Mauro Carvalho Chehab authored
      When compiled on x86_64, several warnings popup:
      
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:476:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:480:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:485:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:493:2: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:570:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:570:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:609:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:609:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:640:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:640:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:666:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
      drivers/media//platform/s5p-mfc/s5p_mfc_opr_v5.c:666:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      e13f7d5a
    • Mauro Carvalho Chehab's avatar
      [media] em28xx: Fix identation · 0db32414
      Mauro Carvalho Chehab authored
      drivers/media/usb/em28xx/em28xx-audio.c:270 snd_em28xx_capture_open() warn: if statement not indented
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      0db32414
    • Mauro Carvalho Chehab's avatar
      [media] drxd: remove a dead code · b39ba19c
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/drxd_hard.c:2839 drxd_init() info: ignoring unreachable code.
      
      Firmware request/release is not at drxd_init. So, we can remove
      that dead code.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      b39ba19c
    • Mauro Carvalho Chehab's avatar
      [media] saa7146: remove return after BUG() · ae64b5ab
      Mauro Carvalho Chehab authored
      As reported by smatch:
      	drivers/media/common/saa7146/saa7146_fops.c:314 fops_mmap() info: ignoring unreachable code.
      	drivers/media/common/saa7146/saa7146_fops.c:402 fops_read() info: ignoring unreachable code.
      	drivers/media/common/saa7146/saa7146_fops.c:426 fops_write() info: ignoring unreachable code.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      ae64b5ab
    • Mauro Carvalho Chehab's avatar
      [media] cx88: remove return after BUG() · 84babee8
      Mauro Carvalho Chehab authored
      As reported by smatch:
      
      drivers/media/pci/cx88/cx88-video.c:699 get_queue() info: ignoring unreachable code.
      drivers/media/pci/cx88/cx88-video.c:714 get_resource() info: ignoring unreachable code.
      drivers/media/pci/cx88/cx88-video.c:815 video_read() info: ignoring unreachable code.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      84babee8
    • Mauro Carvalho Chehab's avatar
      [media] cx88: fix cards table CodingStyle · e2392d34
      Mauro Carvalho Chehab authored
      This is actually a coding style issue, but it was generating lots
      of smatch warnings:
      
      drivers/media/pci/cx88/cx88-cards.c:1513:37: warning: Initializer entry defined twice
      drivers/media/pci/cx88/cx88-cards.c:1517:19:   also defined here
      drivers/media/pci/cx88/cx88-cards.c:1533:36: warning: Initializer entry defined twice
      drivers/media/pci/cx88/cx88-cards.c:1538:19:   also defined here
      ...
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      e2392d34
    • Mauro Carvalho Chehab's avatar
      [media] radio-sf16fmr2: declare some structs as static · 25fb62b6
      Mauro Carvalho Chehab authored
      drivers/media/radio/radio-sf16fmr2.c:308:19: warning: symbol 'fmr2_isa_driver' was not declared. Should it be static?
      drivers/media/radio/radio-sf16fmr2.c:316:19: warning: symbol 'fmr2_pnp_driver' was not declared. Should it be static?
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      25fb62b6
    • Mauro Carvalho Chehab's avatar
      [media] radio-sf16fmi: declare pnp_attached as static · 24c8f11f
      Mauro Carvalho Chehab authored
      drivers/media/radio/radio-sf16fmi.c:59:6: warning: symbol 'pnp_attached' was not declared. Should it be static?
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      24c8f11f
    • Mauro Carvalho Chehab's avatar
      [media] pms: Fix a bad usage of the stack · 64e01cbd
      Mauro Carvalho Chehab authored
      As warned by smatch:
      	drivers/media/parport/pms.c:632:21: warning: Variable length array is used.
      
      The pms driver is doing something really bad: it is using the
      stack to read data into a buffer whose size is given by the
      user by the read() syscall. Replace it by a dynamically allocated
      buffer.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      64e01cbd
    • Mauro Carvalho Chehab's avatar
      [media] saa7164-core: declare symbols as static · 5a9ff85d
      Mauro Carvalho Chehab authored
      Those symbols are used only at saa7164-core.
      
      drivers/media/pci/saa7164/saa7164-core.c:55:14: warning: symbol 'fw_debug' was not declared. Should it be static?
      drivers/media/pci/saa7164/saa7164-core.c:75:14: warning: symbol 'print_histogram' was not declared. Should it be static?
      drivers/media/pci/saa7164/saa7164-core.c:83:14: warning: symbol 'guard_checking' was not declared. Should it be static?
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      5a9ff85d
    • Mauro Carvalho Chehab's avatar
      [media] sta2x11_vip: fix address space casting · 87f4ebcd
      Mauro Carvalho Chehab authored
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:1140:30: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:1140:30:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:1140:30:    got void volatile [noderef] <asn:2>*iomem
      drivers/media/pci/sta2x11/sta2x11_vip.c:1184:30: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:1184:30:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:1184:30:    got void volatile [noderef] <asn:2>*iomem
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38: warning: incorrect type in argument 1 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:226:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    expected void [noderef] <asn:2>*<noident>
      drivers/media/pci/sta2x11/sta2x11_vip.c:221:38:    got void volatile [noderef] <asn:2>*
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      87f4ebcd
    • Mauro Carvalho Chehab's avatar
      [media] st_rc: fix address space casting · 8f8218e8
      Mauro Carvalho Chehab authored
      drivers/media/rc/st_rc.c:107:38: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/st_rc.c:107:38:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:107:38:    got void *
      drivers/media/rc/st_rc.c:110:53: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/st_rc.c:110:53:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:110:53:    got void *
      drivers/media/rc/st_rc.c:116:54: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:116:54:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:116:54:    got void *
      drivers/media/rc/st_rc.c:120:45: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/st_rc.c:120:45:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:120:45:    got void *
      drivers/media/rc/st_rc.c:121:43: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/st_rc.c:121:43:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:121:43:    got void *
      drivers/media/rc/st_rc.c:150:46: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/st_rc.c:150:46:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:150:46:    got void *
      drivers/media/rc/st_rc.c:153:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:153:42:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:153:42:    got void *
      drivers/media/rc/st_rc.c:174:32: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:174:32:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:174:32:    got void *
      drivers/media/rc/st_rc.c:177:48: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:177:48:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:177:48:    got void *
      drivers/media/rc/st_rc.c:187:48: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:187:48:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:187:48:    got void *
      drivers/media/rc/st_rc.c:204:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:204:42:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:204:42:    got void *
      drivers/media/rc/st_rc.c:205:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:205:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:205:35:    got void *
      drivers/media/rc/st_rc.c:215:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:215:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:215:35:    got void *
      drivers/media/rc/st_rc.c:216:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:216:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:216:35:    got void *
      drivers/media/rc/st_rc.c:269:22: warning: incorrect type in assignment (different address spaces)
      drivers/media/rc/st_rc.c:269:22:    expected void *base
      drivers/media/rc/st_rc.c:269:22:    got void [noderef] <asn:2>*
      drivers/media/rc/st_rc.c:349:46: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:349:46:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:349:46:    got void *
      drivers/media/rc/st_rc.c:350:46: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:350:46:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:350:46:    got void *
      drivers/media/rc/st_rc.c:371:61: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:371:61:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:371:61:    got void *
      drivers/media/rc/st_rc.c:372:54: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/st_rc.c:372:54:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/st_rc.c:372:54:    got void *
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      8f8218e8
    • Mauro Carvalho Chehab's avatar
      [media] ir-hix5hd2: fix address space casting · 7f01308e
      Mauro Carvalho Chehab authored
      drivers/media/rc/ir-hix5hd2.c:99:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:99:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:99:41:    got void *
      drivers/media/rc/ir-hix5hd2.c:100:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:100:16:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:100:16:    got void *
      drivers/media/rc/ir-hix5hd2.c:117:40: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:117:40:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:117:40:    got void *
      drivers/media/rc/ir-hix5hd2.c:119:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:119:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:119:41:    got void *
      drivers/media/rc/ir-hix5hd2.c:121:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:121:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:121:41:    got void *
      drivers/media/rc/ir-hix5hd2.c:147:18: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:147:18:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:147:18:    got void *
      drivers/media/rc/ir-hix5hd2.c:155:28: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:155:28:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:155:28:    got void *
      drivers/media/rc/ir-hix5hd2.c:157:25: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:157:25:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:157:25:    got void *
      drivers/media/rc/ir-hix5hd2.c:159:61: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:159:61:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:159:61:    got void *
      drivers/media/rc/ir-hix5hd2.c:167:28: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:167:28:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:167:28:    got void *
      drivers/media/rc/ir-hix5hd2.c:169:36: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:169:36:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:169:36:    got void *
      drivers/media/rc/ir-hix5hd2.c:188:64: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:188:64:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:188:64:    got void *
      drivers/media/rc/ir-hix5hd2.c:190:68: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:190:68:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:190:68:    got void *
      drivers/media/rc/ir-hix5hd2.c:220:20: warning: incorrect type in assignment (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:220:20:    expected void *base
      drivers/media/rc/ir-hix5hd2.c:220:20:    got void [noderef] <asn:2>*
      drivers/media/rc/ir-hix5hd2.c:315:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:315:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:315:41:    got void *
      drivers/media/rc/ir-hix5hd2.c:316:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:316:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:316:41:    got void *
      drivers/media/rc/ir-hix5hd2.c:317:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:317:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:317:41:    got void *
      drivers/media/rc/ir-hix5hd2.c:318:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/rc/ir-hix5hd2.c:318:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/rc/ir-hix5hd2.c:318:41:    got void *
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      7f01308e
    • Mauro Carvalho Chehab's avatar
      [media] as102: fix endiannes casts · d51a12c9
      Mauro Carvalho Chehab authored
      Smatch complains a lot about endiannes issues on as102:
      
      drivers/media/usb/as102/as10x_cmd_stream.c:41:47: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_stream.c:41:47:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_stream.c:41:47:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_stream.c:43:43: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_stream.c:43:43:    expected unsigned short [unsigned] [usertype] pid
      drivers/media/usb/as102/as10x_cmd_stream.c:43:43:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_stream.c:98:47: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_stream.c:98:47:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_stream.c:98:47:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_stream.c:100:43: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_stream.c:100:43:    expected unsigned short [unsigned] [usertype] pid
      drivers/media/usb/as102/as10x_cmd_stream.c:100:43:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_stream.c:142:48: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_stream.c:142:48:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_stream.c:142:48:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_stream.c:185:47: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_stream.c:185:47:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_stream.c:185:47:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:46:40: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:46:40:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_cfg.c:46:40:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:47:36: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:47:36:    expected unsigned short [unsigned] [usertype] tag
      drivers/media/usb/as102/as10x_cmd_cfg.c:47:36:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:48:37: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:48:37:    expected unsigned short [unsigned] [usertype] type
      drivers/media/usb/as102/as10x_cmd_cfg.c:48:37:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:72:27: warning: cast to restricted __le32
      drivers/media/usb/as102/as10x_cmd_cfg.c:102:40: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:102:40:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_cfg.c:102:40:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:104:50: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:104:50:    expected unsigned int [unsigned] [usertype] value32
      drivers/media/usb/as102/as10x_cmd_cfg.c:104:50:    got restricted __le32 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:105:36: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:105:36:    expected unsigned short [unsigned] [usertype] tag
      drivers/media/usb/as102/as10x_cmd_cfg.c:105:36:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:106:37: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:106:37:    expected unsigned short [unsigned] [usertype] type
      drivers/media/usb/as102/as10x_cmd_cfg.c:106:37:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:156:48: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd_cfg.c:156:48:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd_cfg.c:156:48:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd_cfg.c:197:14: warning: cast to restricted __le16
      drivers/media/usb/as102/as10x_cmd.c:40:40: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:40:40:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:40:40:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:81:41: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:81:41:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:81:41:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:123:41: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:123:41:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:123:41:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:124:43: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:124:43:    expected unsigned int [unsigned] [usertype] freq
      drivers/media/usb/as102/as10x_cmd.c:124:43:    got restricted __le32 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:178:48: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:178:48:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:178:48:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:202:17: warning: cast to restricted __le16
      drivers/media/usb/as102/as10x_cmd.c:203:24: warning: cast to restricted __le16
      drivers/media/usb/as102/as10x_cmd.c:204:24: warning: cast to restricted __le16
      drivers/media/usb/as102/as10x_cmd.c:230:48: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:230:48:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:230:48:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:262:25: warning: cast to restricted __le16
      drivers/media/usb/as102/as10x_cmd.c:289:48: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:289:48:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:289:48:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:313:17: warning: cast to restricted __le32
      drivers/media/usb/as102/as10x_cmd.c:315:17: warning: cast to restricted __le32
      drivers/media/usb/as102/as10x_cmd.c:317:17: warning: cast to restricted __le32
      drivers/media/usb/as102/as10x_cmd.c:319:17: warning: cast to restricted __le16
      drivers/media/usb/as102/as10x_cmd.c:349:48: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:349:48:    expected unsigned short [unsigned] [usertype] proc_id
      drivers/media/usb/as102/as10x_cmd.c:349:48:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:387:29: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:387:29:    expected unsigned short [unsigned] [usertype] req_id
      drivers/media/usb/as102/as10x_cmd.c:387:29:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:388:27: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:388:27:    expected unsigned short [unsigned] [usertype] prog
      drivers/media/usb/as102/as10x_cmd.c:388:27:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:389:30: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:389:30:    expected unsigned short [unsigned] [usertype] version
      drivers/media/usb/as102/as10x_cmd.c:389:30:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:390:31: warning: incorrect type in assignment (different base types)
      drivers/media/usb/as102/as10x_cmd.c:390:31:    expected unsigned short [unsigned] [usertype] data_len
      drivers/media/usb/as102/as10x_cmd.c:390:31:    got restricted __le16 [usertype] <noident>
      drivers/media/usb/as102/as10x_cmd.c:408:14: warning: cast to restricted __le16
      
      This happens because of the command endiannes that are sent/received to
      the firmware. So, add the correct endiannes tags to the command fields.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      d51a12c9
    • Mauro Carvalho Chehab's avatar
      [media] dvb_frontend: Fix __user namespace · 71d1b2be
      Mauro Carvalho Chehab authored
      As reported by smatch:
      
      drivers/media/dvb-core/dvb_frontend.c:1960:45: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/dvb-core/dvb_frontend.c:1960:45:    expected void const [noderef] <asn:1>*from
      drivers/media/dvb-core/dvb_frontend.c:1960:45:    got struct dtv_property *[noderef] <asn:1>props
      drivers/media/dvb-core/dvb_frontend.c:1992:45: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/dvb-core/dvb_frontend.c:1992:45:    expected void const [noderef] <asn:1>*from
      drivers/media/dvb-core/dvb_frontend.c:1992:45:    got struct dtv_property *[noderef] <asn:1>props
      drivers/media/dvb-core/dvb_frontend.c:2014:38: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/dvb-core/dvb_frontend.c:2014:38:    expected void [noderef] <asn:1>*to
      drivers/media/dvb-core/dvb_frontend.c:2014:38:    got struct dtv_property *[noderef] <asn:1>props
      drivers/media/dvb-core/dvb_frontend.c:1946:17: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1947:17: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1951:22: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1951:42: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1954:31: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1960:41: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1960:54: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1965:33: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1978:17: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1979:17: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1983:22: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1983:42: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1986:31: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1992:41: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:1992:54: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:2007:33: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:2014:34: warning: dereference of noderef expression
      drivers/media/dvb-core/dvb_frontend.c:2014:52: warning: dereference of noderef expression
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      71d1b2be
    • Mauro Carvalho Chehab's avatar
      [media] as102_drv.h: added a missing newline · 289297b9
      Mauro Carvalho Chehab authored
      drivers/media/usb/as102/as102_drv.h:83:6: warning: no newline at end of file
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      289297b9
    • Mauro Carvalho Chehab's avatar
      [media] v4l2-dv-timings: fix a sparse warning · 5c2cacc1
      Mauro Carvalho Chehab authored
      This is detected with:
      	gcc-4.8.3-7.fc20.x86_64
      	sparse-0.5.0-3.fc20.x86_64
      
      drivers/media/v4l2-core/v4l2-dv-timings.c:34:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:35:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:36:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:37:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:38:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:39:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:40:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:41:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:42:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:43:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:44:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:45:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:46:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:47:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:48:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:49:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:50:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:51:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:52:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:53:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:54:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:55:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:56:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:57:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:58:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:59:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:60:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:61:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:62:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:63:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:64:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:65:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:66:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:67:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:68:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:69:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:70:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:71:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:72:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:73:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:74:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:75:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:76:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:77:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:78:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:79:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:80:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:81:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:82:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:83:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:84:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:85:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:86:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:87:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:88:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:89:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:90:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:91:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:92:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:93:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:94:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:95:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:96:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:97:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:98:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:99:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:100:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:101:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:102:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:103:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:104:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:105:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:106:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:107:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:108:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:109:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:110:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:111:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:112:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:113:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:114:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:115:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:116:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:117:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:118:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:119:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:120:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:121:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:122:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:123:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:124:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:125:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:126:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:127:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:128:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:129:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:130:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:131:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:132:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:133:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:134:9: error: unknown field name in initializer
      drivers/media/v4l2-core/v4l2-dv-timings.c:135:9: error: too many errors
      drivers/media/usb/hdpvr/hdpvr-video.c:42:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:43:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:44:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:45:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:46:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:47:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:48:9: error: unknown field name in initializer
      drivers/media/usb/hdpvr/hdpvr-video.c:49:9: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field name in initializer
      drivers/media/platform/s5p-tv/hdmi_drv.c:493:18: error: unknown field name in initializer
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      5c2cacc1
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc_opr_v6: remove address space removal warnings · dc11ef78
      Mauro Carvalho Chehab authored
      Smatch still has 3 warnings for s5p_mfc_opr_v6:
      
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2028:18: warning: cast removes address space of expression
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2034:18: warning: cast removes address space of expression
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:2040:18: warning: cast removes address space of expression
      
      Remove them.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      dc11ef78
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc_opr_v6: fix wrong type for registers · b5e4d330
      Mauro Carvalho Chehab authored
      As reported by smatch, there are several warnings related to bad
      types for registers. Worse than that, there are too many errors,
      preventing smatch to warn about real issues. So, fix them:
      
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:414:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:414:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:414:35:    got void *const d_stream_data_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:415:34: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:415:34:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:415:34:    got void *const d_cpb_buffer_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:416:39: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:416:39:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:416:39:    got void *const d_cpb_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:417:40: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:417:40:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:417:40:    got void *const d_cpb_buffer_offset
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:441:46: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:441:46:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:441:46:    got void *const d_num_dpb
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:442:40: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:442:40:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:442:40:    got void *const d_first_plane_dpb_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:443:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:443:42:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:443:42:    got void *const d_second_plane_dpb_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:445:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:445:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:445:35:    got void *const d_scratch_buffer_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:446:47: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:446:47:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:446:47:    got void *const d_scratch_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:450:33: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:450:33:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:450:33:    got void *const d_first_plane_dpb_stride_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:452:33: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:452:33:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:452:33:    got void *const d_second_plane_dpb_stride_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:460:46: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:460:46:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:460:46:    got void *const d_mv_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:461:47: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:461:47:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:461:47:    got void *const d_num_mv
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:475:61: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:475:61:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:475:61:    got void *
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:479:62: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:479:62:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:479:62:    got void *
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:492:65: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:492:65:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:492:65:    got void *
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:505:38: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:505:38:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:505:38:    got void *const instance_id
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:520:30: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:520:30:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:520:30:    got void *const e_stream_buffer_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:521:30: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:521:30:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:521:30:    got void *const e_stream_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:535:32: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:535:32:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:535:32:    got void *const e_source_first_plane_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:536:32: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:536:32:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:536:32:    got void *const e_source_second_plane_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:549:33: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:549:33:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:549:33:    got void *const e_encoded_source_first_plane_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:550:33: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:550:33:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:550:33:    got void *const e_encoded_source_second_plane_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:552:42: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:552:42:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:552:42:    got void *const e_recon_luma_dpb_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:553:42: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:553:42:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:553:42:    got void *const e_recon_chroma_dpb_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:575:56: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:575:56:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:575:56:    got void *
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:577:58: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:577:58:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:577:58:    got void *
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:579:57: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:579:57:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:579:57:    got void *
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:585:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:585:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:585:35:    got void *const e_scratch_buffer_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:586:47: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:586:47:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:586:47:    got void *const e_scratch_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:590:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:590:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:590:35:    got void *const e_tmv_buffer0
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:592:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:592:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:592:35:    got void *const e_tmv_buffer1
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:603:38: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:603:38:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:603:38:    got void *const instance_id
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:619:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:619:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:619:41:    got void *const e_mslice_mode
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:621:52: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:621:52:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:621:52:    got void *const e_mslice_size_mb
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:624:54: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:624:54:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:624:54:    got void *const e_mslice_size_bits
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:626:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:626:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:626:37:    got void *const e_mslice_size_mb
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:627:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:627:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:627:37:    got void *const e_mslice_size_bits
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:643:40: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:643:40:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:643:40:    got void *const e_frame_width
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:645:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:645:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:645:41:    got void *const e_frame_height
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:648:40: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:648:40:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:648:40:    got void *const e_cropped_frame_width
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:650:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:650:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:650:41:    got void *const e_cropped_frame_height
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:652:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:652:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:652:29:    got void *const e_frame_crop_offset
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:657:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:657:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:657:29:    got void *const e_gop_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:665:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:665:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:665:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:669:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:669:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:669:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:673:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:673:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:673:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:679:45: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:679:45:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:679:45:    got void *const e_ir_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:680:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:680:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:680:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:685:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:685:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:685:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:688:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:688:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:688:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:690:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:690:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:690:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:695:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:695:37:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:695:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:697:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:697:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:697:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:699:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:699:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:699:37:    got void *const pixel_format
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:702:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:702:37:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:702:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:704:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:704:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:704:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:706:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:706:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:706:37:    got void *const pixel_format
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:709:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:709:37:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:709:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:711:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:711:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:711:37:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:713:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:713:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:713:37:    got void *const pixel_format
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:718:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:718:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:718:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:720:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:720:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:720:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:723:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:723:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:723:29:    got void *const e_padding_ctrl
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:734:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:734:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:734:37:    got void *const e_padding_ctrl
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:741:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:741:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:741:29:    got void *const e_rc_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:746:33: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:746:33:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:746:33:    got void *const e_rc_bit_rate
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:748:35: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:748:35:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:748:35:    got void *const e_rc_bit_rate
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:753:43: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:753:43:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:753:43:    got void *const e_rc_mode
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:755:43: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:755:43:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:755:43:    got void *const e_rc_mode
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:759:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:759:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:759:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:766:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:766:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:766:29:    got void *const e_enc_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:769:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:769:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:769:29:    got void *const e_rc_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:771:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:771:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:771:29:    got void *const e_rc_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:775:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:775:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:775:29:    got void *const e_mv_hor_range
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:778:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:778:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:778:29:    got void *const e_mv_ver_range
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:780:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:780:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:780:29:    got void *const e_frame_insertion
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:781:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:781:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:781:29:    got void *const e_roi_buffer_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:782:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:782:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:782:29:    got void *const e_param_change
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:783:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:783:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:783:29:    got void *const e_rc_roi_ctrl
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:784:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:784:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:784:29:    got void *const e_picture_tag
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:786:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:786:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:786:29:    got void *const e_bit_count_enable
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:787:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:787:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:787:29:    got void *const e_max_bit_count
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:788:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:788:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:788:29:    got void *const e_min_bit_count
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:790:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:790:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:790:29:    got void *const e_metadata_buffer_addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:791:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:791:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:791:29:    got void *const e_metadata_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:812:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:812:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:812:29:    got void *const e_gop_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:815:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:815:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:815:29:    got void *const e_gop_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:823:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:823:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:823:29:    got void *const e_picture_profile
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:826:29: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:826:29:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:826:29:    got void *const e_rc_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:830:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:830:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:830:29:    got void *const e_rc_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:835:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:835:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:835:29:    got void *const e_rc_config
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:843:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:843:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:843:29:    got void *const e_rc_qp_bound
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:846:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:846:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:846:29:    got void *const e_fixed_picture_qp
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:852:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:852:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:852:37:    got void *const e_fixed_picture_qp
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:860:37: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:860:37:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:860:37:    got void *const e_rc_frame_rate
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:867:41: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:867:41:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:867:41:    got void *const e_vbv_buffer_size
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:870:54: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:870:54:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:870:54:    got void *const e_vbv_init_delay
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:876:29: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:876:29:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:876:29:    got void *const e_h264_options
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:881:41: warning: too many warnings
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      b5e4d330
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc_opr_v5: fix smatch warnings · d7fa7b0e
      Mauro Carvalho Chehab authored
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:266:23: warning: incorrect type in argument 2 (different modifiers)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:266:23:    expected void volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:266:23:    got void const volatile [noderef] <asn:2>*<noident>
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:274:36: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:274:36:    expected void const volatile [noderef] <asn:2>*addr
      drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:274:36:    got void *
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      d7fa7b0e
    • Mauro Carvalho Chehab's avatar
      [media] s5p_mfc: use static for some structs · ca5ea0c5
      Mauro Carvalho Chehab authored
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1334:28: warning: symbol 'mfc_buf_size_v5' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1341:25: warning: symbol 'buf_size_v5' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1347:26: warning: symbol 'mfc_buf_align_v5' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1360:28: warning: symbol 'mfc_buf_size_v6' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1368:25: warning: symbol 'buf_size_v6' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1374:26: warning: symbol 'mfc_buf_align_v6' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1392:28: warning: symbol 'mfc_buf_size_v7' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1400:25: warning: symbol 'buf_size_v7' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1406:26: warning: symbol 'mfc_buf_align_v7' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1419:28: warning: symbol 'mfc_buf_size_v8' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1427:25: warning: symbol 'buf_size_v8' was not declared. Should it be static?
      drivers/media/platform/s5p-mfc/s5p_mfc.c:1433:26: warning: symbol 'mfc_buf_align_v8' was not declared. Should it be static?
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      ca5ea0c5
    • Ulf Hansson's avatar
      [media] coda: Improve runtime PM support · c5d28e29
      Ulf Hansson authored
      For several reasons it's good practice to leave devices in runtime PM
      active state while those have been probed.
      
      In this cases we also want to prevent the device from going inactive,
      until the firmware has been completely installed, especially when using
      a PM domain.
      Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
      Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      c5d28e29
    • Sjoerd Simons's avatar
      [media] s5p-mfc: Use decode status instead of display status on MFCv5 · 7c672812
      Sjoerd Simons authored
      Commit 90c0ae50 changed how the frame_type of a decoded frame
      gets determined, by switching from the get_dec_frame_type to
      get_disp_frame_type operation. Unfortunately it seems that on MFC v5 the
      result of get_disp_frame_type is always 0 (no display) when decoding
      (tested with H264), resulting in no frame ever being output from the
      decoder.
      
      This patch reverts MFC v5 to the previous behaviour while keeping the
      new behaviour for v6 and up.
      Signed-off-by: default avatarSjoerd Simons <sjoerd.simons@collabora.co.uk>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      7c672812
    • ayaka's avatar
      [media] s5p-mfc: fix enum_fmt for s5p-mfc · 7e8fe13d
      ayaka authored
      As the s5p-mfc is a driver which use  multiplanar api, so the
      vidioc_enum_fmt_vid serial of ioctl should only for
      multiplanar, non-multiplanar shouldn't be implemented at all.
      Signed-off-by: default avatarayaka <ayaka@soulik.info>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      7e8fe13d
    • Kamil Debski's avatar
      [media] s5p-mfc: Fix sparse errors in the MFC driver · e2c3be2a
      Kamil Debski authored
      The following error: "error: incompatible types in conditional expression
      (different base types)" was reported multiple times for the s5p-mfc
      driver. This error was caused by two macro definitions - s5p_mfc_hw_call
      (in s5p_mfc_common.h) and WRITEL (in s5p_mfc_opr_v6.c).
      
      In the former case the macro assumed that all ops return a value, but some
      ops return void. The solution to this problem was the addition of a
      s5p_mfc_hw_call_void macro.
      
      In the latter case the macro used the ?: construction to check whether
      the address is non zero. This is not necessary after the driver left the
      development and debugging cycle, so the READL and WRITEL macros were
      removed.
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      e2c3be2a
    • Zhaowei Yuan's avatar
      [media] s5p_mfc: unify variable naming style · 9aee8b80
      Zhaowei Yuan authored
      Variable frame_size represents the size of plane luminance
      here, not just frame size, its naming style should be unified
      as frame_size_ch and frame_size_mv.
      Signed-off-by: default avatarZhaowei Yuan <zhaowei.yuan@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      9aee8b80
    • Zhaowei Yuan's avatar
      [media] s5p_mfc: correct the loop condition · 00684dab
      Zhaowei Yuan authored
      It should take ctx->dst_fmt->num_planes as
      the loop condition for CAPTURE.
      Signed-off-by: default avatarZhaowei Yuan <zhaowei.yuan@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      00684dab
    • Olli Salonen's avatar
      [media] si2168: add FE_CAN_MULTISTREAM into caps · 327eeb3a
      Olli Salonen authored
      PLP selection was implemented for Si2168 last month (patchwork 25387). However, FE_CAN_MULTISTREAM was not added to dvb_frontend_ops of si2168. This patch adds FE_CAN_MULTISTREAM, which indicates that multiple PLP are supported.
      Signed-off-by: default avatarOlli Salonen <olli.salonen@iki.fi>
      Acked-by: default avatarAntti Palosaari <crope@iki.fi>
      Reviewed-by: default avatarAntti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      327eeb3a
    • Kazunori Kobayashi's avatar
      [media] soc_camera: Support VIDIOC_EXPBUF ioctl · c710f591
      Kazunori Kobayashi authored
      This patch allows for exporting a dmabuf descriptor from soc_camera drivers.
      Signed-off-by: default avatarKazunori Kobayashi <kkobayas@igel.co.jp>
      Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      c710f591
    • Dan Carpenter's avatar
      [media] mx2-camera: potential negative underflow bug · 5d6de11c
      Dan Carpenter authored
      My static checker complains:
      
      	drivers/media/platform/soc_camera/mx2_camera.c:1070
      	mx2_emmaprp_resize() warn: no lower bound on 'num'
      
      The heuristic is that it's looking for values which the user can
      influence and we put an upper bound on them but we (perhaps
      accidentally) allow negative numbers.
      
      I am not very familiar with this code but I have looked at it and think
      there might be a bug.  Making the variable unsigned seems like a safe
      option either way and this silences the static checker warning.
      
      The call tree is:
        -> subdev_do_ioctl()
           -> mx2_camera_set_fmt()
              -> mx2_emmaprp_resize()
      The check:
      	if (num > RESIZE_NUM_MAX)
      can underflow and then we use "num" on the else path.
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      5d6de11c
    • Sergei Shtylyov's avatar
      [media] rcar_vin: fix error message in rcar_vin_get_formats() · 197a47f2
      Sergei Shtylyov authored
      The dev_err() call is supposed to output <width>x<height> in decimal but one of
      the format specifiers is "%x" instead of "%u" (most probably due  to a typo).
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      197a47f2
    • Mauro Carvalho Chehab's avatar
      [media] tc90522: fix compilation on 32 bits · 2ea12442
      Mauro Carvalho Chehab authored
         drivers/built-in.o: In function `tc90522t_get_frontend':
      >> tc90522.c:(.text+0x260b64c): undefined reference to `__divdi3'
      >> tc90522.c:(.text+0x260b685): undefined reference to `__divdi3'
      >> tc90522.c:(.text+0x260b6bb): undefined reference to `__divdi3'
      >> tc90522.c:(.text+0x260b713): undefined reference to `__divdi3'
         drivers/built-in.o:tc90522.c:(.text+0x260bb64): more undefined references to `__divdi3' follow
      Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      2ea12442