Commits · 81055e584f9d743cb13dc7944923d817c20f089d · nexedi / linux

06 May, 2014 40 commits

optimize copy_page_{to,from}_iter() · 81055e58

Al Viro authored Apr 04, 2014

if we'd ended up in the end of a segment, jump to the
beginning of the next one (iov_offset = 0, iov++),
rather than having the next primitive deal with that.

Ought to be folded back...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

81055e58

bury generic_file_aio_{read,write} · 6abd2322
Al Viro authored Apr 04, 2014
```
no callers left
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
6abd2322

lustre: get rid of messing with iovecs · b42b15fd

Al Viro authored Apr 04, 2014

* switch to ->read_iter/->write_iter
* keep a pointer to iov_iter instead of iov/nr_segs
* do not modify iovecs; use iov_iter_truncate()/iov_iter_advance() and
a new primitive - iov_iter_reexpand() (expand previously truncated
iterator) istead.
* (racy) check for lustre VMAs intersecting with iovecs kept for now as
for_each_iov() loop.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

b42b15fd

ceph: switch to ->write_iter() · 4908b822
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
4908b822
ceph_sync_direct_write: stop poking into iov_iter guts · 64c31311
Al Viro authored Apr 03, 2014
```
all needed primitives are there...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
64c31311
ceph_sync_read: stop poking into iov_iter guts · 2b777c9d
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
2b777c9d

new helper: copy_page_from_iter() · f0d1bec9

Al Viro authored Apr 03, 2014

parallel to copy_page_to_iter().  pipe_write() switched to it (and became
->write_iter()).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

f0d1bec9

fuse: switch to ->write_iter() · 84c3d55c
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
84c3d55c
btrfs: switch to ->write_iter() · b30ac0fc
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
b30ac0fc
ocfs2: switch to ->write_iter() · 3ef045c3
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
3ef045c3
xfs: switch to ->write_iter() · bf97f3bc
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
bf97f3bc
afs: switch to ->write_iter() · 50b5551d
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
50b5551d
gfs2: switch to ->write_iter() · da56e45b
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
da56e45b
nfs: switch to ->write_iter() · edaf4369
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
edaf4369
ubifs: switch to ->write_iter() · f5674c31
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
f5674c31

bury __generic_file_aio_write() · a8f3550c

Al Viro authored Apr 03, 2014

all users converted to __generic_file_write_iter() now
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

a8f3550c

cifs: switch to ->write_iter() · 3dae8750
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
3dae8750
udf: switch to ->write_iter() · d4637bc1
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
d4637bc1

convert ext4 to ->write_iter() · 9b884164

Al Viro authored Apr 17, 2014

unfortunately, Ted's changes to ext4_file_write() are *still* an
incomplete fix - playing with rlimits can let you smuggle an
unaligned request past the checks.  So there almost certainly
will be more merge PITA around that place...

[fix from Peter Ujfalusi <peter.ujfalusi@ti.com> folded]
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

9b884164

Merge ext4 changes in ext4_file_write() into for-next · a8324754
Al Viro authored May 06, 2014
```
From ext4.git#dev, needed for switch of ext4 to ->write_iter() ;-/
```
a8324754
blkdev_aio_write() - turn into blkdev_write_iter() · 1456c0a8
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
1456c0a8
write_iter variants of {__,}generic_file_aio_write() · 8174202b
Al Viro authored Apr 03, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
8174202b
ceph: switch to ->read_iter() · 3644424d
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
3644424d
nfs: switch to ->read_iter() · 3aa2d199
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
3aa2d199
fs/block_dev.c: switch to ->read_iter() · a886038b
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
a886038b
shmem: switch to ->read_iter() · 2ba5bbed
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
2ba5bbed
pipe: switch to ->read_iter() · fb9096a3
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
fb9096a3
cifs: switch to ->read_iter() · e6a7bcb4
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
e6a7bcb4
fuse_file_aio_read(): convert to ->read_iter() · 37c20f16
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
37c20f16

ocfs2: switch to ->read_iter() · 3cd9ad5a

Al Viro authored Apr 02, 2014

tracepoints are evil, exhibit #6969...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

3cd9ad5a

ecryptfs: switch to ->read_iter() · 02797829
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
02797829
xfs: switch to ->read_iter() · b4f5d2c6
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
b4f5d2c6
switch simple generic_file_aio_read() users to ->read_iter() · aad4f8bb
Al Viro authored Apr 02, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
aad4f8bb

new methods: ->read_iter() and ->write_iter() · 293bc982

Al Viro authored Feb 11, 2014

Beginning to introduce those.  Just the callers for now, and it's
clumsier than it'll eventually become; once we finish converting
aio_read and aio_write instances, the things will get nicer.

For now, these guys are in parallel to ->aio_read() and ->aio_write();
they take iocb and iov_iter, with everything in iov_iter already
validated.  File offset is passed in iocb->ki_pos, iov/nr_segs -
in iov_iter.

Main concerns in that series are stack footprint and ability to
split the damn thing cleanly.

[fix from Peter Ujfalusi <peter.ujfalusi@ti.com> folded]
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

293bc982

replace checking for ->read/->aio_read presence with check in ->f_mode · 7f7f25e8

Al Viro authored Feb 11, 2014

Since we are about to introduce new methods (read_iter/write_iter), the
tests in a bunch of places would have to grow inconveniently. Check
once (at open() time) and store results in ->f_mode as FMODE_CAN_READ
and FMODE_CAN_WRITE resp. It might end up being a temporary measure -
once everything switches from ->aio_{read,write} to ->{read,write}_iter
it might make sense to return to open-coded checks. We'll see...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

7f7f25e8

xfs: trim the argument lists of xfs_file_{dio,buffered}_aio_write() · b3188919

Al Viro authored Apr 02, 2014

pos is redundant (it's iocb->ki_pos), and iov/nr_segs/count are taken
care of by lifting iov_iter into the caller.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

b3188919

blkdev_aio_read(): switch to generic_file_read_iter(), get rid of iov_shorten() · 37938463
Al Viro authored Mar 22, 2014
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
37938463

iov_iter_truncate() · 0c949334

Al Viro authored Mar 22, 2014

Now It Can Be Done(tm) - we don't need to do iov_shorten() in
generic_file_direct_write() anymore, now that all ->direct_IO()
instances are converted to proper iov_iter methods and honour
iter->count and iter->iov_offset properly.

Get rid of count/ocount arguments of generic_file_direct_write(),
while we are at it.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

0c949334

btrfs: switch check_direct_IO() to iov_iter · 28060d5d

Al Viro authored Mar 22, 2014

... and don't open-code iov_iter_alignment() there
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

28060d5d

new helper: iov_iter_get_pages_alloc() · 91f79c43

Al Viro authored Mar 21, 2014

same as iov_iter_get_pages(), except that pages array is allocated
(kmalloc if possible, vmalloc if that fails) and left for caller to
free.  Lustre and NFS ->direct_IO() switched to it.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

91f79c43