- 19 Nov, 2016 4 commits
-
-
Linus Walleij authored
We have #defines for all the individual sensor registers and value/mask pairs #defined at the top of the file and used at exactly one spot. This is usually good if the #defines give a meaning to the opaque magic numbers. However in this case, the semantic meaning is inherent in the name of the C99-addressable fields, and that means duplication of information, and only makes the code hard to maintain since you every time have to add a new #define AND update the site where it is to be used. Get rid of the #defines and just open code the values into the appropriate struct elements. Make sure to explicitly address the .hz and .value fields in the st_sensor_odr_avl struct so that the meaning of all values is clear. This patch is purely syntactic should have no semantic effect. Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> Signed-off-by:
Linus Walleij <linus.walleij@linaro.org> Acked-by:
Lorenzo Bianconi <lorenzo.bianconi@st.com> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Fabrice Gasnier authored
This patch adds support for STMicroelectronics STM32 MCU's analog to digital converter. Signed-off-by:
Fabrice Gasnier <fabrice.gasnier@st.com> Signed-off-by:
-
Fabrice Gasnier authored
Add core driver for STMicroelectronics STM32 ADC (Analog to Digital Converter). STM32 ADC can be composed of up to 3 ADCs with shared resources like clock prescaler, common interrupt line and analog reference voltage. This core driver basically manages shared resources. Signed-off-by:
-
Fabrice Gasnier authored
This patch adds documentation of device tree bindings for the STM32 ADC. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
- 18 Nov, 2016 19 commits
-
-
James Simmons authored
Cleanup some of the checkpatch over 80 character lines reported. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
James Simmons authored
Some of the defines for lnet selftest can use the BIT macros. Signed-off-by:
-
James Simmons authored
The __[u|s]* types are for UAPI headers or user space. They shouldn't be used in core kernel code. Signed-off-by:
-
James Simmons authored
Checkpatch recommended that we use pr_*() instead of printk directly. Signed-off-by:
-
James Simmons authored
The envp char array can be made static constant. Signed-off-by:
-
James Simmons authored
Fix typo for correct spelling. Signed-off-by:
-
James Simmons authored
Remove white space present for variable declarations or initialization. Cleanup structs was strange alignments due to white spacing. Signed-off-by:
-
James Simmons authored
Testing == 0 is not kernel style so remove this type of testing from libcfs. Signed-off-by:
-
James Simmons authored
Testing != 0 is not kernel style so remove this type of testing from libcfs. Signed-off-by:
-
James Simmons authored
Checkpatch for some reason doesn't like the way libcfs_str2net_internal. Lets just replace it with nf being set to NULL instead Signed-off-by:
-
James Simmons authored
While checkpatch reported an alignment issue its just ugly to fill in a data structure being passed to a function. Instead fill in a lnet_md_t on the stack and pass that to LNetMDBind. Signed-off-by:
-
James Simmons authored
Add in missing blank line in lnet_copy_iov2iter() after variable declarations. Signed-off-by:
-
James Simmons authored
Remove unused lib_me_dump. Signed-off-by:
-
James Simmons authored
Fix misspelling of destroy in LNet core. Signed-off-by:
-
James Simmons authored
Make alignment match open parenthesis for parameters to wait_event_interruptible_exclusive() call. Signed-off-by:
-
James Simmons authored
Remove != NULL which is not needed to test key existence. Signed-off-by:
-
James Simmons authored
Change the static const array libcfs_debug_subsystems to use static const char const * as pointed out by checkpatch. Signed-off-by:
-
James Simmons authored
This patch resolves the checkpatch error: Block comments use a trailing */ on a separate line for the LNet/libcfs layer Signed-off-by:
-
James Simmons authored
Turn all bare unsigned to unsigned int that were detected by checkpatch in the LNet/libcfs layer. Signed-off-by:
-
- 17 Nov, 2016 14 commits
-
-
Walt Feasel authored
Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by:
Walt Feasel <waltfeasel@gmail.com> Signed-off-by:
-
Walt Feasel authored
Make suggested checkpatch modification for CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by:
-
Walt Feasel authored
Make suggested checkpatch modification for CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: -
Walt Feasel authored
Make suggested checkpatch modification for CHECK: spaces preferred around that '-,&' Signed-off-by:
-
Walt Feasel authored
Make suggested checkpatch modification for CHECK: Logical continuations should be on the previous line Signed-off-by:
-
Walt Feasel authored
Make suggested checkpatch modification for CHECK: No space is necessary after a cast Signed-off-by:
-
Walt Feasel authored
Make comment style modifications. Signed-off-by:
-
Yamanappagouda Patil authored
Fixed checkpatch warning "Statements should start on a tabstop" in rtl8712 module. Signed-off-by:
Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by:
-
Walt Feasel authored
Make various comment style modifications. Signed-off-by:
-
Walt Feasel authored
Make suggested checkpatch modification for: CHECK: Alignment should match open parenthesis. Signed-off-by:
-
Walt Feasel authored
Make suggested checkpatch modification for: CHECK: Logical continuations should be on the previous line. Signed-off-by:
-
Niu Yawei authored
The imp_known_replied_xid should be updated when try to resend an already replied replay request, because the xid of this replay request could be less than current imp_known_replied_xid. Signed-off-by:
Niu Yawei <yawei.niu@intel.com> Reviewed-on: http://review.whamcloud.com/22776 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8645Reviewed-by:
Alex Zhuravlev <alexey.zhuravlev@intel.com> Reviewed-by:
Fan Yong <fan.yong@intel.com> Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Niu Yawei authored
The request xid was used to make sure the ost object timestamps being updated by the out of order setattr/punch/write requests properly. However, this mechanism is broken by the multiple rcvd slot feature, where we deferred the xid assignment from request packing to request sending. This patch moved back the xid assignment to request packing, and the manner of finding lowest unreplied xid is changed from scan sending & delay list to scan a unreplied requests list. This patch also skipped packing the known replied XID in connect and disconnect request, so that we can make sure the known replied XID is increased only on both server & client side. Signed-off-by:
Gregoire Pichon <gregoire.pichon@bull.net> Reviewed-by:
-
Greg Kroah-Hartman authored
We need DMA for this, otherwise the build breaks, so fix this up. Reported-by:
kbuild test robot <fengguang.wu@intel.com> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Lee Jones <lee@kernel.org> Cc: Eric Anholt <eric@anholt.net> Signed-off-by:
-
- 16 Nov, 2016 3 commits
-
-
Arnd Bergmann authored
The raspberrypi-firmware driver may be built as a loadable module, which causes a link-time failure if the vc04_services driver is built-in during compile-testing: drivers/staging/vc04_services/vchiq.o: In function `vchiq_probe': vchiq_connected.c:(.text.vchiq_probe+0x2c): undefined reference to `rpi_firmware_get' drivers/staging/vc04_services/vchiq.o: In function `vchiq_platform_init': vchiq_connected.c:(.text.vchiq_platform_init+0x1f0): undefined reference to `rpi_firmware_property' This extends the dependency list to ensure the firmware is either reachable, or completely disabled in case of compile-testing. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Arnd Bergmann authored
The driver tries to redefine mutex_lock_interruptible as an open-coded mutex_lock_killable, but that definition clashes with the normal mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC is set: staging/vc04_services/interface/vchiq_arm/vchiq_killable.h:67:0: error: "mutex_lock_interruptible" redefined [-Werror] #define mutex_lock_interruptible mutex_lock_interruptible_killable include/linux/mutex.h:161:0: note: this is the location of the previous definition This simply removes the private implementation and uses the normal mutex_lock_killable directly. We could do the same for the down_interruptible_killable here, but it's better to just remove the semaphores entirely from the driver, which also takes care of that. Signed-off-by:
-
Arnd Bergmann authored
With gcc-7, I got a new warning for this driver: wilc1000/linux_wlan.c: In function 'wilc_netdev_cleanup': wilc1000/linux_wlan.c:1224:15: error: 'vif[1]' may be used uninitialized in this function [-Werror=maybe-uninitialized] wilc1000/linux_wlan.c:1224:15: error: 'vif[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] A closer look at the function reveals that it's more complex than it needs to be, given that based on how the device is created we always get netdev_priv(vif->ndev) == vif Based on this assumption, I found a few other places in the same file that can be simplified. That code appears to be a relic from times when the assumption above was not valid. Signed-off-by:
-
