1. 17 Oct, 2020 2 commits
  2. 13 Oct, 2020 1 commit
    • Kai Vehmanen's avatar
      ALSA: hda/hdmi: fix incorrect locking in hdmi_pcm_close · ce1558c2
      Kai Vehmanen authored
      A race exists between closing a PCM and update of ELD data. In
      hdmi_pcm_close(), hinfo->nid value is modified without taking
      spec->pcm_lock. If this happens concurrently while processing an ELD
      update in hdmi_pcm_setup_pin(), converter assignment may be done
      incorrectly.
      
      This bug was found by hitting a WARN_ON in snd_hda_spdif_ctls_assign()
      in a HDMI receiver connection stress test:
      
      [2739.684569] WARNING: CPU: 5 PID: 2090 at sound/pci/hda/patch_hdmi.c:1898 check_non_pcm_per_cvt+0x41/0x50 [snd_hda_codec_hdmi]
      ...
      [2739.684707] Call Trace:
      [2739.684720]  update_eld+0x121/0x5a0 [snd_hda_codec_hdmi]
      [2739.684736]  hdmi_present_sense+0x21e/0x3b0 [snd_hda_codec_hdmi]
      [2739.684750]  check_presence_and_report+0x81/0xd0 [snd_hda_codec_hdmi]
      [2739.684842]  intel_audio_codec_enable+0x122/0x190 [i915]
      
      Fixes: 42b29870 ("ALSA: hda - hdmi playback without monitor in dynamic pcm bind mode")
      Signed-off-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20201013152628.920764-1-kai.vehmanen@linux.intel.comSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      ce1558c2
  3. 12 Oct, 2020 5 commits
  4. 09 Oct, 2020 5 commits
  5. 08 Oct, 2020 18 commits
  6. 07 Oct, 2020 3 commits
  7. 06 Oct, 2020 6 commits
    • Randy Dunlap's avatar
      ALSA: usb-audio: endpoint.c: fix repeated word 'there' · 0569b3d8
      Randy Dunlap authored
      Drop the duplicated word "there".
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: Jaroslav Kysela <perex@perex.cz>
      Cc: Takashi Iwai <tiwai@suse.com>
      Cc: alsa-devel@alsa-project.org
      Link: https://lore.kernel.org/r/20201005191244.23902-1-rdunlap@infradead.orgSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      0569b3d8
    • Randy Dunlap's avatar
      ALSA: portman2x4: fix repeated word 'if' · 86b9c4cd
      Randy Dunlap authored
      Correct duplicated word "if" to "if it".
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: Jaroslav Kysela <perex@perex.cz>
      Cc: Takashi Iwai <tiwai@suse.com>
      Cc: alsa-devel@alsa-project.org
      Link: https://lore.kernel.org/r/20201005191223.21514-1-rdunlap@infradead.orgSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      86b9c4cd
    • Mark Brown's avatar
      Merge tag 'v5.9-rc5' into asoc-5.10 · fd6b519a
      Mark Brown authored
      Linux 5.9-rc5
      fd6b519a
    • Mark Brown's avatar
      Merge series "ASoC: Intel: Remove obsolete solutions and components" from... · 43499134
      Mark Brown authored
      Merge series "ASoC: Intel: Remove obsolete solutions and components" from Cezary Rojewski <cezary.rojewski@intel.com>:
      
      Follow up to catpt series as mentioned in:
      [PATCH v10 00/14] ASoC: Intel: Catpt - Lynx and Wildcat point
      https://www.spinics.net/lists/alsa-devel/msg116440.html
      
      As catpt is a direct replacement to sound/soc/intel/haswell, it leaves a
      lot of code redudant. The second legacy solution - baytrail - is
      deprecated for a long time by sound/soc/intel/atom with SOF flavor
      available too.
      
      This series addresses the redudancy and removes obsolete code. Along
      with the legacy solutions, all orphaned components are removed too.
      
      As a consequence, further cleanups are unlocked: sound/soc/intel/skylake
      becomes the sole user of processing code found in
      sound/soc/intel/common. Those are not part of this series.
      
      Changes in v2:
      - just a rebase so patch 04/13 applies cleanly
      - left the tags as no actual changes done in between
      
      Cezary Rojewski (13):
        ASoC: Intel: Remove haswell solution
        ASoC: Intel: Remove max98090 support for baytrail solution
        ASoC: Intel: Remove rt5640 support for baytrail solution
        ASoC: Intel: Remove baytrail solution
        ASoC: Intel: Remove SST ACPI component
        ASoC: Intel: Remove SST firmware components
        ASoC: Intel: Skylake: Unassign ram_read and read_write ops
        ASoC: Intel: Remove unused DSP operations
        ASoC: Intel: Remove unused DSP interface fields
        ASoC: Intel: Remove SST-legacy specific constants
        ASoC: Intel: Make atom components independent of sst-dsp
        ASoC: Intel: Remove sst_pdata structure
        ASoC: Intel: Remove sst_dsp_get_thread_context
      
       include/sound/soc-acpi-intel-match.h          |    1 -
       include/trace/events/hswadsp.h                |  385 ---
       sound/soc/intel/Kconfig                       |   26 -
       sound/soc/intel/Makefile                      |    1 -
       sound/soc/intel/atom/sst/sst.c                |    1 -
       sound/soc/intel/atom/sst/sst.h                |    7 +
       sound/soc/intel/atom/sst/sst_acpi.c           |    1 -
       sound/soc/intel/atom/sst/sst_drv_interface.c  |    3 -
       sound/soc/intel/atom/sst/sst_ipc.c            |    1 -
       sound/soc/intel/atom/sst/sst_loader.c         |    1 -
       sound/soc/intel/atom/sst/sst_pvt.c            |    1 -
       sound/soc/intel/atom/sst/sst_stream.c         |    1 -
       sound/soc/intel/baytrail/Makefile             |    5 -
       sound/soc/intel/baytrail/sst-baytrail-dsp.c   |  358 ---
       sound/soc/intel/baytrail/sst-baytrail-ipc.c   |  772 ------
       sound/soc/intel/baytrail/sst-baytrail-ipc.h   |   64 -
       sound/soc/intel/baytrail/sst-baytrail-pcm.c   |  459 ----
       sound/soc/intel/boards/Kconfig                |   25 -
       sound/soc/intel/boards/Makefile               |    4 -
       sound/soc/intel/boards/byt-max98090.c         |  182 --
       sound/soc/intel/boards/byt-rt5640.c           |  224 --
       sound/soc/intel/boards/bytcht_es8316.c        |    1 -
       sound/soc/intel/boards/bytcr_rt5640.c         |    1 -
       sound/soc/intel/common/Makefile               |    4 -
       .../intel/common/soc-acpi-intel-byt-match.c   |   15 -
       sound/soc/intel/common/sst-acpi.c             |  236 --
       sound/soc/intel/common/sst-dsp-priv.h         |  284 +--
       sound/soc/intel/common/sst-dsp.c              |  162 --
       sound/soc/intel/common/sst-dsp.h              |  222 --
       sound/soc/intel/common/sst-firmware.c         | 1273 ----------
       sound/soc/intel/common/sst-ipc.c              |   27 -
       sound/soc/intel/common/sst-ipc.h              |    3 -
       sound/soc/intel/haswell/Makefile              |    5 -
       sound/soc/intel/haswell/sst-haswell-dsp.c     |  705 ------
       sound/soc/intel/haswell/sst-haswell-ipc.c     | 2222 -----------------
       sound/soc/intel/haswell/sst-haswell-ipc.h     |  527 ----
       sound/soc/intel/haswell/sst-haswell-pcm.c     | 1369 ----------
       sound/soc/intel/skylake/bxt-sst.c             |    2 -
       sound/soc/intel/skylake/cnl-sst.c             |    4 +-
       sound/soc/intel/skylake/skl-sst-dsp.c         |    2 +-
       sound/soc/intel/skylake/skl-sst-ipc.c         |    2 +-
       sound/soc/intel/skylake/skl-sst.c             |    2 -
       42 files changed, 11 insertions(+), 9579 deletions(-)
       delete mode 100644 include/trace/events/hswadsp.h
       delete mode 100644 sound/soc/intel/baytrail/Makefile
       delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-dsp.c
       delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-ipc.c
       delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-ipc.h
       delete mode 100644 sound/soc/intel/baytrail/sst-baytrail-pcm.c
       delete mode 100644 sound/soc/intel/boards/byt-max98090.c
       delete mode 100644 sound/soc/intel/boards/byt-rt5640.c
       delete mode 100644 sound/soc/intel/common/sst-acpi.c
       delete mode 100644 sound/soc/intel/common/sst-firmware.c
       delete mode 100644 sound/soc/intel/haswell/Makefile
       delete mode 100644 sound/soc/intel/haswell/sst-haswell-dsp.c
       delete mode 100644 sound/soc/intel/haswell/sst-haswell-ipc.c
       delete mode 100644 sound/soc/intel/haswell/sst-haswell-ipc.h
       delete mode 100644 sound/soc/intel/haswell/sst-haswell-pcm.c
      
      --
      2.17.1
      43499134
    • Alex Dewar's avatar
      ASoC: omap-mcbsp: Fix use of uninitialised pointer · cd7dea5e
      Alex Dewar authored
      Commit 9c34d023 ("ASoC: omap-mcbsp: Re-arrange files for core McBSP
      and Sidetone function split"), in rearranging various files, also replaced
      calls to platform_get_resource_by_name() + devm_ioremap_resource() with a
      single call to devm_platform_ioremap_resource_byname(). However, the
      struct resource is needed as we access its members so at present a null
      pointer is dereferenced. Fix by doing things the old way.
      
      Fixes: 9c34d023 ("ASoC: omap-mcbsp: Re-arrange files for core McBSP and Sidetone function split")
      Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
      Link: https://lore.kernel.org/r/20201004102535.325547-1-alex.dewar90@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      cd7dea5e
    • Cezary Rojewski's avatar
      ASoC: Intel: Remove sst_dsp_get_thread_context · eb062e47
      Cezary Rojewski authored
      While sst_dsp_get_thread_context() is declared as solution-agnostic, it
      is only used by /skylake/ solution. Majority of thread_context field
      usages are direct accesses. Improve code cohesiveness and convert to
      single usage model.
      Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
      Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
      Acked-by: default avatarLiam Girdwood <liam.r.girdwood@intel.com>
      Link: https://lore.kernel.org/r/20201006064907.16277-14-cezary.rojewski@intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      eb062e47