1. 20 Aug, 2018 7 commits
  2. 02 Aug, 2018 2 commits
    • Anton Vasilyev's avatar
      HID: intel_ish-hid: tx_buf memory leak on probe/remove · 50fa9259
      Anton Vasilyev authored
      ish_dev_init() allocates 512*176 bytes memory for tx_buf and stores it at
      &dev->wr_free_list_head.link list on ish_probe().
      But there is no deallocation of this memory in ish_remove() and in
      ish_probe() error path.
      So current intel-ish-ipc provides 88 KB memory leak for each
      probe/release.
      
      The patch replaces kzalloc allocation by devm_kzalloc and removes
      ishtp_device *dev deallocation by kfree.
      
      Found by Linux Driver Verification project (linuxtesting.org).
      Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
      Acked-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      50fa9259
    • Srinivas Pandruvada's avatar
      HID: intel-ish-hid: Prevent loading of driver on Mehlow · a1e9a9c0
      Srinivas Pandruvada authored
      On Mehlow Xeon-E workstation, ISH PCI device is enabled but without ISH
      firmware. Here the ISH device PCI device id was reused for some non Linux
      storage drivers. So this was not done for enabling ISH. But this has a
      undesirable side effect for Linux.
      
      Here the ISH driver will be loaded via PCI enumeration and will try to do
      reset sequence. But reset sequence will wait till timeout as there is no
      real ISH firmware is present to take action. This delay will add to boot
      time of Linux (This platform will still continue to boot after this
      timeout).
      
      To avoid this boot delay we need to prevent loading of ISH drivers on
      this platform. So we need to have hack to avoid treating this device as
      ISH on this platform. To identify this workstation, we need some runtime
      method. Luckily there are special PCI id on this workstation to
      distinguish from the client version of this platform. On client version,
      the ISH is supported using same PCI device id. So this change look for
      the presence of PCI device IDs A309 and A30A and exit.
      Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
      Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      a1e9a9c0
  3. 23 Jul, 2018 2 commits
  4. 17 Jul, 2018 22 commits
  5. 10 Jul, 2018 1 commit
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid · 092150a2
      Linus Torvalds authored
      Pull HID fixes from Jiri Kosina:
      
       - spectrev1 pattern fix in hiddev from Gustavo A. R. Silva
      
       - bounds check fix for hid-debug from Daniel Rosenberg
      
       - regression fix for HID autobinding from Benjamin Tissoires
      
       - removal of excessive logging from i2c-hid driver from Jason Andryuk
      
       - fix specific to 2nd generation of Wacom Intuos devices from Jason
         Gerecke
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid:
        HID: hiddev: fix potential Spectre v1
        HID: i2c-hid: Fix "incomplete report" noise
        HID: wacom: Correct touch maximum XY of 2nd-gen Intuos
        HID: debug: check length before copy_to_user()
        HID: core: allow concurrent registration of drivers
      092150a2
  6. 09 Jul, 2018 6 commits