- 11 Apr, 2013 26 commits
-
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. This driver does a second request_region() for the I/O space needed by the 8255 chip. Modify the error message if that request fails so it matches to format of the comedi_request_region() message. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Also, remove the unnecessary 'dev->irq = 0'. This driver does not use interrupts and the comedi core has already cleared this variable. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Also, remove the unnecessary 'dev->irq = 0'. This driver does not use interrupts and the comedi core has already cleared this variable. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Also, remove the unnecessary 'dev->irq = 0'. This driver does not use interrupts and the comedi core has already cleared this variable. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_request_region() to request the I/O region used by this driver. Remove the noise when the board is first attached as well as the error message when the request_region() fails, comedi_request_reqion() will output the error message if necessary. Signed-off-by:
-
H Hartley Sweeten authored
This legacy driver does no additional probing so the dev->board_name will already be properly initialized by the comedi core before calling the (*attach) function. Remove the unnecessary initialization of dev->board_name and use it when requesting the resources instead of the open-coded strings. Signed-off-by:
-
H Hartley Sweeten authored
Introduce a helper function to handle the request_region() for legacy comedi drivers. As pointed out by Ian Abbott, legacy devices are configured manually with the "comedi_config" program. The error messages are useful diagnostics when trying to attach to these boards. Providing a helper function allows consolidating the error messages in the drivers and providing a consistent format for the errors. This helper also sets the dev->iobase automatically for the driver if the request_region() is successful. Signed-off-by:
-
Serban Constantinescu authored
This patch modifies the IOCTL macros to use user-exportable data types, as they are the referred kernel types for the user/kernel interface. The patch does not change in any way the functionality of the binder driver. Signed-off-by:
Serban Constantinescu <serban.constantinescu@arm.com> Acked-by:
Arve Hjønnevåg <arve@android.com> Signed-off-by:
-
Matthijs Kooijman authored
This adds a config option USB_DWC2_DEBUG_PERIODIC that allows debugging output be suppressed for periodic transfers. This helps when debugging non-periodic transfers while there are also periodic transfers going on (both to make the debug output less polluted and to prevent all CPU time going to debug messages). In addition, a debug message from dwc2_hcd_is_status_changed is removed entirely, since it often floods the log regardless of periodic transfers. Signed-off-by:
Matthijs Kooijman <matthijs@stdin.nl> Cc: Paul Zimmerman <Paul.Zimmerman@synopsys.com> Signed-off-by:
-
- 09 Apr, 2013 14 commits
-
-
H Hartley Sweeten authored
Convert the register defines to hex and the register bit defines to bit shifts. Rename the CSR register bit defines to help document them and move them so they are associated with the register. Rename the RTI800_SIZE define to RTI800_IOSIZE. Signed-off-by:
-
H Hartley Sweeten authored
Update the MODULE_DESCRIPTION to better describe the driver. Signed-off-by:
-
H Hartley Sweeten authored
Cleanup the multi-line comments at the beginning of the file to follow the kernel CodingStyle. Remove the comments before rt1800_attach(). They are a duplicate of the "Configuration Options" in the Comedi comment block at the start of the file. Signed-off-by:
-
H Hartley Sweeten authored
This driver is the only file that includes the am9513.h header and nothing from that header is actually used. Using the macros provided by am9513.h is a bit ugly due to having to predefine a number of additional macros to handle the low-level I/O to the Am9513 device. Just remove the header and the unused I/O helpers in the rti800 driver. If support for the am9513 is added later it wil be implemented properly at that time. Signed-off-by:
-
H Hartley Sweeten authored
The comedi core expects the (*insn_read) functions to return the number of data values actually read. Change the return from 'i' to 'insn->n' to make this clearer. Signed-off-by:
-
H Hartley Sweeten authored
The (mask & val) operation when reading the high 4-bits of the analog data looks strange. Change it to (val & mask). Signed-off-by:
-
H Hartley Sweeten authored
The analog input on this board can return data as either two's complement or straight binary data. The format is selected by a jumper of the board and enabled by the user as option[4] when attaching to the board. Replace the adc_coding enum with a simple bool to indicate that the data is returned in two's complement form. Signed-off-by:
-
H Hartley Sweeten authored
Factor the timeout loop that waits for the ai conversion to complete out of rti800_ai_insn_read(). Signed-off-by:
-
H Hartley Sweeten authored
Refactor the code that determines the 'delay' after setting the muxgain register to remove the BUG_ON(). Change the private data 'muxgain_bits' to an unsigned char, the muxgain register is only 8-bits. Signed-off-by:
-
H Hartley Sweeten authored
The insn->chanspec passed to the CR_{CHAN,RANGE} macros is an unsigned int. For aesthetic reasons, put the result of the macros into an unsigned int local var. Signed-off-by: -
H Hartley Sweeten authored
For aesthetic reasons, tidy up the parameters passed to this function. The comedi core expects (*insn_read) functions to return the number of data values actually read (insn->n). Change the return to make clearer. Signed-off-by:
-
H Hartley Sweeten authored
This board has two independent analog output channels. Each channel has its own 12-bit D.A converter. Each channel can be set to output a unipolar 10V or bipolar 10V signal. This selection is handled by a jumper on the board and configured by the user with options[5] and [7] passed during the attach of the board. The two channels can also be configured with jumpers to use straight binary or two's complement data. The user configures the data type with options[6] and [8] when attaching. Currently, this driver uses the dac0 selection, option[6], for both channels. Fix the rti800_ao_insn_write() function to properly use the configuration specified by the user. Change the dac[01]_coding in the private data to a simple bool array, dac_2comp. Add some local vars to hold the registers offsets needed to write to the DAC. Only the last value written to the DAC needs to be cached for readback, Signed-off-by:
-
H Hartley Sweeten authored
For aesthetic reasons, tidy up the parameters passed to this function. Signed-off-by:
-
H Hartley Sweeten authored
To clarify the function a bit, add local variables for the 'mask' and 'bits', passed by the comedi core, used to update the digital outputs. Signed-off-by:
-
