Commits · a9a6073c51ddc4f562b1918ded7e27830e0d9d9f · nexedi / linux

09 Oct, 2010 3 commits

staging: brcm80211: Purge unused packet engine · a9a6073c

Brett Rudley authored Oct 08, 2010

We're not using the packet engine anymore - goodbye.
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a9a6073c

staging: brcm80211: bug fix- dual band problem · fb693a71

nohee ko authored Oct 08, 2010

Bug fix for dual band problem. In particular it had an issue
to connect to 5G band AP.
Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

fb693a71

Staging: speakup: serialio: Fixed errors in file · ef999f10

Tracey Dent authored Oct 08, 2010

On line 40 printk() needed an KERN_* facility level, so I gave it
INFO. Also, fixed a C99 comment error.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ef999f10

08 Oct, 2010 37 commits

staging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac · 40e5c96b

Brett Rudley authored Oct 08, 2010

Combine dma_alloc routine for full and softmac
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

40e5c96b

staging: brcm80211: Purge unused memlist debugging · 17b31385

Brett Rudley authored Oct 08, 2010

Purge unused memlist debugging
Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

17b31385

Staging: brcm80211: remove BCMATTACHFN macro · 0d2f0724

Greg Kroah-Hartman authored Oct 08, 2010

It's not doing anything and is a bit silly.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0d2f0724

Staging: brcm80211: remove BCMATTACHDATA macro · 17c4da1e

Greg Kroah-Hartman authored Oct 08, 2010

It's not even used for anything, not to mention, it is pretty silly.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

17c4da1e

Staging: brcm80211: brcmfmac: fix some comparison warnings · b61640d1

Greg Kroah-Hartman authored Oct 08, 2010

Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

b61640d1

Staging: brcm80211: sys: fix some comparison warnings · a300ce95

Greg Kroah-Hartman authored Oct 08, 2010

Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a300ce95

Staging: brcm80211: sys: wlc_ampdu: fix some comparison warnings · 697d600d

Greg Kroah-Hartman authored Oct 08, 2010

Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

697d600d

Staging: brcm80211: phy: wlc_phy_n: fix some comparison warnings · e9e6727f

Greg Kroah-Hartman authored Oct 08, 2010

Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.d

e9e6727f

Staging: brcm80211: hnddma.c: fix compiler warning · c09cc586

Greg Kroah-Hartman authored Oct 08, 2010

Change the field types of dma_info_t to make comparing values easier
(and correct.)  No need to keep rxbufsize as a u16, it can be an
unsigned int to make things easier.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

c09cc586

Staging: brcm80211: remove VALID_MASK macro · 96e76e69

Greg Kroah-Hartman authored Oct 08, 2010

No one is using it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

96e76e69

Staging: brcm80211: remove ROUNDUP macro · e18d5313

Greg Kroah-Hartman authored Oct 08, 2010

And use the kernel provided 'roundup' instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e18d5313

Staging: brcm80211: remove ISALIGNED macro · 36c63ff6

Greg Kroah-Hartman authored Oct 08, 2010

And use the kernel provided IS_ALIGNED one instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

36c63ff6

Staging: brcm80211: remove unused ALIGN_ADDR() macro · d2733c97

Greg Kroah-Hartman authored Oct 08, 2010

It's not used (and there's a kernel provided one if it's ever needed in
the future), so remove it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

d2733c97

Staging: brcm80211: remove ARRAYSIZE macro · 8d3d6a69

Greg Kroah-Hartman authored Oct 08, 2010

Use the real 'ARRAY_SIZE' definition instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8d3d6a69

Staging: brcm80211: remove OFFSETOF macro · ce0f1b8c

Greg Kroah-Hartman authored Oct 08, 2010

Use the real 'offsetof' definition instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ce0f1b8c

Staging: brcm80211: remove broken MAX() implementation · 3ea2f4d6

Greg Kroah-Hartman authored Oct 08, 2010

Use the kernel-provided version, this one is broken.

Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way.  They need to be fixed up.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

3ea2f4d6

Staging: brcm80211: remove broken MIN() implementation · 7068c2f1

Greg Kroah-Hartman authored Oct 08, 2010

Use the kernel-provided version, this one is broken.

Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way.  They need to be fixed up.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

7068c2f1

Staging: brcm80211: util: remove unneeded usage of uintptr · c03b63c1

Greg Kroah-Hartman authored Oct 08, 2010

Double casting is pretty pointless, don't do that.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

c03b63c1

Staging: brcm80211: remove unused typedefs in typedefs.h · f1d0fe0a

Greg Kroah-Hartman authored Oct 08, 2010

uint is already defined somewhere else, so just remove this version
of it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f1d0fe0a

Staging: brcm80211: s/int32/s32/ · 3e26416e

Greg Kroah-Hartman authored Oct 08, 2010

Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

3e26416e

Staging: brcm80211: s/uint32/u32/ · 66cbd3ab

Greg Kroah-Hartman authored Oct 08, 2010

Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

66cbd3ab

Staging: bcm: silence off by one warning · 370adc7c

Dan Carpenter authored Oct 08, 2010

"status" is used as an index into the Adapter->PackInfo[] array, which
has NO_OF_QUEUES elements.

This code actually works OK.  The SearchSfid() function always returns
a valid index or it returns NO_OF_QUEUES + 1.  But it looks sloppy and
it makes the static checkers complain.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

370adc7c

Staging: bcm: remove unneeded NULL check · 02339374

Dan Carpenter authored Oct 08, 2010

The error handling here is wrong.  If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.

Since the check isn't needed and I removed it instead of fixing it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

02339374

Staging: bcm: return -EFAULT on copy_to_user() errors · ef5d2056

Dan Carpenter authored Oct 08, 2010

bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ef5d2056

Staging: bcm: dereferencing before checking · acedadfa

Dan Carpenter authored Oct 08, 2010

I moved the check to see if "Adapter" was null in front of the
dereference.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

acedadfa

Staging: bcm: mocro expansion bug · 055a1eda

Dan Carpenter authored Oct 08, 2010

The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like
this:

    if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8)

The multiplication by eight has precedence over the addition so the
macro needs parenthesis to work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

055a1eda

Staging: bcm: make major and minor signed · 785698e3

Dan Carpenter authored Oct 08, 2010

We assume that major is signed in register_control_device_interface().
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

785698e3

Staging: bcm: return -EFAULT on copy_to_user() failures · bf58bd66

Dan Carpenter authored Oct 08, 2010

There were a number of places in the bcm_char_ioctl() which returned the
number of bytes remaining to be copied instead of returning -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

bf58bd66

Staging: speakup: devsynth: file_operations should be const · a1823f2e

Tracey Dent authored Oct 08, 2010

Fixed file_operation struct, so that it is const.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a1823f2e

Staging: speakup: keyhelp: Coding style fix · 1bd15cfd

Tracey Dent authored Oct 08, 2010

Put { on previous line, on line 34. Checkpatch.pl caught this.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1bd15cfd

Staging: speakup: Makefile: Makefile clean up · 0c7023b2

Tracey Dent authored Oct 08, 2010

Replaced <modules>-objs with <modules>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0c7023b2

Staging: batman-adv: Makefile: replace the use of <module>-objs with <module>-y · 8996ba13

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y n Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8996ba13

Staging: bcm: Makefile: replace the use of <module>-objs with <module>-y · 9a837af5

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

9a837af5

Staging: comedi: Makefile: replace the use of <module>-objs with <module>-y · 23d18860

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

23d18860

Staging: crystalhd: Makefile: replace the use of <module>-objs with <module>-y · 1087020f

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1087020f

Staging: cx25821: Makefile: replace the use of <module>-objs with <module>-y · 88efaabc

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

88efaabc

Staging: easycap: Makefile: replace the use of <module>-objs with <module>-y · 77037b49

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

77037b49