Commits · b219e3ac66183fc9771b94af931fb5fd41d586ec · nexedi / linux

29 Sep, 2006 40 commits

[Bluetooth] Integrate low-level connections into the driver model · b219e3ac

Marcel Holtmann authored Jul 06, 2006

This patch integrates the low-level connections (ACL and SCO) into the
driver model. Every connection is presented as device with the parent
set to its host controller device.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

b219e3ac

[Bluetooth] Remove unused host controller attributes · 4d0eb004

Marcel Holtmann authored Jul 06, 2006

This patch removes the unused device attribute entries for the Bluetooth
host controllers.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

4d0eb004

[RTNETLINK]: Possible dereference in net/core/rtnetlink.c · 9918f230

Eric Sesterhenn authored Sep 26, 2006

another possible dereference spotted by coverity (#cid 1390).
if the nlmsg_parse() call fails, we goto errout, where we call
dev_put(), with dev still initialized to NULL.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

9918f230

[SUNRPC]: more sunrpc endianness annotations · 753ed90d

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

753ed90d

[SUNRPC]: trivial endianness annotations · d8ed029d

Alexey Dobriyan authored Sep 26, 2006

pure s/u32/__be32/

[AV: large part based on Alexey's patches]
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d8ed029d

[SUNRPC]: svc_{get,put}nl() · 76994313

Alexey Dobriyan authored Sep 26, 2006

* add svc_getnl():
	Take network-endian value from buffer, convert to host-endian
	and return it.
* add svc_putnl():
	Take host-endian value, convert to network-endian and put it
	into a buffer.
* annotate svc_getu32()/svc_putu32() as dealing with network-endian.
* convert to svc_getnl(), svc_putnl().

[AV: in large part it's a carved-up Alexey's patch]
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

76994313

[IPV4]: ip_build_and_send_pkt() annotations · 13d8eaa0

Al Viro authored Sep 26, 2006

saddr and daddr are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

13d8eaa0

[IPV4]: ip_options_build() annotations · 8712f774

Al Viro authored Sep 26, 2006

daddr is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

8712f774

[IPV4] bug: broken open-coded inet_make_mask() (multipath_wrandom) · e8192f36

Al Viro authored Sep 26, 2006

multipath_wrandom.c::__multipath_lookup_weight() contains open-coded
attempt at inet_make_mask(); broken on big-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e8192f36

[IPV4] multipath_wrandom.c: trivial annotations · f20f4a60

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

f20f4a60

[IPV4]: multipath_set_nhinfo() annotations · d9cd66e0

Al Viro authored Sep 26, 2006

multipath_set_nhinfo() (and underlying callback) take net-endian
network and netmask.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d9cd66e0

[IPV4] fib_trie.c: trivial annotations · 32ab5f80

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

32ab5f80

[IPV4] bug: open-coded inet_make_mask() in fib_semantic_match() is broken · 1e8aa6f1

Al Viro authored Sep 26, 2006

... and works only on little-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

1e8aa6f1

[IPV4]: fib_semantic_match() annotations · 1ef1b8c8

Al Viro authored Sep 26, 2006

'mask' and 'zone' arguments are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

1ef1b8c8

[IPV4]: trivial fib_hash.c annotations · b6e80c6c

Al Viro authored Sep 26, 2006

hash key and stored netmask are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b6e80c6c

[IPV4]: annotate addresses in fib_result and fib_result_nl · 80e856e1

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

80e856e1

[IPV4]: ip_fragment.c endianness annotations · 18277770

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

18277770

[IPV4]: inetpeer annotations · 53576d9b

Al Viro authored Sep 26, 2006

This one is interesting - we use net-endian value as search key, but
order the tree by *host-endian* comparisons of keys.  OK since we only
care about lookups.  Annotated inet_getpeer() and friends.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

53576d9b

[IPV4]: ip_fib_check_default() annotated · d878e72e

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d878e72e

[IPV4]: inet_addr_type() annotations · fd683222

Al Viro authored Sep 26, 2006

argument and inferred net-endian variables in callers annotated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

fd683222

[IPV4]: icmp_send() annotation · e4883014

Al Viro authored Sep 26, 2006

The last argument is network-endian (it will go straight into the packet).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e4883014

[IPV4]: annotate inetdev.h helpers · 60cad5da

Al Viro authored Sep 26, 2006

inet_confirm_addr(), inet_ifa_byprefix(), ip_dev_find(), inet_make_mask() and
inet_ifa_match() annotated, along with inferred net-endian variables
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

60cad5da

[IPV4]: IFA_{LOCAL,ADDRESS,BROADCAST,ANYCAST} on ipv4 annotated · a7a628c4

Al Viro authored Sep 26, 2006

use be32 netlink accessors
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a7a628c4

[IPV4]: annotate struct in_ifaddr · a144ea4b

Al Viro authored Sep 28, 2006

ifa_local, ifa_address, ifa_mask, ifa_broadcast and ifa_anycast are
net-endian.  Annotated them and variables that are inferred to be
net-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a144ea4b

[IPV4]: struct fib_config IPv4 address fields annotated · 6d85c10a

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

6d85c10a

[IPV4]: RTA_{DST,SRC,GATEWAY,PREFSRC} annotated · 17fb2c64

Al Viro authored Sep 26, 2006

these are passed net-endian; use be32 netlink accessors
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

17fb2c64

[IPV4] net/ipv4/route.c: trivial endianness annotations · e448515c

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e448515c

[IPV4]: introduce nla_get_be32()/NLA_PUT_BE32() · 00012e5b

Al Viro authored Sep 26, 2006

net-endian counterparts of nla_get_u32()/NLA_PUT_U32()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

00012e5b

[IPV4]: FIB_RES_PREFSRC() annotated · b83738ae

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b83738ae

[IPV4]: fib_hn ->nh_gw is net-endian · ed49e3ca

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

ed49e3ca

[IPV4]: inet_addr_onlink() annotated · ff428d72

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

ff428d72

[IPV4]: ip_check_mc() annotations · a60c4923

Al Viro authored Sep 26, 2006

annotated arguments
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a60c4923

[IPV4]: fib_validate_source() annotations · d9c9df8c

Al Viro authored Sep 26, 2006

annotated arguments and inferred net-endian variables in callers
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d9c9df8c

[IPV4]: inet_select_addr() annotations · a61ced5d

Al Viro authored Sep 26, 2006

argument and return value are net-endian.  Annotated function and inferred
net-endian variables in callers.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a61ced5d

[IPV4]: annotated ipv4 addresses in struct inet_sock · 011a9261

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

011a9261

[IPV4]: ip_route_connect() ipv4 address arguments annotated · bada8adc

Al Viro authored Sep 26, 2006

annotated address arguments (port number left alone for now); ditto
for inferred net-endian variables in callers.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

bada8adc

[IPV4]: annotate ipv4 addresses in struct rtable and struct flowi · f2c3fe24
Al Viro authored Sep 26, 2006
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
f2c3fe24

[IPV4]: annotate rt_hash_code() users · 8c7bc840

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

8c7bc840

[IPV4]: ip_rt_redirect() annotations · f7655229

Al Viro authored Sep 26, 2006

The first 4 arguments of ip_rt_redirect() are net-endian.  Annotated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

f7655229

[IPV4]: ip_route_input() annotations · 9e12bb22

Al Viro authored Sep 26, 2006

ip_route_input() takes net-endian source and destination address.
* Annotated as such.
* arguments of its invocations annotated where needed.
* local helpers getting the same values passed to by it (ip_route_input_mc(),
ip_route_input_slow(), ip_handle_martian_source(), ip_mkroute_input(),
ip_mkroute_input_def(), __mkroute_input()) annotated
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

9e12bb22