1. 06 Feb, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide-generic: probing bugfix · b2a53bc6
      Bartlomiej Zolnierkiewicz authored
      On Tuesday 05 February 2008, Linus Torvalds wrote:
      > 
      > On Sat, 2 Feb 2008, Bartlomiej Zolnierkiewicz wrote:
      > > 
      > > * next part of IDE probing code re-organization saga
      > >   (that would be me)
      > 
      > This seems to cause very irritating and bogus messages for me:
      > 
      >       Probing IDE interface ide0...
      >       Probing IDE interface ide1...
      >       ide2: I/O resource 0x0-0x7 not free.
      >       ide2: ports already in use, skipping probe
      >       ide3: I/O resource 0x0-0x7 not free.
      >       ide3: ports already in use, skipping probe
      >       ide4: I/O resource 0x0-0x7 not free.
      >       ide4: ports already in use, skipping probe
      >       ide5: I/O resource 0x0-0x7 not free.
      >       ide5: ports already in use, skipping probe
      >       ide6: I/O resource 0x0-0x7 not free.
      >       ide6: ports already in use, skipping probe
      >       ide7: I/O resource 0x0-0x7 not free.
      >       ide7: ports already in use, skipping probe
      >       ide8: I/O resource 0x0-0x7 not free.
      >       ide8: ports already in use, skipping probe
      >       ide9: I/O resource 0x0-0x7 not free.
      >       ide9: ports already in use, skipping probe
      > 
      > and that's just totally bogus. It shouldn't even request that region, 
      > since it's not been allocated!
      
      The commit 139ddfca ("ide: move handling of
      I/O resources out of ide_probe_port()") changed the ordering of hwif->noprobe
      check vs ide_hwif_request_regions() call (so that we now reserve I/O regions
      before checking for hwif->noprobe).  However ide-generic host driver depended
      on hwif->noprobe to be set for skipping probing of empty ide_hwifs[] slots.
      
      Fix it by passing only indexes of non-empty slots to ide_device_add_all()
      from ide_generic_init().
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      b2a53bc6
  2. 05 Feb, 2008 39 commits