On Tuesday 27 April 2004 10:58, Oliver Neukum wrote:
> Am Dienstag, 27. April 2004 00:14 schrieb Greg KH:
> > On Mon, Apr 26, 2004 at 04:05:17PM +0200, Duncan Sands wrote:
> > > diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> > > --- a/drivers/usb/core/devio.c	Mon Apr 26 13:48:28 2004
> > > +++ b/drivers/usb/core/devio.c	Mon Apr 26 13:48:28 2004
> > > @@ -350,8 +350,8 @@
> > >  	 * all pending I/O requests; 2.6 does that.
> > >  	 */
> > >
> > > -	if (ifnum < 8*sizeof(ps->ifclaimed))
> > > -		clear_bit(ifnum, &ps->ifclaimed);
> > > +	BUG_ON(ifnum >= 8*sizeof(ps->ifclaimed));
> >
> > I've changed that to a WARN_ON().  Yeah, writing over memory is bad, but
> > oopsing is worse.  Let's be a bit nicer than that.
>
> You aren't nice that way. An oops has localised consequences. Scribbling
> over memory can cause anything.

Hi Greg, if won't accept a BUG_ON, how about the following?

And change __inline__ to inline and get rid of an unused function
while at it.

here is the latest version 0.95 of the LEGO USB Tower driver against 2.6.6-rc3
which corrects a lot of problems in the version currently in the kernel,
most notably sleeping in interrupt context and improper locking.
Please apply.

It has been thoroughly tested with UHCI, OHCI and EHCI host controllers
using Lejos and NQC.  Firmware and program download, and with proper
modifications all communication protocols supported by Lejos work,
as well as firmware and program download and datalog upload in NQC.

Notes to application maintainers/protocol designers:

- Small modifications are needed in communication protocols because
  the tower tends to discard the first byte of transmissions.
  So for example LNP needs to send an extra byte like 0xff before
  the packet, and F7 handlers needs to cope with a lost 0x55.

- I suggest /dev/usb/legousbtower0 etc. as the standard device names.
  This puts it in the same place as the other USB devices and makes
  clear which driver is responsible for these devices.

This patch rejects URB submissions to suspended devices, so
that they don't get hardware-specific fault reports.  Instead,
they get the same code (-EHOSTUNREACH) for all HCDs.

It also fixes a minor problem with colliding declarations of
the symbol USB_STATE_SUSPENDED.

This patch lets gadget zero be more useful in testing usb suspend
and resume.  It prints messages on suspend() and resume(), and
supports an "autoresume=N" mode to wake the host after N seconds.

The Alcatel TD10 USB to Serial converter cable (for use with a Alcatel
OT 535 or 735(i) mobile phone) seems to be a repackaged Alcatel
version of the Prolific 2303 adapter.

And as such, simply adding its product/vendor id (0x11f7/0x02df) to
drivers/usb/serial/pl2303.c seems to be enough to make it work.

The USB core is changing the way interfaces and altsettings are stored.
They are no longer required to be in numerical order, and as a result,
simply indexing the interface and altsetting arrays won't work as
expected.

This patch for the st5481 takes these changes into account.  A simpler
approach would be to store a pointer to the struct usb_host_interface
rather than look it up repeatedly, but I'm not very familiar with this
driver and didn't want to attempt such an alteration.

This really needs to get fixed the proper way, by making the urb allocation
dynamic in the driver, instead of the hack it is currently doing...

Somehow I managed to send the wrong version. Here is a patch which fixes
that. (Remove a dev_info() which wasn't supposed to be there, and make sure
that everything is still consistent in the unlikely event that kmalloc()
fails). Just minor cleanups.

into kroah.com:/home/greg/linux/BK/usb-2.6

into ppc970.osdl.org:/home/torvalds/v2.6/linux

a ppc64 tree.

> 2) An undefined 'hubstatus' variable in drivers/usb/core/hub.c:
>
>       CC      drivers/usb/core/hub.o
>     drivers/usb/core/hub.c: In function `hub_port_connect_change':
>     drivers/usb/core/hub.c:1343: error: `hubstatus' undeclared (first use in this function)
>     drivers/usb/core/hub.c:1343: error: (Each undeclared identifier is reported only once
>     drivers/usb/core/hub.c:1343: error: for each function it appears in.)
>     make[3]: *** [drivers/usb/core/hub.o] Error 1
>
>   As a total shot in the dark, the following fixes the build (I've no clue
>   if it is the right fix):

Yes, it's the right fix.  Greg, please merge the attached patch,
which will be needed on any big-endian system.

into kernel.bkbits.net:/home/davem/net-2.6

More functions and data that should be static.

On Tue, 27 Apr 2004, Greg KH wrote:

> So, what's next in this patch series?  :)

Funny you should ask...

While writing those patches I noted a problem, that the USB device tree
can change while a process reading /proc/bus/usb/devices is traversing it,
leading to an oops when a pointer to a no-longer-existing child device is
dereferenced.  The ensuing discussion led to the conclusion that the
devices' ->serialize locks should be acquired, top-down, while going
through the tree.

That means changing the code that populates the devices file and changing
the code that adds and removes USB device structures.  This patch takes
care of the first part.  I'm delaying the second part because that section
of usbcore is still under change -- David Brownell's revisions have not
yet been fully integrated.

A similar change should be made to usb_find_device() and match_device() in
usb.c.  You may want to add that yourself.

Here is a driver for the usb servo controllers from Phidgets
<http://www.phidgets.com/>, using sysfs.

Note that the devices claim to be hid devices, so I've added them to the
hid_blacklist (HID_QUIRK_IGNORE). A servo controller isn't really an hid
device (or is it?).

Thanks to Dru <andru@treshna.com>, who provided an easy way to reproduce
the problem.

What we have in lib/rwsem.c:__rwsem_do_wake():
	int woken, loop;
	^^^
and several lines below:
	loop = woken;
	woken *= RWSEM_ACTIVE_BIAS-RWSEM_WAITING_BIAS;
	woken -= RWSEM_ACTIVE_BIAS;

However, rw_semaphore->count is 64-bit on Alpha, so
RWSEM_WAITING_BIAS has been defined as -0x0000000100000000L.
Obviously, this blows up in the write contention case.

Fix new ISDN CAPI's internal ncci list semaphore if
CONFIG_ISDN_CAPI_MIDDLEWARE is disabled.

Thanks to Florian Schirmer.

into ppc970.osdl.org:/home/torvalds/v2.6/linux

into sgi.com:/source2/xfs-linux-2.6

SGI Modid: xfs-linux:xfs-kern:170489a

SGI Modid: xfs-linux:xfs-kern:170509a

SGI Modid: xfs-linux:xfs-kern:170448a

From: Tom Rini <trini@kernel.crashing.org>

This patch updates support for the Motorola PrPMC750 platform.  Most of the
size in this patch comes from merging prpmc750_pci.c and prpmc750_setup.c into
just prpmc750.c.

From: Tom Rini <trini@kernel.crashing.org>

This patch adds openpic_hookup_cascade(offset, name, handler) which allows for
an arbitrary interrupt controller to be hooked up as a cascade to the openpic.
 This also allows for platforms to just not have a cascaded controller.

From: Tom Rini <trini@kernel.crashing.org>

This patch updates support for the SBS K2 platform.  Most of the size in this
patch comes from merging k2_pci.c and k2_setup.c into just k2.c.

From: Christoph Hellwig <hch@lst.de>

asm-ppc/elf.h uses a pointer to struct task_struct without any
forward-declaration.

In file included from include/linux/elf.h:5,
                 from arch/ppc/boot/simple/misc.c:20:
include/asm/elf.h:102: warning: `struct task_struct' declared inside parameter list
include/asm/elf.h:102: warning: its scope is only this definition or declaration, which is probably not what you want

From: Tom Rini <trini@kernel.crashing.org>

And when trying to catch up on old patches, I forgot this hunk:

From: Tom Rini <trini@kernel.crashing.org>

When I changed some '#if FOO' tests to '#ifdef FOO' I forgot to make sure
that nothing was doing #define FOO 0.  So after auditing all of the changes
I made, the following is needed:

From: Olof Johansson <olof@austin.ibm.com>

On pSeries LPARs we might end up with NUMA nodes that only have memory and
no CPUs.  Only the CPU configuration code actually set a node online, so
memory-only nodes wouldn't show up in sysfs.  Below patch adds the
set_online call to the memory loop too.

From: "Luiz Fernando N. Capitulino" <lcapitulino@prefeitura.sp.gov.br>

fs/dquot.c: In function `vfs_quota_off':
fs/dquot.c:1328: warning: label `out' defined but not used