- 19 Oct, 2017 40 commits
-
-
Georgiana Chelu authored
The result variable is initialized at the beginning of the function, but its value does not change during the function execution. Thus, remove the variable and return the SUCCESS value, which is 0. Issue found by coccinelle script: * Unneeded variable: "result". Return "0" Path to the cocci script: scripts/coccinelle/misc/returnvar.cocci Signed-off-by:
Georgiana Chelu <georgiana.chelu93@gmail.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Georgiana Chelu authored
The kzalloc function returns a void pointer and the assignment operator converts it to the type of pointer it is assigned to. Therefore, there is no need to cast. Issue found by alloc_cast.cocci: * WARNING: casting value returned by memory allocation function to <struct type> is useless. Path to the cocci script: scripts/coccinelle/api/alloc/alloc_cast.cocci Signed-off-by:
-
Christian König authored
While binding BOs to GART we need to allow a bit overcommit in the GTT domain. Otherwise we can never use the full GART space when GART size=GTT size. Signed-off-by:
Christian König <christian.koenig@amd.com> Reviewed-by:
Chunming Zhou <david1.zhou@amd.com> Signed-off-by:
-
Christian König authored
For VM emulation for old UVD/VCE we need to validate the BO with linear VRAM flag set first and then eventually bind it to GART. Validating with linear VRAM flag set can move the BO to GART making UVD/VCE read/write from an unbound GART BO. Signed-off-by:
-
Rex Zhu authored
Clear the count in the single table setup function to avoid missing any tables. Reviewed-by:
Rex Zhu <Rex.Zhu@amd.com> Signed-off-by:
-
Rex Zhu authored
regression issue. caused by "f12f9f5e5d455edebc01" forget to set start_thermal_controller function point. Reviewed-by:
-
pding authored
Register accessing is performed when IRQ is disabled. Never sleep in this function. Known issue: dead sleep in many use cases of index/data registers. v2: - wrap polling fence functions. - don't trigger IRQ for polling in case of wrongly fence signal. v3: - handle wrap round gracefully. - add comments for polling function v4: - don't return negative timeout confused with error code Signed-off-by:
pding <Pixel.Ding@amd.com> Reviewed-by:
-
pding authored
Only for GFX ring. This can help checking MCBP feature. The fence at the end of the frame will indicate the completion status. If the frame completed normally, the fence is written to the address given in the EVENT_WRITE_EOP packet. If preemption occurred in the previous IB the address is adjusted by 2 DWs. If work submitted in the frame was reset before completion, the fence address is adjusted by four DWs. In the case that preemption occurred, and before preemption completed a reset was initiated, the address will be adjusted with six DWs Signed-off-by:
Monk Liu <monk.liu@amd.com> Reviewed-by:
-
Monk Liu authored
Signed-off-by:
-
Monk Liu authored
Signed-off-by:
-
Monk Liu authored
with current WB usage we only use 57 slots, so 512 is extreamly sufficient, and reduce to 512 can make WB fit into one page. Signed-off-by:
-
Rex Zhu authored
fw ucode is corrupted after vf flr by PSP so ucode_init() is a must in psp_hw_init othewise KIQ/KCQ enabling will fail Revert "drm/amdgpu: refine code delete duplicated error handling" This reverts commit e57b87ff828f95efe992468e6d18c2c059b27aa9. Revert "drm/amdgpu: move amdgpu_ucode_init_bo to amdgpu_device.c" This reverts commit 815b8f8595148d06a64d2ce4282e8e80dfcb02f1. Reviewed-by:
-
Tom St Denis authored
Use PP_CAP macro. Signed-off-by:
Tom St Denis <tom.stdenis@amd.com> Reviewed-by:
-
Tom St Denis authored
Use PP_CAP macro. Signed-off-by:
-
Tom St Denis authored
Use PP_CAP and tidy up indentation. Signed-off-by:
-
Tom St Denis authored
Use PP_CAP and tidy up indentation. Signed-off-by:
-
Tom St Denis authored
Use PP_CAP and simplify enable/disable logic. Signed-off-by:
-
Tom St Denis authored
Use PP_CAP and tidy up indentation. Signed-off-by:
-
Tom St Denis authored
Remove unused variables. Signed-off-by:
-
Jérémy Lefaure authored
Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Reviewed-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Signed-off-by:
-
Christian König authored
Otherwise somebody could try to evict it at the same time and try to use half torn down structures. Signed-off-by:
Michel Dänzer <michel.daenzer@amd.com> Reviewed-by:
-
Christian König authored
We don't use compound pages at the moment. Take this into account when freeing them. Signed-off-by:
Christian König <christian.koenig@amd.comd> Reviewed-and-Tested-by:
-
Alex Deucher authored
v2: vram -> VRAM in comment Reviewed-by:
-
Christian König authored
We only need to loop over all IBs for old UVD/VCE command stream patching. Signed-off-by:
-
Christian König authored
Move the trace before we signal the scheduler fence and drop the scheduler fence reference directly before we free the job. v2: keep extra s_fence reference Signed-off-by:
-
Harish Kasiviswanathan authored
Replace some commonly repeated code with a function. v2: Use amdgpu_find_mm_node() in amdgpu_ttm_io_mem_pfn() Signed-off-by:
Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com> Signed-off-by:
-
Harish Kasiviswanathan authored
Add more generic function amdgpu_copy_ttm_mem_to_mem() that supports arbitrary copy size, offsets and two BOs (source & dest.). This is useful for KFD Cross Memory Attach feature where data needs to be copied from BOs from different processes v2: Add struct amdgpu_copy_mem and changed amdgpu_copy_ttm_mem_to_mem() function parameters to use the struct v3: Minor function name change Signed-off-by:
-
Andrey Grodzovsky authored
In amdgpu_cs_parser_init() in case of error handling amdgpu_ctx_put() is called without setting p->ctx to NULL after that, later amdgpu_cs_parser_fini() also calls amdgpu_ctx_put() again and mess up the reference count. Signed-off-by:
Andrey Grodzovsky <Andrey.Grodzovsky@amd.com> Reviewed-by:
-
Tom St Denis authored
Signed-off-by:
-
Christian König authored
Allows userspace to figure out if VRAM was lost. Signed-off-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> Signed-off-by:
-
Christian König authored
And return from the wait functions the fence error code. Signed-off-by:
-
Christian König authored
Instead of per device track the VRAM lost per context and return ECANCELED instead of ENODEV. Signed-off-by:
-
Christian König authored
Instead of reading the current counter from fpriv. Signed-off-by:
-
Christian König authored
Keep blocking the CS, but revert everything else. Mapping BOs and info IOCTL are harmless and can still happen even when VRAM content ist lost. Signed-off-by:
-
Christian König authored
Add a new huge page pool and try to allocate from it when it makes sense. v2: avoid compound pages for now Signed-off-by:
-
Christian König authored
Make it easier to add huge page pool. Signed-off-by:
-
Christian König authored
Try to allocate huge pages when it makes sense. v2: avoid compound pages for now Signed-off-by:
Felix Kuehling <Felix.Kuehling@amd.com> Acked-by:
-
Christian König authored
We need to figure out first how to correctly map them into the CPU page tables. bug: https://bugs.freedesktop.org/show_bug.cgi?id=103138Signed-off-by:
-
Ken Wang authored
Old value from bringup was wrong. Cc: stable@vger.kernel.org Signed-off-by:
Ken Wang <Ken.Wang@amd.com> Reviewed-by:
-
Horace Chen authored
SR-IOV need to exchange some data between PF&VF through shared VRAM PF will copy some necessary firmware and information to the shared VRAM. It also requires some information from VF. PF will send a key through mailbox2 to help guest calculate checksum so that it can verify whether the data is correct. So check the data on the specified offset of the shared VRAM, if the checksum is right, read values from it and write some VF information next to the data from PF. Signed-off-by:
Horace Chen <horace.chen@amd.com> Reviewed-by:
-
