1. 02 Nov, 2005 7 commits
  2. 01 Nov, 2005 28 commits
  3. 31 Oct, 2005 5 commits
    • Andrea Arcangeli's avatar
      [PATCH] fix __writeback_single_inode WARN_ON · 659603ef
      Andrea Arcangeli authored
      When the inode count is zero in inode writeback, the
      
      	WARN_ON(!(inode->i_state & I_WILL_FREE));
      
      is broken, and needs to test for either I_WILL_FREE|I_FREEING.
      
      When the inode is in I_FREEING state, it's already out of the visibility
      of the vm so it can't be freed so it doesn't require the __iget and the
      generic_delete_inode path can call the sync internally to the lowlevel
      fs callback during the last iput. So the inode being in I_FREEING is
      also a valid condition for calling the sync with i_count == 0.
      
      The specific stack trace is this:
      
        0xc00000007b8fb6e0  0xc00000000010118c  .__writeback_single_inode +0x5c
        0xc00000007b8fb6e0  0xc0000000001014dc (lr) .sync_inode +0x3c
        0xc00000007b8fb790  0xc0000000001014dc  .sync_inode +0x3c
        0xc00000007b8fb820  0xc0000000001a5020  .ext2_sync_inode +0x64
        0xc00000007b8fb8f0  0xc0000000001a65b4  .ext2_truncate +0x3f8
        0xc00000007b8fba40  0xc0000000001a6940  .ext2_delete_inode +0xdc
        0xc00000007b8fbac0  0xc0000000000f7a5c  .generic_delete_inode +0x124
        0xc00000007b8fbb50  0xc0000000000f5fe0  .iput +0xb8
        0xc00000007b8fbbe0  0xc0000000000e9fd4  .sys_unlink +0x2a8
        0xc00000007b8fbd10  0xc00000000001048c  .ret_from_syscall_1 +0x0
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      659603ef
    • Andrew Morton's avatar
      [PATCH] revert ide-scsi highmem cleanup · a717f773
      Andrew Morton authored
      Jeff Garzik <jgarzik@pobox.com> points out that this was wrong: we need to
      disable local interrupts while holding KM_IRQ0 due to IRQ sharing.
      
      And holding interrupts off during a big PIO opration is expensive, so we only
      want to do that if we know the page was highmem.
      
      So revert commit 17fd47abSigned-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      a717f773
    • Herbert Xu's avatar
      [DCCP]: Simplify skb_set_owner_w semantics · 48918a4d
      Herbert Xu authored
        
      While we're at it let's reorganise the set_owner_w calls a little so that:
        
      1) dccp_transmit_skb sets the owner for all packets except data packets.
      2) Add dccp_skb_entail to set owner for packets queued for retransmission.
      3) Make dccp_transmit_skb static.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
      48918a4d
    • Yan Zheng's avatar
      [IPV6]: Fix behavior of ip6_route_input() for link local address · 9d17f218
      Yan Zheng authored
      I find that linux will reply echo request destined to an address which
      belongs to an interface other than the one from which the request received.
      This behavior doesn't make sense for link local address.
      
      YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> said:
      
      Please note that sender does need to setup neighbor entry by hand to reproduce
      this bug.  (Link-local address on eth1 is not visible on eth0, from the point
      of view of neighbor discovery in IPv6.)
      
       +--------+               +--------+
       | sender |               | router |
       +---+----+               +-+----+-+
           |eth0              eth0|    |eth1
      -----+----------------------+-  -+--------------
      Signed-off-by: default avatarYan Zheng <yanzheng@21cn.com>
      Acked-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
      Signed-off-by: Andrew Morton <akpm@osdl.org> (forwarded)
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
      9d17f218
    • Andrew Morton's avatar
      [ROSE]: rose_heartbeat_expiry() locking fix · a3d7a9d7
      Andrew Morton authored
      Missing unlock, as noted by Ted Unangst <tedu@coverity.com>.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
      a3d7a9d7