- 25 Oct, 2019 17 commits
-
-
Jamal Shareef authored
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan. The semantic patch that makes this report is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/Signed-off-by:
Jamal Shareef <jamal.k.shareef@gmail.com> Link: https://lore.kernel.org/r/20191024223937.2800-1-jamal.k.shareef@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
YueHaibing authored
drivers/staging/comedi/drivers/ni_routes.c:52:21: warning: route_table_size defined but not used [-Wunused-const-variable=] It is never used since introduction. Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/20191023075206.33088-1-yuehaibing@huawei.comSigned-off-by:
-
Valdis Kletnieks authored
Convert FFS_MEMORYERR to -ENOMEM Signed-off-by:
Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Link: https://lore.kernel.org/r/20191024155327.1095907-9-Valdis.Kletnieks@vt.eduSigned-off-by:
-
Valdis Kletnieks authored
Convert FFS_INVALIDPATH to -EINVAL Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_FILEEXIST to -EEXIST Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_NOTNAMETOOLONG to -ENAMETOOLONG Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_PERMISSIONERR to -EPERM Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_DIRBUSY to -EBUSY Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_NOTFOUND to -ENOENT Signed-off-by:
-
Valdis Kletnieks authored
Start cleaning up the odd scheme of return codes, starting with FFS_FULL Signed-off-by:
-
Sudip Mukherjee authored
The build of xtensa allmodconfig gives warning of: In function 'cfg80211_rtw_scan': warning: the frame size of 1040 bytes is larger than 1024 bytes Allocate memory for ssid dynamically to reduce the stack usage, as an added benifit we can remove the memset by using kzalloc while allocating memory. Signed-off-by:
Sudip Mukherjee <sudipm.mukherjee@gmail.com> Link: https://lore.kernel.org/r/20191018101854.31876-1-sudipm.mukherjee@gmail.comSigned-off-by:
-
Sudip Mukherjee authored
The build of xtensa allmodconfig gives warning of: In function 'rtw_cfg80211_unlink_bss': warning: the frame size of 1136 bytes is larger than 1024 bytes Instead of having 'select_network' structure as a variable use it as a pointer. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20191018104837.23246-1-sudipm.mukherjee@gmail.comSigned-off-by:
-
Aliasgar Surti authored
There is use of if..elseif..else condition which has same logic in all three blocks. Removed if..else block and placed log message instead that. Signed-off-by:
Aliasgar Surti <aliasgar.surti500@gmail.com> Reviewed-by:
-
Alexandru Ardelean authored
The `rtl8188eu` driver is built as a kmod in order to avoid symbol conflicts (at link-time) with other Realtek drivers. Internally, we use this driver as builtin [vs kmod], and we've identified the `efuse_power_switch()` symbol to be conflicting at link-time with the one from the `rtlwifi` driver. An alternative solution would have been to rename the function, but it doesn't look like it's being used outside of this driver, so just make it static. Signed-off-by:
Alexandru Ardelean <alexandru.ardelean@analog.com> Link: https://lore.kernel.org/r/20191016065834.12186-1-alexandru.ardelean@analog.comSigned-off-by:
-
YueHaibing authored
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by:
-
YueHaibing authored
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by:
-
YueHaibing authored
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by:
-
- 15 Oct, 2019 7 commits
-
-
Jamal Shareef authored
Fix lines over 80 character warnings. Issue found by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove blank lines to reduce whitespace and improve readability. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20191015154535.27979-3-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Convert the local variables max_ampdu_len and min_mpdu_spacing from unsigned char to u8 and remove unnecessary castings to u8 pointer. Signed-off-by:
-
Michael Straube authored
Rename local variables to avoid mixed case. max_AMPDU_len -> max_ampdu_len min_MPDU_spacing -> min_mpdu_spacing Signed-off-by:
-
Wambui Karuga authored
Add cast to fix the following sparse warning: warning: restricted __be16 degrades to integer Signed-off-by:
Wambui Karuga <wambui.karugax@gmail.com> Link: https://lore.kernel.org/r/20191015084731.8514-1-wambui.karugax@gmail.comSigned-off-by:
-
Wambui Karuga authored
Remove unnecessary casts in pointer types passed to kfree. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Link: https://lore.kernel.org/r/20191015112637.20824-1-wambui.karugax@gmail.comSigned-off-by:
-
YueHaibing authored
Null check before kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by:
-
- 14 Oct, 2019 14 commits
-
-
Jérôme Pouiller authored
array_index_nospec() should be applied after a bound check. Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames") Reported-by:
kbuild test robot <lkp@intel.com> Reported-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20191011164746.2518-1-Jerome.Pouiller@silabs.comSigned-off-by:
-
Jérôme Pouiller authored
Since wfx_tx_get_raw_link_id() return an unsigned, it makes no sense to return a negative value. "15" is a better value since it is used by firmware for stations that have not yet associated link-ids. Note that this should never happens since driver set max_ap_assoc_sta to 14. Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames") Reported-by:
-
Wambui Karuga authored
Use the DIV_ROUND_UP macro to replace open-coded divisor calculation to improve readability. Issue found using coccinelle: @@ expression n,d; @@ ( - ((n + d - 1) / d) + DIV_ROUND_UP(n,d) | - ((n + (d - 1)) / d) + DIV_ROUND_UP(n,d) ) Signed-off-by:
-
Wambui Karuga authored
Replace open-coded division calculation with the DIV_ROUND_UP helper macro for better readability. Issue found using coccinelle: @@ expression n,d; @@ ( - ((n + d - 1) / d) + DIV_ROUND_UP(n,d) | - ((n + (d - 1)) / d) + DIV_ROUND_UP(n,d) ) Signed-off-by:
-
Michael Straube authored
Comparsions evaluate to bool, explicit conversion with ternary operator is overly verbose and unnecessary, so remove it. Signed-off-by:
-
Michael Straube authored
Remove braces from single statement if block to comply with kernel coding style. Reported by checkpatch. Signed-off-by:
-
Wambui Karuga authored
Remove unnecessary line-breaks in function headers to improve readability of function headers. Signed-off-by:
-
Wambui Karuga authored
Remove variables that are only used to hold and return constants and have the functions directly return the constants. Issue found by coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: -
Wambui Karuga authored
Remove addition of new typedef for enum cvmx_fau_op_size. Issue found by checkpatch.pl Signed-off-by:
-
Wambui Karuga authored
Removes addition of new typedef declaration for cvmx_pko_command_word0. Also replace previous instances with new union declaration. Signed-off-by:
-
Wambui Karuga authored
Remove typedef declaration for enum cvmx_fau_reg_32. Also replace its previous uses with new declaration format. Issue found by checkpatch.pl Signed-off-by:
-
Wambui Karuga authored
Remove declaration of union cvmx_helper_link_info as typedef. Also replace its previous uses with new union declaration. Issue found by checkpatch.pl Signed-off-by:
-
Wambui Karuga authored
Remove typedef declaration from struct cvmx_wqe. Also replace its previous uses with new struct declaration. Issue found by checkpatch.pl Signed-off-by:
-
Greg Kroah-Hartman authored
We want the staging driver fixes in here as well to build on and test with. Signed-off-by:
-
- 13 Oct, 2019 2 commits
-
-
Linus Torvalds authored
-
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-traceLinus Torvalds authored
Pull tracing fixes from Steven Rostedt: "A few tracing fixes: - Remove lockdown from tracefs itself and moved it to the trace directory. Have the open functions there do the lockdown checks. - Fix a few races with opening an instance file and the instance being deleted (Discovered during the lockdown updates). Kept separate from the clean up code such that they can be backported to stable easier. - Clean up and consolidated the checks done when opening a trace file, as there were multiple checks that need to be done, and it did not make sense having them done in each open instance. - Fix a regression in the record mcount code. - Small hw_lat detector tracer fixes. - A trace_pipe read fix due to not initializing trace_seq" * tag 'trace-v5.4-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: tracing: Initialize iter->seq after zeroing in tracing_read_pipe() tracing/hwlat: Don't ignore outer-loop duration when calculating max_latency tracing/hwlat: Report total time spent in all NMIs during the sample recordmcount: Fix nop_mcount() function tracing: Do not create tracefs files if tracefs lockdown is in effect tracing: Add locked_down checks to the open calls of files created for tracefs tracing: Add tracing_check_open_get_tr() tracing: Have trace events system open call tracing_open_generic_tr() tracing: Get trace_array reference for available_tracers files ftrace: Get a reference counter for the trace_array on filter files tracefs: Revert ccbd54ff ("tracefs: Restrict tracefs when the kernel is locked down")
-
