1. 29 Jan, 2009 5 commits
    • Steve French's avatar
      [CIFS] Make socket retry timeouts consistent between blocking and nonblocking cases · da505c38
      Steve French authored
      We have used approximately 15 second timeouts on nonblocking sends in the past, and
      also 15 second SMB timeout (waiting for server responses, for most request types).
      Now that we can do blocking tcp sends,
      make blocking send timeout approximately the same (15 seconds).
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      da505c38
    • Steve French's avatar
    • Steve French's avatar
      [CIFS] revalidate parent inode when rmdir done within that directory · 42c24544
      Steve French authored
      When a search is pending of a parent directory, and a child directory
      within it is removed, we need to reset the parent directory's time
      so that we don't reuse the (now stale) search results.
      
      Thanks to Gunter Kukkukk for reporting this:
      
      > got the following failure notification on irc #samba:
      >
      > A user was updating from subversion 1.4 to 1.5, where the
      > repository is located on a samba share (independent of
      > unix extensions = Yes or No).
      > svn 1.4 did work, 1.5 does not.
      >
      > The user did a lot of stracing of subversion - and wrote a
      > testapplet to simulate the failing behaviour.
      > I've converted the C++ source to C and added some error cases.
      >
      > When using "./testdir" on a local file system, "result2"
      > is always (nil) as expected - cifs vfs behaves different here!
      >
      >   ./testdir /mnt/cifs/mounted/share
      >
      > returns a (failing) valid pointer.
      Acked-by: default avatarDave Kleikamp <shaggy@us.ibm.com>
      Acked-by: default avatarJeff Layton <jlayton@redhat.com>
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      42c24544
    • Steve French's avatar
      [CIFS] Rename md5 functions to avoid collision with new rt modules · 6a7f8d36
      Steve French authored
      When rt modules were added they (each) included their own md5
      with names which collided with the existing names of cifs's md5 functions.
      
      Renaming cifs's md5 modules so we don't collide with them.
      
      > Stephen Rothwell wrote:
      > When CIFS is built-in (=y) and staging/rt28[67]0 =y, there are multiple
      > definitions of:
      >
      > build-r8250.out:(.text+0x1d8ad0): multiple definition of `MD5Init'
      > build-r8250.out:(.text+0x1dbb30): multiple definition of `MD5Update'
      > build-r8250.out:(.text+0x1db9b0): multiple definition of `MD5Final'
      >
      > all of which need to have more unique identifiers for their global
      > symbols (e.g., rt28_md5_init, cifs_md5_init, foo, blah, bar).
      >
      
      CC: Greg K-H <gregkh@suse.de>
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      6a7f8d36
    • Jeff Layton's avatar
      cifs: turn smb_send into a wrapper around smb_sendv · 0496e02d
      Jeff Layton authored
      cifs: turn smb_send into a wrapper around smb_sendv
      
      Rename smb_send2 to smb_sendv to make it consistent with kernel naming
      conventions for functions that take a vector.
      
      There's no need to have 2 functions to handle sending SMB calls. Turn
      smb_send into a wrapper around smb_sendv. This also allows us to
      properly mark the socket as needing to be reconnected when there's a
      partial send from smb_send.
      
      Also, in practice we always use the address and noblocksnd flag
      that's attached to the TCP_Server_Info. There's no need to pass
      them in as separate args to smb_sendv.
      Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
      Acked-by: default avatarDave Kleikamp <shaggy@linux.vnet.ibm.com>
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      0496e02d
  2. 28 Jan, 2009 35 commits