- 14 Jul, 2004 14 commits
-
-
Alexander Viro authored
(no, it still doesn't fix sparc32-smp - just partial compile fixes ;-/)
-
Alexander Viro authored
We have a fun situation with read_descriptor_t - all its instances end up passed to some actor; these actors use desc->buf as their private data; there are 5 of them and they expect resp: struct lo_read_data * struct svc_rqst * struct file * struct rpc_xprt * char __user * IOW, there is no type safety whatsoever; the field is essentially untyped, we rely on the fact that actor is chosen by the same code that sets ->buf and expect it to put something of the right type there. Right now desc->buf is declared as char __user *. Moreover, the last argument of ->sendfile() (what should be stored in ->buf) is void __user *, even though it's actually _never_ a userland pointer. If nothing else, ->sendfile() should take void * instead; that alone removes a bunch of bogus warnings. I went further and replaced desc->buf with a union of void * and char __user *.
-
Bjorn Helgaas authored
Rename PCDP_TABLE_GUID back to HCDP_TABLE_GUID to get the file to compile again. This change is against current 2.6 BK and is under CONFIG_IA64_EARLY_PRINTK_UART. Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
The patch below (applies against both 2.4 and 2.6) removes the bouncing email address from all files and removes the outdated MAINTAINERS entry. Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Michael Hunold authored
In two of my i2c helper drivers the return value of i2c_add_driver() is ignored. Thanks to Arthur Othieno for finding these bugs. Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch> Signed-off-by: Michael Hunold <hunold@linuxtv.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Michael Hunold authored
From: Colin Leroy <colin@colino.net> This patch fixes a compilation error on 2.6.8-rc1. Here's the error: drivers/media/common/saa7146_video.c:3: conflicting types for `memory' include/asm-m68k/setup.h:365: previous declaration of `memory' make[3]: *** [drivers/media/common/saa7146_video.o] Error 1 Signed-off-by: Colin Leroy <colin@colino.net> Signed-off-by: Michael Hunold <hunold@linuxtv.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Hirofumi Ogawa authored
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Andrew Morton authored
Only two architectures implement it, so afs broke the build. Remove struct_cpy() altogether, and use structure assignments. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Pawel Sikora authored
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
From: Kam Leo <A1tmblwd@netscape.net> Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
Insert header guards to allow possible multiple inclusion for include/linux/percpu_counter.h and include/linux/blockgroup_lock.h Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Christoph Hellwig authored
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Petri T. Koistinen authored
This patch will fix 3Com "Vortex" and "Boomerang" ethernet driver sparse warnings about using plain integer as NULL pointer. Signed-off-by: Petri T. Koistinen <petri.koistinen@iki.fi> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
David Eger authored
pmac_zilog: initialize the serial ports' spinlocks even if console over serial is not enabled; disable this driver by default for ppc This lock not being initialized was Oopsing my TiBook :-P Signed-off-by: David Eger <eger@havoc.gtf.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
- 13 Jul, 2004 26 commits
-
-
Linus Torvalds authored
Al's last changes mean that it is now annotated as a user pointer, and we want to avoid warnings.
-
Alexander Viro authored
access_ok() expects a pointer, not unsigned long. It's not a problem on platforms that have this guy done as a macro (or ones that do not use fs/compat.c at all), but that's still wrong and on some platforms that care we actually have access_ok() as inlined function. Bogus cast removed.
-
Alexander Viro authored
__vfs_follow_link() really should be inline; that's a special case since we are in the middle of recursion and really want to conserve stack space. Moved before the first use, made inline again.
-
Alexander Viro authored
(partially based on patch from Mika Kukkonen)
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
Dumb Typo(tm) - the first bug caught by 0/NULL checks (arg is really a kernel pointer there, so memset() is actually OK - results will be copied to userland by caller. Or would be, if we would not oops ;-)
-
Alexander Viro authored
ipc compat code switched to compat_alloc_user_space() and annotated.
-
Alexander Viro authored
-
Alexander Viro authored
ss_sp in struct sigaltstack made __user ->si_addr and ->sival_ptr made __user your ->sa_restorer and ->sa_handler changes propagated users of these guys annotated on i386/amd64/alpha/sparc/sparc64
-
Alexander Viro authored
Missing bits of cpumask_t conversion
-
Alexander Viro authored
* added usual CHECK assignment in Makefile * switched uaccess.h to __check_uptr() * added L on long constants (ones missed earlier) * added __user in osf_sys.c (duh - I've added __user to cast in the initializer, but forgot to add it in declaration)
-
Alexander Viro authored
-
Alexander Viro authored
-
Alexander Viro authored
a) vfc is not 64bit-clean, marked as such in Kconfig b) aurora is simply broken - still uses tqueues. Marked as broken. c) vfc does dereferencing of userland pointer, right after having carefully copied the data to kernel space ;-) Fixed. d) vfc ->mmap() had missed prototype change. Fixed. e) BPP ioctls are misdeclared - they should've been _IO(...) instead of _IOR(..., void). Too late to fix, but we can at least make them _IOR(..., char) - same value, but doesn't try to find sizeof(void).
-
Alexander Viro authored
-
Alexander Viro authored
tms380tr is used both by ISA and PCI drivers. Enabling/disabling DMA is done only for ISA ones (it's protected by if (dev->dma > 0) and PCI ones leave it 0), but it's compiled unconditionally. Which breaks on platforms that don't have that ISA crap at all, but support PCI just fine. Code in question placed under ifdef CONFIG_ISA.
-
Alexander Viro authored
bitrot strikes again...
-
Alexander Viro authored
direct write to userland pointer.
-
Alexander Viro authored
Division by zero is an ugly thing... We are safe wrt overflows, since the maximal value we ever pass is 10000 - not enough to overflow unless you've got a platform with HZ > 200000.
-
Alexander Viro authored
usb ioctls in compat_ioctl.c switched to compat_alloc_user_space() and cleaned up; ioctl structures annotated.
-
Alexander Viro authored
In handling of VIDIOCSWIN for 32bit on 64bit platforms: * switched to compat_alloc_user_space() * fixed memory corruption in copying arguments from userland * fixed arithmetic overflows * added missing checks for get_user() results and corresponding returns with -EFAULT.
-
Alexander Viro authored
- afs and rxrpc switched to kvec; definition of kvec moved to uio.h (duh). - afs/mntpt.c got missing cast added. at that point afs is sparse-clean and rxrpc has only one remaining warning (setsockopt from local variable, protected by set_fs()).
-