- 18 Dec, 2017 40 commits
-
-
Jia-Ju Bai authored
The driver may sleep under a spinlock. The function call path is: bdisp_device_run (acquire the spinlock) bdisp_hw_update bdisp_hw_save_request devm_kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by:Jia-Ju Bai <baijiaju1990@gmail.com> Reviewed-by:
Fabien Dessenne <fabien.dessenne@st.com> Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@s-opensource.com>
-
Stanimir Varbanov authored
Currently videobuf2-dma-sg checks for dma direction for every single page and videobuf2-dc lacks any dma direction checks and calls set_page_dirty_lock unconditionally. Thus unify and align the invocations of set_page_dirty_lock for videobuf2-dc, videobuf2-sg memory allocators with videobuf2-vmalloc, i.e. the pattern used in vmalloc has been copied to dc and dma-sg. Suggested-by:
Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:
Stanimir Varbanov <stanimir.varbanov@linaro.org> Acked-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Hans Verkuil authored
The pvrusb2 code appears to have a some old workaround code for xawtv that causes a WARN() due to an unrecognized pixelformat 0 in v4l2_ioctl.c. Since all other MPEG drivers fill this in correctly, it is a safe assumption that this particular problem no longer exists. While I'm at it, clean up the code a bit. Signed-off-by:
-
Philipp Zabel authored
V4L2_BUF_FLAG_LAST is a signal from the driver to userspace for buffers on the capture queue. When userspace queues back a capture buffer with the flag set, we should clear it. Otherwise, if userspace restarts streaming after EOS, without reallocating the buffers, mem2mem devices will erroneously signal EOS prematurely, as soon as the already flagged buffer is dequeued. Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
-
Philipp Zabel authored
The mvcol buffer needs to be placed behind the chroma plane(s) when decoding MPEG-4, same as for the h.264 decoder. Use the real offset with the required rounding. Signed-off-by:
-
Philipp Zabel authored
The MPEG-4 decoder mvcol buffer was registered, but its size not added to a frame buffer allocation. This could cause the decoder to write past the end of the allocated buffer for large frame sizes. Signed-off-by:
-
Philipp Zabel authored
We need internal frames to be rounded up to full macroblocks for MPEG-4 decoding as well. Signed-off-by:
-
Philipp Zabel authored
Since bytesperline always fulfills VDOA width requirements, detile the whole buffer instead of limiting to visible width. This stops TRY_FMT from returning -EINVAL for YUYV capture buffers that are not a multiple of 16 wide. An alternative would be to always round up width to stride, as we report the valid image rectange via G_SELECTION (V4L2_SEL_TGT_COMPOSE_DEFAULT), but that would require all applications to handle the compose default rectangle properly. Signed-off-by:
-
Lucas Stach authored
The current driver implementation expects at least one buffer on all queues to start streaming. Properly signal this to the vb2 core, to avoid confusion when streamon is racing with qbuf. Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Signed-off-by:
-
Flavio Ceolin authored
pxa_camera_probe() was not calling pxa_camera_deactivate(), responsible to call clk_disable_unprepare(), on the failure path. This was leading to unbalancing source clock. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Jacopo Mondi authored
videobuf2 core reports an error when not all buffers have been returned to the framework: drivers/media/v4l2-core/videobuf2-core.c:1651 WARN_ON(atomic_read(&q->owned_by_drv_count)) Fix this returning all buffers currently in capture queue. Signed-off-by:
Jacopo Mondi <jacopo+renesas@jmondi.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
When we split VB2 into an independent streaming module and a V4L2 one, some vb2-core functions started to have a wrong description: they're meant to be used only by the API-specific parts of VB2, like vb2-v4l2, as the functions that V4L2 drivers should use are all under videobuf2-v4l2.h. Correct their descriptions. Acked-by:
-
Mauro Carvalho Chehab authored
As kernel-doc doesn't support documenting #define values, and using enum makes easier to identify where the values are used, convert V4L2_MBUS_FRAME_DESC_FL_* to enum, and use BIT() macro. While here, fix the description at v4l2_mbus_frame_desc_entry, in order to match what's described for V4L2_MBUS_FRAME_DESC_FL_LEN_MAX. Signed-off-by: -
Mauro Carvalho Chehab authored
Convert V4L2_SUBDEV_IO_PIN_* to enums, use BIT() and document via kernel-doc. Signed-off-by: -
Mauro Carvalho Chehab authored
ownner -> owner Acked-by:
-
Mauro Carvalho Chehab authored
Despite the struct says "color16", it was actually using 32 bits for each color. Fix it. Suggested-by:
Hans Verkuil <hverkuil@xs4all.nl> Acked-by:
-
Mauro Carvalho Chehab authored
The color structs right now are just "color" and "color16". That may lead into conflicts, and don't define precisely what they meant. As those are used by two drivers (vivid and vimc), this is even on a somewhat public header! So rename them to: color -> tpg_rbg_color8 color16 -> tpg_rbg_color16 Acked-by:
-
Mauro Carvalho Chehab authored
The v4l2-tpg*.h headers are meant to be used only internally by vivid and vimc. There's no sense keeping them together with the V4L2 kAPI headers. Also, one header includes the other as they're meant to be used together. So, merge them. Acked-by:
-
Mauro Carvalho Chehab authored
Add cross-references where needed and add periods at the end of each kernel-doc paragraph, in order to make it coherent with other VB2 descriptions. Acked-by:
-
Mauro Carvalho Chehab authored
There are several VB2 core functions that aren't documented. Signed-off-by: -
Mauro Carvalho Chehab authored
There are several issues on the current markups: - lack of cross-references; - wrong cross-references; - lack of a period of the end of several phrases; - Some descriptions can be enhanced. Signed-off-by: -
Mauro Carvalho Chehab authored
Use the existing macros to identify vb2_io_modes bits. Acked-by:
-
Mauro Carvalho Chehab authored
The description there is completely broken and it mentions an ioctl that doesn't exist. Fix it. Signed-off-by: -
Mauro Carvalho Chehab authored
When generating Sphinx output, create cross-references for the callbacks for each ioctl. While here, fix a few wrong names for ioctls. Signed-off-by: -
Mauro Carvalho Chehab authored
Convert #defines to enums and add kernel-doc markups for V4L2 video_device flags. Acked-by:
-
Mauro Carvalho Chehab authored
The V4L_DIR_* direction flags document the direction for a V4L2 device node. Convert them to enum and document. Acked-by:
-
Mauro Carvalho Chehab authored
In the past, the same I2C address were used on multiple places. After I2C rebinding changes, this is no longer needed. So, we can just get rid of this header, placing the I2C address where they belong, e. g. either at bttv driver or at tvtuner. Acked-by:
-
Mauro Carvalho Chehab authored
Some of the previously used I2C addresses there aren't used anymore. So, get rid of them. Acked-by:
-
Mauro Carvalho Chehab authored
Using enums makes easier to document, as it can use kernel-doc markups. It also allows cross-referencing, with increases the kAPI readability. Please notice that now cx88_querycap() has to have a default for the VFL type, as there are more types than supported by the driver. Acked-By:
Mike Isely <isely@pobox.com> Acked-by:
-
Mauro Carvalho Chehab authored
Instead of using (1 << n) for bits, use the BIT() macro, as it makes a difference from documentation point of view. Acked-by:
-
Mauro Carvalho Chehab authored
There are two helper functions at v4l2-flash-led-class.h that aren't documented. Document them. Acked-by:
-
Mauro Carvalho Chehab authored
There are two macros at v4l2-dev.h that aren't documented. Document them, for completeness. Acked-by:
-
Mauro Carvalho Chehab authored
Both v4l2-event.rst and v4l2-event.h have an overview of events, but there are some inconsistencies there: - at v4l2-event, the event's ring buffer is called kevent. Its name is, instead, v4l2_kevent; - Some things are mentioned on both places (with different words), others are either on one of the files. In order to cleanup this mess, put everything at v4l2-event.rst and improve it to be a little more coherent and to have cross references. Acked-by:
-
Mauro Carvalho Chehab authored
Now that nested structs are parsed by kernel-doc, add markups to them. Acked-by:
-
Mauro Carvalho Chehab authored
Now that nested structs are supported, change the documentation to use it. While here, add cross-references where pertinent and use monotonic fonts where pertinent, using the right markup tags. Acked-by:
-
Mauro Carvalho Chehab authored
There are a few nested members at v4l2-ctrls.h. Now that kernel-doc supports, document them. Acked-by:
-
Mauro Carvalho Chehab authored
Better document the bus union at struct v4l2_fwnode_endpoint. Acked-by:
-
Mauro Carvalho Chehab authored
The description of this enum doesn't match what it actually represents. Adjust it. Acked-by:
-
Mauro Carvalho Chehab authored
The RC core does several assumptions, but those aren't documented anywhere, with could make harder for ones that want to understand what's there. So, add an introduction explaining the basic concepts of RC and how they're related to the RC core implementation. Acked-by:
Sean Young <sean@mess.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
The can_reduce_fps() is already documented, but it is not using the kernel-doc markup. Convert it, in order to generate documentation from it. Acked-by:
-
