1. 06 Mar, 2010 2 commits
    • J. Bruce Fields's avatar
      nfsd4: simplify lease/grace interaction · e46b498c
      J. Bruce Fields authored
      The original code here assumed we'd allow the user to change the lease
      any time, but only allow the change to take effect on restart.  Since
      then we modified the code to allow setting the lease on when the server
      is down.  Update the rest of the code to reflect that fact, clarify
      variable names, and add document.
      
      Also, the code insisted that the grace period always be the longer of
      the old and new lease periods, but that's overly conservative--as long
      as it lasts at least the old lease period, old clients should still know
      to recover in time.
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      e46b498c
    • J. Bruce Fields's avatar
      nfsd4: simplify references to nfsd4 lease time · cf07d2ea
      J. Bruce Fields authored
      Instead of accessing the lease time directly, some users call
      nfs4_lease_time(), and some a macro, NFSD_LEASE_TIME, defined as
      nfs4_lease_time().  Neither layer of indirection serves any purpose.
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      cf07d2ea
  2. 04 Mar, 2010 1 commit
  3. 03 Mar, 2010 1 commit
  4. 02 Mar, 2010 1 commit
  5. 01 Mar, 2010 1 commit
    • Neil Brown's avatar
      nfsd: ensure sockets are closed on error · 301e99ce
      Neil Brown authored
      One the changes in commit d7979ae4 "svc: Move close processing to a
      single place" is:
      
        err_delete:
      -       svc_delete_socket(svsk);
      +       set_bit(SK_CLOSE, &svsk->sk_flags);
              return -EAGAIN;
      
      This is insufficient. The recvfrom methods must always call
      svc_xprt_received on completion so that the socket gets re-queued if
      there is any more work to do.  This particular path did not make that
      call because it actually destroyed the svsk, making requeue pointless.
      When the svc_delete_socket was change to just set a bit, we should have
      added a call to svc_xprt_received,
      
      This is the problem that b0401d72 attempted to fix, incorrectly.
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      301e99ce
  6. 28 Feb, 2010 2 commits
  7. 26 Feb, 2010 2 commits
    • Neil Brown's avatar
      sunrpc: remove unnecessary svc_xprt_put · ab1b18f7
      Neil Brown authored
      The 'struct svc_deferred_req's on the xpt_deferred queue do not
      own a reference to the owning xprt.  This is seen in svc_revisit
      which is where things are added to this queue.  dr->xprt is set to
      NULL and the reference to the xprt it put.
      
      So when this list is cleaned up in svc_delete_xprt, we mustn't
      put the reference.
      
      Also, replace the 'for' with a 'while' which is arguably
      simpler and more likely to compile efficiently.
      
      Cc: Tom Tucker <tom@opengridcomputing.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      Cc: stable@kernel.org
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      ab1b18f7
    • Alex Elder's avatar
      Merge branch 'linux-2.6.33' · 398007f8
      Alex Elder authored
      398007f8
  8. 25 Feb, 2010 1 commit
  9. 24 Feb, 2010 13 commits
  10. 23 Feb, 2010 16 commits