An error occurred fetching the project authors.
- 09 Dec, 2003 2 commits
-
-
Alan Stern authored
On Sun, 30 Nov 2003, Matthew Dharm wrote: > I'm going to pass this one along to Greg, but I think some places in this > could really use some better comments. Especially the way you use a single > buffer inside the loop -- it took me a few minutes to figure out how your > logic to refresh the buffer with new data worked. > > I'm also wondering if the access_xfer_buf() function could use some more > header comments, stating why this is needed (i.e. spelling out the > kmap()-isms). Okay, here it is. This patch basically just adds comments. Each routine that uses the new scatter-gather function gets a brief explanation of what's going on, and access_xfer_buf() itself gets detailed comments saying what it's doing and why it's necessary. You may even want to cut some of it back; I was pretty verbose.
-
Alan Stern authored
This patch adds a small utility routine for storing data in a transfer buffer. The next patch uses this routine quite a bit in the isd200 driver.
-
- 08 Dec, 2003 1 commit
-
-
Alan Stern authored
This patch adds a routine to protocol.c that correctly transfers data to or from a scatter-gather buffer. According to Jens Axboe, we've been using page_address() incorrectly -- it's necessary to use kmap() instead -- and in fact it doesn't give the desired result when the buffers are located in high memory. This could affect anyone using a system with 1 GB or more of RAM, and one user has already reported such a problem (as you know). The three fixup routines in protocol.c and usb.c have been changed to use the new s-g access routine. When similar adjustments have been made to all the subdrivers, we will be able to eliminate the raw_bulk.c source file entirely.
-
- 14 Jul, 2003 1 commit
-
-
Matthew Dharm authored
This patch removes all of the mode-translation logic. It's no longer needed, as the upper-level drivers now all issue the proper 10-byte commands. This is a large patch, but what it's doing is removing a great deal of unneeded code -- about 650+ lines removed, according to diffstat. Those of you who are having some trouble getting your DVD-RAMs detected properly should have all your problems solved by an upcoming patch from the SCSI folks. It may look like that problem is related to this patch, but it isn't -- it's a side-effect of another SCSI patch to consolidate code. Special thanks to James Bottomley for being patient enough to work with me on these issues on the SCSI layer. This, BTW, makes US_FL_MODE_XLATE a NOP. The symbol is kept for the purpose of allowing unusual_devs.h to be consistent between 2.4 and 2.5 There are still a few places where more code could (potentially) be removed. I need to mull over the UFI specification to be sure, tho.
-
- 16 Jun, 2003 1 commit
-
-
Matthew Dharm authored
This patch will avoid a NULL-pointer dereference OOPS which is caused by oddly-formed (yet legal) INQUIRY commands that request 0 bytes.
-
- 01 Jun, 2003 1 commit
-
-
Matthew Dharm authored
This patch changes to SAM_STAT_ result codes, which is (a) preferred, according to the code comments, and (b) removes some odd-looking bit-shifting.
-
- 16 Sep, 2002 1 commit
-
-
Matthew Dharm authored
This patch converts all uses of page_addres() to the sg_address() macro. This will make backporting to 2.4 easier, as well as eliminate lots of redundant code.
-
- 04 Sep, 2002 1 commit
-
-
Andries E. Brouwer authored
I have a USB 5-in-1 Card Reader, that will read CF and SM and SD/MMC. Under Linux it appears as three SCSI devices. For today, the report is on the CF part. The CF part works fine under ordinary usb-storage SCSI simulation, with one small problem: 8 and 32 MB cards, that are detected as having 15872 and 63488 sectors by other readers, are detected as having 15873 and 63489 sectors by this Feiya reader (0x090c / 0x1132). In the good old days probably nobody would have noticed, but these days the partition reading code also wants to read the last sector. This results in the SCSI code taking the device off line: [USB storage does a READ_10, which fails since the sector is past the end of the disk. Then it tries a READ_6 and nothing ever happens, probably because the device does not support READ_6. Then the error handler does an abort which triggers some bugs in scsiglue.c and transport.c, then the error handler does a device reset, then a host reset, then a bus reset, and finally the device is taken offline.] The patch below does not address any bugs in the SCSI error code (a big improvement would be just to rip it all out - this error code never achieves anything useful but has crashed many a machine) and does not fix the USB code either. It just adds a flag to the unusual_devices section mentioning that this device (my revision is 1.00) has this bug. Without the patch the kernel crashes, or insmod usb-storage hangs. With the patch the CF part of the device works perfectly. (Another change is to only print "Fixing INQUIRY data" when really something is changed, not when the data was OK already.) Andries
-
- 11 May, 2002 1 commit
-
-
Greg Kroah-Hartman authored
sync up with both the -dj and cvs version of the usb-storage code.
-
- 05 Apr, 2002 1 commit
-
-
Greg Kroah-Hartman authored
moved class/storage/ back to storage/ created input/ orderd the makefiles and config.in menus better.
-
- 04 Apr, 2002 1 commit
-
-
Greg Kroah-Hartman authored
moved files to different subdirectories to make try to make sense of the current mess, and to allow usb client drivers to integrate into the tree easier.
-
- 06 Feb, 2002 1 commit
-
-
Jens Axboe authored
-
- 05 Feb, 2002 3 commits
-
-
Linus Torvalds authored
- David Howells: abtract out "current->need_resched" as "need_resched()" - Frank Davis: ide-tape update for bio - various: header file fixups - Jens Axboe: fix up bio/ide/highmem issues - Kai Germaschewski: ISDN update - Tim Waugh: parport update - Patrik Mochel: initcall update - Greg KH: USB and Compaq PCI hotplug updates
-
Linus Torvalds authored
- Ben Collins: 1394 updates - Matthew Dharm: USB storage update - Ion Badulescu: starfire driver update - VM aging cleanups
-
Linus Torvalds authored
-