Remove useless NULL checks and magic numbers from PCI Express Hotplug, also
some minimal coding style fixes.

Doesn't anyone build their patches anymore before sending them out...

Fix missing braces. It does not change the code but makes it easier to read.

This converts PCI Express Hotplug to the new style of module parameter
handling.

Walking through a pci_resource list and freeing all members is done a lot of
times in unload functions. This patch moves this to an inline function in
pciehp_core.c, pciehp_pci.c, shpchp_core.c and shpchp_pci.c. This shrinks the
code a lot (some 200 lines) and makes it much easier to read. Also adds some
__exit.

Convert PCI Hotplug Core to new style of module parameter handling.

Add missing braces around if statement, if not we will try to add devices
for an empty slot.

This patch removes the cast of kmalloc's results to the target pointer type.
Also it fixes kmalloc to use sizeof(*foo) instead of sizeof(type_of_foo) as
suggested by Matthew Wilcox. Also removes a few useless checks if a pointer
is NULL before calling kfree: kfree checks this itself.

Final small fixes for cpqphp_core.c:
-use better error handling in one_time_init
-small coding style fixes
-the name of the driver is not "pci_hotplug"
-add an __exit for unload_cpqphp
-changes enough to increment version, isn't it?

Some coding style fixes I missed last time.

Change cpqphp_ctrl.c to use goto for error handling.

This is not C++! Fix comments from C++ style to C style, removing some useless
ones (e.g. no need to tell up and down protect a critical section).

Remove some useless NULL checks in cpqphp_core.c

Convert ctrl_slot_setup to use goto for error handling and fix some minor
coding style things.

This puts the LED shifting used as "hardware test" in a function to make
cpqhp_hardware_test much smaller and easier to read. Also changes some
comments from C++ to C style.

Fix a lot of coding style issues in Compaq PCI hotplug:
-spaces before opening brace of functions
-much too much C++ style comments
-wrap long lines
-remove some comments where the code does not really need to be explained

Eike

Convert Compaq PCI Hotplug driver to use the new style of module parameters.

set_controller_speed is implemented in cpqphp.h but only used in cpqphp_ctrl.c
and it's much too big to be defined in a header file. This patch moves it to
cpqphp_ctrl.c. Also the inline attribute is removed, this function is called
from 2 places and to big to be an inline.

Remove some useless NULL and magic checks from Compaq PCI Hotplug driver.
If one of this pointers is invalid we are in bad trouble anyway.

The usual coding style fixes, this time for cpqphp_ctrl.c and cpqphp.c.

configure_new_function is way too big (>600 lines). Split it in 2 functions,
one for the new functions and one for bridges. And split out a small piece
from the bridge function which is used twice to it's own function.

Patch is huge because of the identation changes but does nothing than the
split and some minor coding style changes.

The result of kmalloc does not need to be casted, it is a void * which can be
assigned to any pointer variable. Also avoid code duplication in one if
statement.

Some final fixes for the skeleton driver:
-spaces before opening brace
-add a better example for hardware_test function
-remove a "int retval" in a void function
-some more coding style changes
-changed enough stuff: increase version number
-fix a typo in a comment

Convert PCI hotplug skeleton driver to use goto for error handling in
init_slots to avoid code duplication.

Add __init and __exit to some functions only called from __init/__exit context.

Coding style fixes for pcihp_skeleton.c: remove spaces before opening braces
and change a comment in function hardware_test to make clearer that the
functions purpose is not to tell the user there are no tests.

This one removes all the useless NULL checks including slot_paranoia_check,
get_slot and the magic number from the PCI hotplug skeleton driver. Also some
lines containing only a single tab are fixed.

Convert the PCI hotplug skeleton driver to use new style of module parameter
handling.

If there is a condition with the comment "should never happen" it is a good
place for a BUG() if it is ever reached.

Some minor coding style fixes:
-space before opening brace of function
-wrap some long lines
-change some identations from spaces to tabs

This one fixes another space before an opening brace I missed before and
optimizes the error paths in init_slots a bit more.

The magic slot number was only another type of checking the validity of a
pointer. These checks are all gone so magic can follow them.

This one converts acpiphp_core.c to use the new interface for module
parameters.

Convert the driver to use new interface for module parameters, Also fix the
driver name used in debug messages.

Eike

slot->magic is not used anymore since slot_paranoia_check is dead, so just kill
it.

A special function for handling the parameters in non-module case is not
needed, the MODULE_* makros handle this also for compiled in situations.

If we remove this 3 get_* functions the pci hotplug core will do the same
thing for us.

Fix 2 very ugly return constructs.

This one converts the error handling in init_slots to use gotos to avoid code
duplication.