1. 15 Aug, 2020 3 commits
  2. 14 Aug, 2020 37 commits
    • Linus Torvalds's avatar
      Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · c9c9735c
      Linus Torvalds authored
      Pull more SCSI updates from James Bottomley:
       "This is the set of patches which arrived too late to stabilise in
        -next for the first pull.
      
        It's really just an lpfc driver update and an assortment of minor
        fixes, all in drivers. The only core update is to the zone block
        device driver, which isn't the one most people use"
      
      * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: lpfc: Update lpfc version to 12.8.0.3
        scsi: lpfc: Fix LUN loss after cable pull
        scsi: lpfc: Fix validation of bsg reply lengths
        scsi: lpfc: Fix retry of PRLI when status indicates its unsupported
        scsi: lpfc: Fix oops when unloading driver while running mds diags
        scsi: lpfc: Fix RSCN timeout due to incorrect gidft counter
        scsi: lpfc: Fix no message shown for lpfc_hdw_queue out of range value
        scsi: lpfc: Fix FCoE speed reporting
        scsi: lpfc: Add missing misc_deregister() for lpfc_init()
        scsi: lpfc: nvmet: Avoid hang / use-after-free again when destroying targetport
        scsi: scsi_transport_sas: Add spaces around binary operator "|"
        scsi: sd_zbc: Improve zone revalidation
        scsi: libfc: Free skb in fc_disc_gpn_id_resp() for valid cases
        scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del()
        scsi: target: Make iscsit_register_transport() return void
      c9c9735c
    • Linus Torvalds's avatar
      Merge tag 'pwm/for-5.9-rc1' of... · fded0919
      Linus Torvalds authored
      Merge tag 'pwm/for-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm
      
      Pull pwm updates from Thierry Reding:
       "The majority of this batch is conversion of the PWM period and duty
        cycle to 64-bit unsigned integers, which is required so that some
        types of hardware can generate the full range of signals that they're
        capable of.
      
        The remainder is mostly minor fixes and cleanups"
      
      * tag 'pwm/for-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm:
        pwm: bcm-iproc: handle clk_get_rate() return
        pwm: Replace HTTP links with HTTPS ones
        pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header
        pwm: mediatek: Provide missing kerneldoc description for 'soc' arg
        pwm: bcm-kona: Remove impossible comparison when validating duty cycle
        pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
        pwm: iqs620a: Use lowercase hexadecimal literals for consistency
        pwm: Convert period and duty cycle to u64
        clk: pwm: Use 64-bit division function
        backlight: pwm_bl: Use 64-bit division function
        pwm: sun4i: Use nsecs_to_jiffies to avoid a division
        pwm: sifive: Use 64-bit division macro
        pwm: iqs620a: Use 64-bit division
        pwm: imx27: Use 64-bit division macro
        pwm: imx-tpm: Use 64-bit division macro
        pwm: clps711x: Use 64-bit division macro
        hwmon: pwm-fan: Use 64-bit division macro
        drm/i915: Use 64-bit division macro
      fded0919
    • Linus Torvalds's avatar
      Merge tag 'sound-fix-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · 87bd8c2b
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "All device-specific small fixes and quirks mostly for usual suspects,
        USB-audio and HD-audio"
      
      * tag 'sound-fix-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
        ALSA: echoaudio: Fix potential Oops in snd_echo_resume()
        ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop
        ALSA: hda/realtek - Fix unused variable warning
        ALSA: hda - reverse the setting value in the micmute_led_set
        ALSA: echoaduio: Drop superfluous volatile modifier
        ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control
        ALSA: usb-audio: add quirk for Pioneer DDJ-RB
        ALSA: usb-audio: work around streaming quirk for MacroSilicon MS2109
        ALSA: hda - fix the micmute led status for Lenovo ThinkCentre AIO
        ALSA: usb-audio: fix overeager device match for MacroSilicon MS2109
        ALSA: hda/realtek: Fix pin default on Intel NUC 8 Rugged
        ALSA: usb-audio: Creative USB X-Fi Pro SB1095 volume knob support
        ALSA: usb-audio: fix spelling mistake "buss" -> "bus"
      87bd8c2b
    • Linus Torvalds's avatar
      dma-debug: remove debug_dma_assert_idle() function · 5848dc5b
      Linus Torvalds authored
      This remoes the code from the COW path to call debug_dma_assert_idle(),
      which was added many years ago.
      
      Google shows that it hasn't caught anything in the 6+ years we've had it
      apart from a false positive, and Hugh just noticed how it had a very
      unfortunate spinlock serialization in the COW path.
      
      He fixed that issue the previous commit (a85ffd59: "dma-debug: fix
      debug_dma_assert_idle(), use rcu_read_lock()"), but let's see if anybody
      even notices when we remove this function entirely.
      
      NOTE! We keep the dma tracking infrastructure that was added by the
      commit that introduced it.  Partly to make it easier to resurrect this
      debug code if we ever deside to, and partly because that tracking by pfn
      and offset looks quite reasonable.
      
      The problem with this debug code was simply that it was expensive and
      didn't seem worth it, not that it was wrong per se.
      Acked-by: default avatarDan Williams <dan.j.williams@intel.com>
      Acked-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      5848dc5b
    • Hugh Dickins's avatar
      dma-debug: fix debug_dma_assert_idle(), use rcu_read_lock() · a85ffd59
      Hugh Dickins authored
      Since commit 2a9127fc ("mm: rewrite wait_on_page_bit_common()
      logic") improved unlock_page(), it has become more noticeable how
      cow_user_page() in a kernel with CONFIG_DMA_API_DEBUG=y can create and
      suffer from heavy contention on DMA debug's radix_lock in
      debug_dma_assert_idle().
      
      It is only doing a lookup: use rcu_read_lock() and rcu_read_unlock()
      instead; though that does require the static ents[] to be moved
      onstack...
      
      ...but, hold on, isn't that radix_tree_gang_lookup() and loop doing
      quite the wrong thing: searching CACHELINES_PER_PAGE entries for an
      exact match with the first cacheline of the page in question?
      radix_tree_gang_lookup() is the right tool for the job, but we need
      nothing more than to check the first entry it can find, reporting if
      that falls anywhere within the page.
      
      (Is RCU safe here? As safe as using the spinlock was. The entries are
      never freed, so don't need to be freed by RCU. They may be reused, and
      there is a faint chance of a race, with an offending entry reused while
      printing its error info; but the spinlock did not prevent that either,
      and I agree that it's not worth worrying about. ]
      
      [ Side noe: this patch is a clear improvement to the status quo, but the
        next patch will be removing this debug function entirely.
      
        But just in case we decide we want to resurrect the debugging code
        some day, I'm first applying this improvement patch so that it doesn't
        get lost    - Linus ]
      
      Fixes: 3b7a6418 ("dma debug: account for cachelines and read-only mappings in overlap tracking")
      Signed-off-by: default avatarHugh Dickins <hughd@google.com>
      Acked-by: default avatarDan Williams <dan.j.williams@intel.com>
      Acked-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a85ffd59
    • Linus Torvalds's avatar
      Merge tag 'timers-urgent-2020-08-14' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · b923f124
      Linus Torvalds authored
      Pull timekeeping updates from Thomas Gleixner:
       "A set of timekeeping/VDSO updates:
      
         - Preparatory work to allow S390 to switch over to the generic VDSO
           implementation.
      
           S390 requires that the VDSO data pointer is handed in to the
           counter read function when time namespace support is enabled.
           Adding the pointer is a NOOP for all other architectures because
           the compiler is supposed to optimize that out when it is unused in
           the architecture specific inline. The change also solved a similar
           problem for MIPS which fortunately has time namespaces not yet
           enabled.
      
           S390 needs to update clock related VDSO data independent of the
           timekeeping updates. This was solved so far with yet another
           sequence counter in the S390 implementation. A better solution is
           to utilize the already existing VDSO sequence count for this. The
           core code now exposes helper functions which allow to serialize
           against the timekeeper code and against concurrent readers.
      
           S390 needs extra data for their clock readout function. The initial
           common VDSO data structure did not provide a way to add that. It
           now has an embedded architecture specific struct embedded which
           defaults to an empty struct.
      
           Doing this now avoids tree dependencies and conflicts post rc1 and
           allows all other architectures which work on generic VDSO support
           to work from a common upstream base.
      
         - A trivial comment fix"
      
      * tag 'timers-urgent-2020-08-14' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        time: Delete repeated words in comments
        lib/vdso: Allow to add architecture-specific vdso data
        timekeeping/vsyscall: Provide vdso_update_begin/end()
        vdso/treewide: Add vdso_data pointer argument to __arch_get_hw_counter()
      b923f124
    • Linus Torvalds's avatar
      Merge tag 'timers-core-2020-08-14' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · b6b178e3
      Linus Torvalds authored
      Pull more timer updates from Thomas Gleixner:
       "A set of posix CPU timer changes which allows to defer the heavy work
        of posix CPU timers into task work context. The tick interrupt is
        reduced to a quick check which queues the work which is doing the
        heavy lifting before returning to user space or going back to guest
        mode. Moving this out is deferring the signal delivery slightly but
        posix CPU timers are inaccurate by nature as they depend on the tick
        so there is no real damage. The relevant test cases all passed.
      
        This lifts the last offender for RT out of the hard interrupt context
        tick handler, but it also has the general benefit that the actual
        heavy work is accounted to the task/process and not to the tick
        interrupt itself.
      
        Further optimizations are possible to break long sighand lock hold and
        interrupt disabled (on !RT kernels) times when a massive amount of
        posix CPU timers (which are unpriviledged) is armed for a
        task/process.
      
        This is currently only enabled for x86 because the architecture has to
        ensure that task work is handled in KVM before entering a guest, which
        was just established for x86 with the new common entry/exit code which
        got merged post 5.8 and is not the case for other KVM architectures"
      
      * tag 'timers-core-2020-08-14' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86: Select POSIX_CPU_TIMERS_TASK_WORK
        posix-cpu-timers: Provide mechanisms to defer timer handling to task_work
        posix-cpu-timers: Split run_posix_cpu_timers()
      b6b178e3
    • Linus Torvalds's avatar
      Merge tag 'irq-urgent-2020-08-14' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 1d229a65
      Linus Torvalds authored
      Pull irq fixes from Thomas Gleixner:
       "Two fixes in the core interrupt code which ensure that all error exits
        unlock the descriptor lock"
      
      * tag 'irq-urgent-2020-08-14' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        genirq: Unlock irq descriptor after errors
        genirq/PM: Always unlock IRQ descriptor in rearm_wake_irq()
      1d229a65
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://github.com/openrisc/linux · e1d74fbe
      Linus Torvalds authored
      Pull OpenRISC updates from Stafford Horne:
       "A few patches all over the place during this cycle, mostly bug and
        sparse warning fixes for OpenRISC, but a few enhancements too. Note,
        there are 2 non OpenRISC specific fixups.
      
        Non OpenRISC fixes:
      
         - In init we need to align the init_task correctly to fix an issue
           with MUTEX_FLAGS, reviewed by Peter Z. No one picked this up so I
           kept it on my tree.
      
         - In asm-generic/io.h I fixed up some sparse warnings, OK'd by Arnd.
           Arnd asked to merge it via my tree.
      
        OpenRISC fixes:
      
         - Many fixes for OpenRISC sprase warnings.
      
         - Add support OpenRISC SMP tlb flushing rather than always flushing
           the entire TLB on every CPU.
      
         - Fix bug when dumping stack via /proc/xxx/stack of user threads"
      
      * tag 'for-linus' of git://github.com/openrisc/linux:
        openrisc: uaccess: Add user address space check to access_ok
        openrisc: signal: Fix sparse address space warnings
        openrisc: uaccess: Remove unused macro __addr_ok
        openrisc: uaccess: Use static inline function in access_ok
        openrisc: uaccess: Fix sparse address space warnings
        openrisc: io: Fixup defines and move include to the end
        asm-generic/io.h: Fix sparse warnings on big-endian architectures
        openrisc: Implement proper SMP tlb flushing
        openrisc: Fix oops caused when dumping stack
        openrisc: Add support for external initrd images
        init: Align init_task to avoid conflict with MUTEX_FLAGS
        openrisc: fix __user in raw_copy_to_user()'s prototype
      e1d74fbe
    • Linus Torvalds's avatar
      Merge tag 'powerpc-5.9-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · 7fca4dee
      Linus Torvalds authored
      Pull powerpc fix from Michael Ellerman:
       "One fix for a boot crash on some platforms introduced by the recent
        pkey refactoring.
      
        Thanks to Christian Zigotzky and Aneesh Kumar K.V"
      
      * tag 'powerpc-5.9-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        powerpc/pkeys: Fix boot failures with Nemo board (A-EON AmigaOne X1000)
      7fca4dee
    • Linus Torvalds's avatar
      Merge tag 'for-linus-5.9-rc1b-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · 0520058d
      Linus Torvalds authored
      Pull more xen updates from Juergen Gross:
      
       - Remove support for running as 32-bit Xen PV-guest.
      
         32-bit PV guests are rarely used, are lacking security fixes for
         Meltdown, and can be easily replaced by PVH mode. Another series for
         doing more cleanup will follow soon (removal of 32-bit-only pvops
         functionality).
      
       - Fixes and additional features for the Xen display frontend driver.
      
      * tag 'for-linus-5.9-rc1b-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        drm/xen-front: Pass dumb buffer data offset to the backend
        xen: Sync up with the canonical protocol definition in Xen
        drm/xen-front: Add YUYV to supported formats
        drm/xen-front: Fix misused IS_ERR_OR_NULL checks
        xen/gntdev: Fix dmabuf import with non-zero sgt offset
        x86/xen: drop tests for highmem in pv code
        x86/xen: eliminate xen-asm_64.S
        x86/xen: remove 32-bit Xen PV guest support
      0520058d
    • Linus Torvalds's avatar
      Merge tag 'hyperv-fixes-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux · cd94257d
      Linus Torvalds authored
      Pull hyper-v fixes from Wei Liu:
      
       - fix oops reporting on Hyper-V
      
       - make objtool happy
      
      * tag 'hyperv-fixes-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux:
        x86/hyperv: Make hv_setup_sched_clock inline
        Drivers: hv: vmbus: Only notify Hyper-V for die events that are oops
      cd94257d
    • Eric Dumazet's avatar
      x86/fsgsbase/64: Fix NULL deref in 86_fsgsbase_read_task · 8ab49526
      Eric Dumazet authored
      syzbot found its way in 86_fsgsbase_read_task() and triggered this oops:
      
         KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
         CPU: 0 PID: 6866 Comm: syz-executor262 Not tainted 5.8.0-syzkaller #0
         RIP: 0010:x86_fsgsbase_read_task+0x16d/0x310 arch/x86/kernel/process_64.c:393
         Call Trace:
           putreg32+0x3ab/0x530 arch/x86/kernel/ptrace.c:876
           genregs32_set arch/x86/kernel/ptrace.c:1026 [inline]
           genregs32_set+0xa4/0x100 arch/x86/kernel/ptrace.c:1006
           copy_regset_from_user include/linux/regset.h:326 [inline]
           ia32_arch_ptrace arch/x86/kernel/ptrace.c:1061 [inline]
           compat_arch_ptrace+0x36c/0xd90 arch/x86/kernel/ptrace.c:1198
           __do_compat_sys_ptrace kernel/ptrace.c:1420 [inline]
           __se_compat_sys_ptrace kernel/ptrace.c:1389 [inline]
           __ia32_compat_sys_ptrace+0x220/0x2f0 kernel/ptrace.c:1389
           do_syscall_32_irqs_on arch/x86/entry/common.c:84 [inline]
           __do_fast_syscall_32+0x57/0x80 arch/x86/entry/common.c:126
           do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:149
           entry_SYSENTER_compat_after_hwframe+0x4d/0x5c
      
      This can happen if ptrace() or sigreturn() pokes an LDT selector into FS
      or GS for a task with no LDT and something tries to read the base before
      a return to usermode notices the bad selector and fixes it.
      
      The fix is to make sure ldt pointer is not NULL.
      
      Fixes: 07e1d88a ("x86/fsgsbase/64: Fix ptrace() to read the FS/GS base accurately")
      Co-developed-by: default avatarJann Horn <jannh@google.com>
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
      Acked-by: default avatarAndy Lutomirski <luto@kernel.org>
      Cc: Chang S. Bae <chang.seok.bae@intel.com>
      Cc: Andy Lutomirski <luto@amacapital.net>
      Cc: Borislav Petkov <bp@alien8.de>
      Cc: Brian Gerst <brgerst@gmail.com>
      Cc: Dave Hansen <dave.hansen@linux.intel.com>
      Cc: Denys Vlasenko <dvlasenk@redhat.com>
      Cc: H. Peter Anvin <hpa@zytor.com>
      Cc: Markus T Metzger <markus.t.metzger@intel.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Ravi Shankar <ravi.v.shankar@intel.com>
      Cc: Rik van Riel <riel@surriel.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      8ab49526
    • Linus Torvalds's avatar
      Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 · d9361cb2
      Linus Torvalds authored
      Pull crypto fix from Herbert Xu:
       "This fixes a regression in af_alg"
      
      * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
        crypto: algif_aead - fix uninitialized ctx->init
      d9361cb2
    • Linus Torvalds's avatar
      Merge tag 'modules-for-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux · 0fd9cc6b
      Linus Torvalds authored
      Pull module updates from Jessica Yu:
       "The most important change would be Christoph Hellwig's patch
        implementing proprietary taint inheritance, in an effort to discourage
        the creation of GPL "shim" modules that interface between GPL symbols
        and proprietary symbols.
      
        Summary:
      
         - Have modules that use symbols from proprietary modules inherit the
           TAINT_PROPRIETARY_MODULE taint, in an effort to prevent GPL shim
           modules that are used to circumvent _GPL exports. These are modules
           that claim to be GPL licensed while also using symbols from
           proprietary modules. Such modules will be rejected while non-GPL
           modules will inherit the proprietary taint.
      
         - Module export space cleanup. Unexport symbols that are unused
           outside of module.c or otherwise used in only built-in code"
      
      * tag 'modules-for-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux:
        modules: inherit TAINT_PROPRIETARY_MODULE
        modules: return licensing information from find_symbol
        modules: rename the licence field in struct symsearch to license
        modules: unexport __module_address
        modules: unexport __module_text_address
        modules: mark each_symbol_section static
        modules: mark find_symbol static
        modules: mark ref_module static
        modules: linux/moduleparam.h: drop duplicated word in a comment
      0fd9cc6b
    • Linus Torvalds's avatar
      Merge tag 'kconfig-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild · 32b2ee5c
      Linus Torvalds authored
      Pull Kconfig updates from Masahiro Yamada:
      
       - remove '---help---' keyword support
      
       - fix mouse events for 'menuconfig' symbols in search view of qconf
      
       - code cleanups of qconf
      
      * tag 'kconfig-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: (24 commits)
        kconfig: qconf: move setOptionMode() to ConfigList from ConfigView
        kconfig: qconf: do not limit the pop-up menu to the first row
        kconfig: qconf: refactor icon setups
        kconfig: qconf: remove unused voidPix, menuInvPix
        kconfig: qconf: remove ConfigItem::text/setText
        kconfig: qconf: remove ConfigList::addColumn/removeColumn
        kconfig: qconf: remove ConfigItem::pixmap/setPixmap
        kconfig: qconf: drop more localization code
        kconfig: qconf: remove 'parent' from ConfigList::updateMenuList()
        kconfig: qconf: remove unused argument from ConfigView::updateList()
        kconfig: qconf: remove unused argument from ConfigList::updateList()
        kconfig: qconf: omit parent to QHBoxLayout()
        kconfig: qconf: remove name from ConfigSearchWindow constructor
        kconfig: qconf: remove unused ConfigList::listView()
        kconfig: qconf: overload addToolBar() to create and insert toolbar
        kconfig: qconf: remove toolBar from ConfigMainWindow members
        kconfig: qconf: use 'menu' variable for (QMenu *)
        kconfig: qconf: do not use 'menu' variable for (QMenuBar *)
        kconfig: qconf: remove ->addSeparator() to menuBar
        kconfig: add 'static' to some file-local data
        ...
      32b2ee5c
    • Masahiro Yamada's avatar
      kconfig: qconf: move setOptionMode() to ConfigList from ConfigView · d4bbe8a1
      Masahiro Yamada authored
      ConfigView::setOptionMode() only gets access to the 'list' member.
      
      Move it to the more relevant ConfigList class.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      d4bbe8a1
    • Masahiro Yamada's avatar
      kconfig: qconf: do not limit the pop-up menu to the first row · fa8de0a3
      Masahiro Yamada authored
      If you right-click the first row in the option tree, the pop-up menu
      shows up, but if you right-click the second row or below, the event
      is ignored due to the following check:
      
        if (e->y() <= header()->geometry().bottom()) {
      
      Perhaps, the intention was to show the pop-menu only when the tree
      header was right-clicked, but this handler is not called in that case.
      
      Since the origin of e->y() starts from the bottom of the header,
      this check is odd.
      
      Going forward, you can right-click anywhere in the tree to get the
      pop-up menu.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      fa8de0a3
    • Masahiro Yamada's avatar
      kconfig: qconf: refactor icon setups · 5cb255ff
      Masahiro Yamada authored
      These icon data are used by ConfigItem, but stored in each instance
      of ConfigView. There is no point to keep the same data in each of 3
      instances, "menu", "config", and "search".
      
      Move the icon data to the more relevant ConfigItem class, and make
      them static members.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      5cb255ff
    • Masahiro Yamada's avatar
      kconfig: qconf: remove unused voidPix, menuInvPix · 4fa91f52
      Masahiro Yamada authored
      These are initialized, but not used by anyone.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      4fa91f52
    • Masahiro Yamada's avatar
      kconfig: qconf: remove ConfigItem::text/setText · 5ca534cd
      Masahiro Yamada authored
      Use QTreeWidgetItem::text/setText directly
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      5ca534cd
    • Masahiro Yamada's avatar
      kconfig: qconf: remove ConfigList::addColumn/removeColumn · abf741a9
      Masahiro Yamada authored
      Use QTreeView::showColumn/hideColumn directly.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      abf741a9
    • Masahiro Yamada's avatar
      kconfig: qconf: remove ConfigItem::pixmap/setPixmap · 711b875b
      Masahiro Yamada authored
      Use QTreeWidgetItem::icon/setIcon directly.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      711b875b
    • Masahiro Yamada's avatar
      kconfig: qconf: drop more localization code · 3c73ff04
      Masahiro Yamada authored
      This is a remnant of commit 694c49a7 ("kconfig: drop localization
      support").
      
      Get it back to the code prior to commit 3b9fa093 ("[PATCH] Kconfig
      i18n support").
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      3c73ff04
    • Masahiro Yamada's avatar
      kconfig: qconf: remove 'parent' from ConfigList::updateMenuList() · 5b75a6c8
      Masahiro Yamada authored
      All the call-sites of this function pass 'this' to the first argument.
      
      So, 'parent' is always the 'this' pointer.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      5b75a6c8
    • Masahiro Yamada's avatar
      kconfig: qconf: remove unused argument from ConfigView::updateList() · 1031685c
      Masahiro Yamada authored
      Now that ConfigList::updateList() takes no argument, the 'item' argument
      ConfigView::updateList() is no longer used.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      1031685c
    • Masahiro Yamada's avatar
      kconfig: qconf: remove unused argument from ConfigList::updateList() · cb77043f
      Masahiro Yamada authored
      This function allocates 'item' before using it, so the argument 'item'
      is always shadowed.
      
      Remove the meaningless argument.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      cb77043f
    • Masahiro Yamada's avatar
      kconfig: qconf: omit parent to QHBoxLayout() · 92641154
      Masahiro Yamada authored
      Instead of passing 0 (i.e. nullptr), leave it empty.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      92641154
    • Masahiro Yamada's avatar
      kconfig: qconf: remove name from ConfigSearchWindow constructor · 740fdef8
      Masahiro Yamada authored
      This constructor is only called with "search" as the second argument.
      
      Hard-code the name in the constructor, and drop it from the function
      argument.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      740fdef8
    • Masahiro Yamada's avatar
      kconfig: qconf: remove unused ConfigList::listView() · 1b4263e7
      Masahiro Yamada authored
      I do not know how this function can be useful. In fact, it is unsed.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      1b4263e7
    • Masahiro Yamada's avatar
      kconfig: qconf: overload addToolBar() to create and insert toolbar · 860ec3fb
      Masahiro Yamada authored
      Use the overloaded function, addToolBar(const QString &title)
      to create a QToolBar object, setting its window title, and inserts
      it into the toolbar area.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      860ec3fb
    • Masahiro Yamada's avatar
      kconfig: qconf: remove toolBar from ConfigMainWindow members · 2afb3e26
      Masahiro Yamada authored
      This pointer is only used in the ConfigMainWindow constructor.
      
      Drop it from the private members.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      2afb3e26
    • Masahiro Yamada's avatar
      kconfig: qconf: use 'menu' variable for (QMenu *) · 93ebaacd
      Masahiro Yamada authored
      The variable 'config' for the file menu is inconsistent.
      
      You do not need to use different variables. Use 'menu' for every menu.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      93ebaacd
    • Masahiro Yamada's avatar
      kconfig: qconf: do not use 'menu' variable for (QMenuBar *) · d4b1cea7
      Masahiro Yamada authored
      I think it is a bit confusing to use 'menu' to hold a QMenuBar pointer.
      I want to use 'menu' for a QMenu pointer.
      
      You do not need to use a local variable here. Use menuBar() directly.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      d4b1cea7
    • Masahiro Yamada's avatar
      kconfig: qconf: remove ->addSeparator() to menuBar · 614bf0a8
      Masahiro Yamada authored
      I do not understand the purpose of this ->addSeparator().
      It does not make any difference.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      614bf0a8
    • Masahiro Yamada's avatar
      kconfig: add 'static' to some file-local data · d41809ff
      Masahiro Yamada authored
      Fix some warnings from sparce like follows:
      
        warning: symbol '...' was not declared. Should it be static?
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      d41809ff
    • Maxime Chretien's avatar
      kconfig: qconf: Fix mouse events in search view · 7eb7c106
      Maxime Chretien authored
      On menu properties mouse events didn't do anything in search view
      (listMode).
      
      As there are no menus in listMode we can add an exception in tests to
      always change the value on mouse events if we are in listMode.
      Signed-off-by: default avatarMaxime Chretien <maxime.chretien@bootlin.com>
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      7eb7c106