An error occurred fetching the project authors.
  1. 07 Jul, 2014 11 commits
  2. 17 Jun, 2014 2 commits
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: export just one symbol · d44913c1
      Mauro Carvalho Chehab authored
      Exporting multiple symbols don't work as it causes compilation
      breakages, due to the way dvb_attach() works.
      
      The bug happens when:
              CONFIG_DVB_DIB8000=m
      	CONFIG_DVB_USB_DIB0700=y
      
      As a bonus, dib8000 won't be loaded anymore if the device uses
      a different frontend, reducing the memory footprint.
      
      Tested with both Pixelview PV-D231 and MyGica S870.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      d44913c1
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: rename dib8000_attach to dib8000_init · b9bc7d59
      Mauro Carvalho Chehab authored
      Well, what we call as "foo_attach" is the method that should
      be called by the dvb_attach() macro.
      
      It should be noticed that the name "dvb_attach" is really a
      bad name and don't express what it does.
      
      dvb_attach() basically does three things, if the frontend is
      compiled as a module:
      - It lookups for the module that it is known to have the
        given symbol name and requests such module;
      - It increments the module usage (anonymously - so lsmod
        doesn't print who loaded the module);
      - after loading the module, it runs the function associated
        with the dynamic symbol.
      
      When compiled as builtin, it just calls the function given to it.
      
      As dvb_attach() increments refcount, it can't be (easily)
      called more than once for the same module, or the kernel
      will deny to remove the module, because refcount will never
      be zeroed.
      
      In other words, the function name given to dvb_attach()
      should be one single symbol that will always be called
      before any other function on that module to be used.
      
      For almost all DVB frontends, there's just one function,
      but, on dib8000, there are several exported symbols.
      
      We need to get rid of all those direct calls, because they
      cause compilation breakages when bridge is builtin and
      frontend is module, we'll need to add a new function that
      will be the first one to be called, whatever initialization
      is needed.
      
      So, let's rename this function, in order to prepare for
      a next patch that will add a new attach() function that
      will be the only one exported by this module.
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      b9bc7d59
  3. 13 Jan, 2014 2 commits
  4. 20 Dec, 2013 1 commit
  5. 19 Dec, 2013 11 commits
  6. 09 Dec, 2013 1 commit
  7. 29 Nov, 2013 1 commit
  8. 08 Jun, 2013 1 commit
  9. 25 Apr, 2013 4 commits
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: fix a warning · 13122f98
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/dib8000.c: In function 'dib8000_wait_lock':
      drivers/media/dvb-frontends/dib8000.c:3972:1: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized]
      drivers/media/dvb-frontends/dib8000.c:2419:6: note: 'value' was declared here
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      13122f98
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: Fix sub-channel range · 746f7ae0
      Mauro Carvalho Chehab authored
      isdbt_sb_subchannel is unsigned with 8 bits. So, it will
      never be -1. Instead, any value bigger than 13 is invalid.
      
      As is, the current code generates the following warnings:
      
      drivers/media/dvb-frontends/dib8000.c: In function 'dib8000_set_isdbt_common_channel':
      drivers/media/dvb-frontends/dib8000.c:2358:3: warning: comparison is always true due to limited range of data type [-Wtype-limits]
      drivers/media/dvb-frontends/dib8000.c: In function 'dib8000_tune':
      drivers/media/dvb-frontends/dib8000.c:3107:8: warning: comparison is always false due to limited range of data type [-Wtype-limits]
      drivers/media/dvb-frontends/dib8000.c:3153:9: warning: comparison is always false due to limited range of data type [-Wtype-limits]
      drivers/media/dvb-frontends/dib8000.c:3160:5: warning: comparison is always false
      
      It should also be noticed that ARIB STD-B31, item
      "3.15.6.8 Number of segments" at TMCC table defines the
      value 15 for unused segment, and 14 as reserved.
      
      So, better to change the check to consider any value
      bigger than 13 to mean that sub-channels should be
      disabled, fixing the warning and doing the right thing
      even if an invalid value is filled by userspace.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      746f7ae0
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: store dtv_property_cache in a temp var · c82056d0
      Mauro Carvalho Chehab authored
      dtv_property_cache is used on several places on very long lines.
      
      On all places it is used, a long list of struct reference is done.
      
      Instead of doing it, at the routines where it is used more than once,
      replace it by one temporary var. That may help the compiler to
      use a better code. It also makes easier to review the code, as the
      lines becomes closer to 80 columns, making them a way clearer
      to read.
      
      No functional changes.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      c82056d0
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: warning fix: declare internal functions as static · 6f7ee06f
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/dib8000.c:2412:5: warning: no previous prototype for 'dib8000_wait_lock' [-Wmissing-prototypes]
      drivers/media/dvb-frontends/dib8000.c:2688:5: warning: no previous prototype for 'dib8000_get_symbol_duration' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      6f7ee06f
  10. 22 Apr, 2013 1 commit
  11. 14 Aug, 2012 1 commit
  12. 31 Jul, 2012 1 commit
  13. 04 Jan, 2012 1 commit
  14. 31 Dec, 2011 2 commits
    • Mauro Carvalho Chehab's avatar
      [media] dvb: don't require a parameter for get_frontend · 7c61d80a
      Mauro Carvalho Chehab authored
      Just like set_frontend, use the dvb cache properties for get_frontend.
      This is more consistent, as both functions are now symetric. Also,
      at the places get_frontend is called, it makes sense to update the
      cache.
      
      Most of this patch were generated by this small perl script:
      
      	while (<>) { $file .= $_; }
      	if ($file =~ m/\.get_frontend\s*=\s*([\d\w_]+)/) {
      		my $get = $1;
      		$file =~ s/($get)(\s*\([^\,\)]+)\,\s*struct\s+dtv_frontend_properties\s*\*\s*([_\d\w]+)\)\s*\{/\1\2)\n{\n\tstruct dtv_frontend_properties *\3 = &fe->dtv_property_cache;/g;
      	}
      	print $file;
      
      Of course, the changes at dvb_frontend.[ch] were made by hand,
      as well as the changes on a few other places, where get_frontend()
      is called internally inside the driver.
      
      On some places, get_frontend() were just a void function. Those
      occurrences were removed, as the DVB core handles such cases.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      7c61d80a
    • Mauro Carvalho Chehab's avatar
      [media] dib8000: Remove the old DVBv3 struct from it and add delsys · 490ecd63
      Mauro Carvalho Chehab authored
      This driver only uses the DVBv5 struct. All it needs is to remove
      the non-used params var, and to add the ISDB-T to the delivery
      systems.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      490ecd63