1. 20 Jan, 2004 7 commits
    • Adam Kropelin's avatar
      [PATCH] USB: hiddev HIDIOCGREPORT not blocking in 2.6 · f3c64148
      Adam Kropelin authored
      I've noticed in 2.6 kernels that HIDIOCGREPORT does not wait for io
      completion before returning to the caller. This creates a few unpleasant
      issues for userspace:
      
      First, code sequences such as...
      
              ioctl(fd, HIDIOCGREPORT, &rinfo);
              ioctl(fd, HIDIOCGUSAGE, &uinfo);
              ioctl(fd, HIDIOCGSTRING, &sdesc);
      
      ...that used to work in 2.4 now fail in 2.6 if the device takes more
      than a few milliseconds to respond to HIDIOCGREPORT. (I'm seeing this
      issue on APC UPSes, FWIW.)
      
      Second, userspace code can easily flood the kernel with control messages
      since the kernel provides no "backpressure". The result is a lot of
      "hid-core.c: control queue full" errors and lost reports.
      
      2.6 hid-core.c appears to submit the request and return immediately.
      Although the 2.4 code differs significantly, I traced the call path to
      usb-core.c, which seems to block with a timeout, so the code supports my
      userspace observation. (Assuming I didn't misread it.)
      f3c64148
    • Greg Kroah-Hartman's avatar
    • Greg Kroah-Hartman's avatar
    • Alan Stern's avatar
      [PATCH] USB UHCI: fix broken data toggles for queued control URBs · 93cab357
      Alan Stern authored
      This patch fixes a long-standing (albeit unidentified) problem in the
      queueing code for the UHCI HCD.  The code propagates data toggle settings
      between messages in a queue for control transfers just the same as bulk
      and interrupt transfers.  That is a mistake, since control messages always
      restart with data toggle 0.  With this patch, the UHCI driver now passes
      test 10 (control URB queueing) in David Brownell's usbtest suite.
      
      The patch appears to change more than it really does, because it alters
      the indentation level of a large section of code.
      93cab357
    • Greg Kroah-Hartman's avatar
      Merge kroah.com:/home/linux/BK/bleed-2.6 · 54d285d9
      Greg Kroah-Hartman authored
      into kroah.com:/home/linux/BK/usb-2.6
      54d285d9
    • Dave Jones's avatar
      [PATCH] Prevent false positives in non-fatal MCE check. · d00ea9a1
      Dave Jones authored
      non-fatal didn't get the same change that k7.c did a few months
      back, so it reads from banks that actually _cause_ MCEs.
      
      This patch also adds a bunch of copyright headers whilst we're
      in that neighborhood.
      d00ea9a1
    • Jeff Garzik's avatar
      Merge redhat.com:/spare/repo/linux-2.5 · e98fd32c
      Jeff Garzik authored
      into redhat.com:/spare/repo/libata-2.5
      e98fd32c
  2. 19 Jan, 2004 33 commits