1. 04 Jun, 2004 5 commits
    • Alan Stern's avatar
      [PATCH] USB: Superficial improvements to hub_port_debounce() · f4692b3e
      Alan Stern authored
      Since my previous suggestions for changes to hub_port_debounce()
      encountered so much resistance, this patch makes some fairly superficial
      improvements to the code while leaving the logic of the algorithm almost
      completely intact.  The only behavioral change is that it actually
      requests the port status at the start, rather than assuming the status is
      not CONNECTED.  Changes include:
      
      	Vastly improved comments that are now unambiguous and accurately
      	descriptive of the code.
      
      	Local variables changed to more sensible names.  The stability
      	period is now reported in milliseconds rather than a meaningless
      	poll count.
      
      	The sleep interval is moved from the start of the loop to the
      	end, so that the first time through we read the port status
      	immediately.
      
      	If the connection has not stabilized after the total timeout
      	expires, -ETIMEDOUT is returned rather than whatever the
      	current connect status happens to be.
      
      	If the connection does stabilize then the port status is returned
      	so that hub_port_connect_change() will have an up-to-date value
      	for the status rather than relying on the pre-debounce value.
      
      The changes I wanted to make but other people were worried about are
      included as comments.  A later (small) patch will uncomment them for
      testing.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      f4692b3e
    • Alan Stern's avatar
      [PATCH] USB: Debounce all connect change events · 3e399447
      Alan Stern authored
      This patch makes the hub driver debounce all connection changes.  Right
      now the driver only does so if the status happens to be CONNECTED at one
      particular instant.  However, the whole point of debouncing is that the
      connection is subject to transient interruptions until it has stabilized;
      hence deciding whether to debounce based on a single initial test defeats
      the entire purpose.
      
      There are some additional smaller changes that go along with the major
      one:
      
      	Comments added to hub_port_connect_change() detailing the
      	conditions under which it will be called.
      
      	Don't clear the port's connect-changed feature if it wasn't
      	set.
      
      	Skip debouncing if there wasn't a physical connection change
      	but only a logical port-enable change (or a firmware-download-
      	induced device morph -- not yet implemented).
      
      	Clear all the hub status change indicators in hub_events()
      	before handling a connect change.  This will reduce syslog
      	clutter from status change bits that remain set while khubd
      	is busy taking care of a new device.
      
      The patch includes no changes to the debounce routine itself.  Please
      apply.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      3e399447
    • Alan Stern's avatar
      [PATCH] USB: Code cleanup for the UHCI driver · 5609e1a2
      Alan Stern authored
      This patch makes some simple cleanups in the UHCI driver:
      
      	It introduces msecs_to_jiffies() conversions and uses msleep().
      
      	It wakes up threads waiting for an endpoint to be disabled
      	in the oddball case where interrupts aren't working.  (This
      	should have been in a previous patch but I missed it.)
      
      	It disables PCI interrupt generation whenever the controller
      	is reset and enables it when the controller is started.  This
      	may possibly solve some people's problems with suspend/resume.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      5609e1a2
    • Joe Nardelli's avatar
    • Jan Spitalnik's avatar
      [PATCH] USB: pegasus driver and ATEN device support · 9425c727
      Jan Spitalnik authored
      I have created a patch to add support for ATEN device in pegasus usb driver.
      I've sent the patch to the maintainer stated in pegasus.h but after several
      weeks I didn't recieve a response, so I'm sending it to you now. The patch
      should apply cleanly on 2.6.6, but it doesn't apply cleanly on todays -bk as
      there was some patch adding some other device. One thing I'm not 100% sure
      are the flags specified to PEGASUS_DEV, what means HAS_HOME_PNA?
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      9425c727
  2. 03 Jun, 2004 4 commits
    • Greg Kroah-Hartman's avatar
      USB: remove "devfs" message from kernel log for usb-serial driver · db9efa92
      Greg Kroah-Hartman authored
      No one uses devfs on 2.6 :)
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      db9efa92
    • Scott Cytacki's avatar
      [PATCH] USB: kyocera 7135 patch · 8c670784
      Scott Cytacki authored
      Here is a patch based on 2.6.7-rc2 that makes the Kyocera 7135 work.
      The Kyocera appears to have the same setup as the Trio.  Its endpoints
      are laid out like this:
      
      > >>>type                  address
      > >>>usb bulk out:         0x01
      > >>>usb interrupt in:     0x82
      > >>>usb bulk out:         0x03
      > >>>usb bulk in:          0x84
      The last two are the ones used for the syncing communication.
      
      So the patch adds the ids for the kyocera and makes the treo_attach
      function handle the kyocera too.  I also changed the comment; it appears
      there was an error in the original comment about the treo:
      
      Joe Nardelli wrote:
      > Actually, the comment isn't quite right for Treos either (oops).  It
      > should read:
      >
      > ...
      > 1st bulk in endpoint to communicate with the 2nd bulk out endpoint
      > ...
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      8c670784
    • Alan Stern's avatar
      [PATCH] USB: 2.6-BK usb (printing) broken · b39c9f7e
      Alan Stern authored
      On Sat, 29 May 2004, Jens Axboe wrote:
      
      > > > Both 2.6.7-rc1 and BK current spit out a bunch of:
      > > >
      > > > drivers/usb/class/usblp.c: usblp1: nonzero read/write bulk status received: -2
      > > > drivers/usb/class/usblp.c: usblp1: error -2 reading from printer
      > > > drivers/usb/class/usblp.c: usblp1: error -115 reading from printer
      > > > drivers/usb/class/usblp.c: usblp1: error -115 reading from printer
      > > > ...
      > > >
      > > > (about ~80 of that last line) but work for me.
      
      > Sorry wasn't quite clear - the above messages are with 2.6.7-rc1 and
      > current bk with your patch backed out. Current bk with the patch reports
      > only the timeouts I originally listed.
      
      Okay, I feel better.
      
      It looks like those errors you see are caused by a bug in the usblp
      driver.  The patch below ought to help.
      b39c9f7e
    • Greg Kroah-Hartman's avatar
      Cset exclude: vojtech@suse.cz|ChangeSet|20040602201956|45549 · 55869302
      Greg Kroah-Hartman authored
      Oops, this broke device removal pretty badly :(
      Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
      55869302
  3. 02 Jun, 2004 12 commits
  4. 31 May, 2004 12 commits
  5. 01 Jun, 2004 6 commits
  6. 31 May, 2004 1 commit
    • Marcel Holtmann's avatar
      [Bluetooth] Move function exports out of syms.c · 784d9e34
      Marcel Holtmann authored
      With Linux 2.6 there is no need to keep the function exports in a
      central file and thus the use of syms.c makes no real sense. Remove
      it and add the EXPORT_SYMBOL calls to the functions they belong to.
      784d9e34