1. 22 Sep, 2011 3 commits
    • Guenter Roeck's avatar
      hwmon: (coretemp) Don't use threshold registers for tempX_max · f4af6fd6
      Guenter Roeck authored
      With commit c814a4c7, the meaning of tempX_max
      was changed. It no longer returns the value of bits 8:15 of
      MSR_IA32_TEMPERATURE_TARGET, but instead returns the value of CPU threshold
      register T1. tempX_max_hyst was added to reflect the value of temperature
      threshold register T0.
      
      As it turns out, T0 and T1 are used on some systems, presumably by the BIOS.
      Also, T0 and T1 don't have a well defined meaning. The thresholds may be used
      as upper or lower limits, and it is not guaranteed that T0 <= T1. Thus, the new
      attribute mapping does not reflect the actual usage of the threshold registers.
      Also, register contents are changed during runtime by an entity other than the
      hwmon driver, meaning the values cached by the driver do not reflect actual
      register contents.
      
      Revert most of c814a4c7 to address the problem.
      Support for T0 and T1 will be added back in with a separate commit, using new
      attribute names.
      Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
      Cc: Fenghua Yu <fenghua.yu@intel.com>
      Cc: Durgadoss R <durgadoss.r@intel.com>
      Acked-by: default avatarJean Delvare <khali@linux-fr.org>
      f4af6fd6
    • Jean Delvare's avatar
      hwmon: (coretemp) Let the user force TjMax · a45a8c85
      Jean Delvare authored
      On old CPUs (and even some recent Atom CPUs) TjMax can't be read from
      the CPU registers, so it is guessed by the driver using a complex
      heuristic which isn't reliable. So let users who know their CPU's
      TjMax pass it as a module parameter.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Cc: Fenghua Yu <fenghua.yu@intel.com>
      Cc: "R, Durgadoss" <durgadoss.r@intel.com>
      Cc: Guenter Roeck <guenter.roeck@ericsson.com>
      Cc: Alexander Stein <alexander.stein@systec-electronic.com>
      Acked-by: default avatarFenghua Yu <fenghua.yu@intel.com>
      Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
      a45a8c85
    • Jean Delvare's avatar
      hwmon: (coretemp) Drop duplicate function get_pkg_tjmax · 6bf9e9b0
      Jean Delvare authored
      Function get_pkg_tjmax is a simplified copy of get_tjmax. Drop it and
      always use get_tjmax, result is the same and this avoids code
      duplication.
      
      Also make get_tjmax less verbose: don't warn about MSR read failure
      when failure was expected, and don't report TjMax in the logs unless
      debugging is enabled.
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Cc: Fenghua Yu <fenghua.yu@intel.com>
      Cc: Guenter Roeck <guenter.roeck@ericsson.com>
      Cc: Durgadoss R <durgadoss.r@intel.com>
      Acked-by: default avatarFenghua Yu <fenghua.yu@intel.com>
      Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
      6bf9e9b0
  2. 21 Sep, 2011 14 commits
  3. 20 Sep, 2011 23 commits