1. 01 Sep, 2020 12 commits
    • Lee Jones's avatar
      libertas: Fix 'timer_list' stored private data related dot-rot · f696d724
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/marvell/libertas/main.c:727: warning: Function parameter or member 't' not described in 'lbs_cmd_timeout_handler'
       drivers/net/wireless/marvell/libertas/main.c:727: warning: Excess function parameter 'data' description in 'lbs_cmd_timeout_handler'
       drivers/net/wireless/marvell/libertas/main.c:761: warning: Function parameter or member 't' not described in 'lbs_tx_lockup_handler'
       drivers/net/wireless/marvell/libertas/main.c:761: warning: Excess function parameter 'data' description in 'lbs_tx_lockup_handler'
       drivers/net/wireless/marvell/libertas/main.c:784: warning: Function parameter or member 't' not described in 'auto_deepsleep_timer_fn'
       drivers/net/wireless/marvell/libertas/main.c:784: warning: Excess function parameter 'data' description in 'auto_deepsleep_timer_fn'
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: libertas-dev@lists.infradead.org
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-15-lee.jones@linaro.org
      f696d724
    • Lee Jones's avatar
      cw1200: wsm: Remove 'dummy' variables · e2eb189e
      Lee Jones authored
      They're never read, so there is no reason for them to exist.
      
      They just cause the compiler to complain.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/st/cw1200/wsm.c: In function ‘wsm_ba_timeout_indication’:
       drivers/net/wireless/st/cw1200/wsm.c:1033:5: warning: variable ‘dummy2’ set but not used [-Wunused-but-set-variable]
       drivers/net/wireless/st/cw1200/wsm.c:1031:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
      
      Cc: Solomon Peachy <pizza@shaftnet.org>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-14-lee.jones@linaro.org
      e2eb189e
    • Lee Jones's avatar
      hostap: hostap_ap: Mark 'txt' as __always_unused · debdbb0c
      Lee Jones authored
      Keeping this around to act as documentation, since its use is
      currently #if'ed out at the end of the function.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/intersil/hostap/hostap_ap.c: In function ‘handle_assoc’:
       drivers/net/wireless/intersil/hostap/hostap_ap.c:1507:8: warning: variable ‘txt’ set but not used [-Wunused-but-set-variable]
      
      Cc: Jouni Malinen <j@w1.fi>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Nathan Chancellor <natechancellor@gmail.com>
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-12-lee.jones@linaro.org
      debdbb0c
    • Lee Jones's avatar
      iwlegacy: debug: Demote seemingly unintentional kerneldoc header · 6182abd8
      Lee Jones authored
      This is the only use of kerneldoc in the sourcefile and no
      descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/intel/iwlegacy/debug.c:1373: warning: Function parameter or member 'il' not described in 'il_dbgfs_unregister'
      
      Cc: Stanislaw Gruszka <stf_xl@wp.pl>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Linux Wireless <ilw@linux.intel.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-10-lee.jones@linaro.org
      6182abd8
    • Lee Jones's avatar
      libertas_tf: Fix a bunch of function doc formatting issues · 9554663b
      Lee Jones authored
      Kerneldoc expects attributes/parameters to be in '@*.: ' format and
      gets confused if the variable does not follow the type/attribute
      definitions.
      
      Also demote one stray non-kernel-doc header.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/marvell/libertas_tf/cmd.c:44: warning: Function parameter or member 'priv' not described in 'lbtf_cmd_copyback'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:44: warning: Function parameter or member 'extra' not described in 'lbtf_cmd_copyback'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:44: warning: Function parameter or member 'resp' not described in 'lbtf_cmd_copyback'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:80: warning: Function parameter or member 'priv' not described in 'lbtf_update_hw_spec'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:150: warning: Function parameter or member 'priv' not described in 'lbtf_set_channel'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:150: warning: Function parameter or member 'channel' not described in 'lbtf_set_channel'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:277: warning: Function parameter or member 'priv' not described in '__lbtf_cleanup_and_insert_cmd'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:277: warning: Function parameter or member 'cmdnode' not described in '__lbtf_cleanup_and_insert_cmd'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:442: warning: Function parameter or member 'priv' not described in 'lbtf_allocate_cmd_buffer'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:490: warning: Function parameter or member 'priv' not described in 'lbtf_free_cmd_buffer'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:527: warning: Function parameter or member 'priv' not described in 'lbtf_get_cmd_ctrl_node'
       drivers/net/wireless/marvell/libertas_tf/cmd.c:561: warning: Function parameter or member 'priv' not described in 'lbtf_execute_next_command'
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-8-lee.jones@linaro.org
      9554663b
    • Lee Jones's avatar
      wlcore: cmd: Fix some parameter description disparities · 25ced81e
      Lee Jones authored
      Firstly a rename, then a split (there are 2 'len's that need documenting).
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/ti/wlcore/cmd.c:832: warning: Function parameter or member 'buf_len' not described in 'wl1271_cmd_test'
       drivers/net/wireless/ti/wlcore/cmd.c:832: warning: Excess function parameter 'len' description in 'wl1271_cmd_test'
       drivers/net/wireless/ti/wlcore/cmd.c:862: warning: Function parameter or member 'cmd_len' not described in 'wl1271_cmd_interrogate'
       drivers/net/wireless/ti/wlcore/cmd.c:862: warning: Function parameter or member 'res_len' not described in 'wl1271_cmd_interrogate'
       drivers/net/wireless/ti/wlcore/cmd.c:862: warning: Excess function parameter 'len' description in 'wl1271_cmd_interrogate'
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Hari Nagalla <hnagalla@gmail.com>
      Cc: Guy Mishol <guym@ti.com>
      Cc: Maital Hahn <maitalm@ti.com>
      Cc: Luciano Coelho <luciano.coelho@nokia.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-7-lee.jones@linaro.org
      25ced81e
    • Lee Jones's avatar
      libertas_tf: Demote non-conformant kernel-doc headers · 9833f503
      Lee Jones authored
      There are only 2 kernel-doc headers in this file and both are
      incorrect.  The first one does not attempt to document the function at
      all and the second one is suffering from severe doc-rot; the format is
      wrong and only 1 out of 3 parameters are being documented.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/marvell/libertas_tf/main.c:129: warning: Function parameter or member 't' not described in 'command_timer_fn'
       drivers/net/wireless/marvell/libertas_tf/main.c:554: warning: Function parameter or member 'card' not described in 'lbtf_add_card'
       drivers/net/wireless/marvell/libertas_tf/main.c:554: warning: Function parameter or member 'dmdev' not described in 'lbtf_add_card'
       drivers/net/wireless/marvell/libertas_tf/main.c:554: warning: Function parameter or member 'ops' not described in 'lbtf_add_card'
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-5-lee.jones@linaro.org
      9833f503
    • Lee Jones's avatar
      rsi: File header should not be kernel-doc · 2fc4c9ff
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/rsi/rsi_91x_core.c:23: warning: Incorrect use of kernel-doc format:  * rsi_determine_min_weight_queue() - This function determines the queue with
       drivers/net/wireless/rsi/rsi_91x_core.c:30: warning: Function parameter or member 'common' not described in 'rsi_determine_min_weight_queue'
      
      Cc: Amitkumar Karwar <amitkarwar@gmail.com>
      Cc: Siva Rebbagondla <siva8118@gmail.com>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-4-lee.jones@linaro.org
      2fc4c9ff
    • Lee Jones's avatar
      rsi: Fix some kernel-doc issues · 470d48c1
      Lee Jones authored
      The file header should not be kernel-doc.  Add missing 'rec_pkt'
      description.  Update 'rsi_91x_init()'s parameter description.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/net/wireless/rsi/rsi_91x_main.c:17: warning: Function parameter or member 'fmt' not described in 'pr_fmt'
       drivers/net/wireless/rsi/rsi_91x_main.c:156: warning: Function parameter or member 'rx_pkt' not described in 'rsi_read_pkt'
       drivers/net/wireless/rsi/rsi_91x_main.c:287: warning: Function parameter or member 'oper_mode' not described in 'rsi_91x_init'
       drivers/net/wireless/rsi/rsi_91x_main.c:287: warning: Excess function parameter 'void' description in 'rsi_91x_init'
      
      Cc: Amitkumar Karwar <amitkarwar@gmail.com>
      Cc: Siva Rebbagondla <siva8118@gmail.com>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-3-lee.jones@linaro.org
      470d48c1
    • Lee Jones's avatar
      hostap: Mark 'freq_list' as __maybe_unused · 34537d49
      Lee Jones authored
      'freq_list' is used in some source files which include hostap.h, but
      not all.  The compiler complains about the times it's not used.  Mark
      it as __maybe_used to tell the compiler that this is not only okay,
      it's expected.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/net/wireless/intersil/hostap/hostap_80211_tx.c:9:
       drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
       In file included from drivers/net/wireless/intersil/hostap/hostap_main.c:31:
       drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
       In file included from drivers/net/wireless/intersil/hostap/hostap_proc.c:10:
       drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
       In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
       from drivers/net/wireless/intersil/hostap/hostap_cs.c:196:
       At top level:
       drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
       In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
       from drivers/net/wireless/intersil/hostap/hostap_pci.c:221:
       At top level:
       drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
       In file included from drivers/net/wireless/intersil/hostap/hostap_hw.c:50,
       from drivers/net/wireless/intersil/hostap/hostap_plx.c:264:
       At top level:
       drivers/net/wireless/intersil/hostap/hostap.h:11:19: warning: ‘freq_list’ defined but not used [-Wunused-const-variable=]
      
      Cc: Jouni Malinen <j@w1.fi>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200819072402.3085022-2-lee.jones@linaro.org
      34537d49
    • Allen Pais's avatar
      rtlwifi: fix build warning · 6b8c7574
      Allen Pais authored
      Tasklet conversion patch introduced a build
      warning in _rtl_usb_init_rx, this patch fixes the warning.
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Fixes: d3ccc14d ("rtlwifi/rtw88: convert tasklets to use new tasklet_setup() API")
      Signed-off-by: default avatarAllen Pais <allen.lkml@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200831043659.281712-1-allen.lkml@gmail.com
      6b8c7574
    • Allen Pais's avatar
      zd1211rw: fix build warning · 5d4650ae
      Allen Pais authored
      Tasklet conversion patches intoruced a build warning
      in init_usb_rx(), this patch fixes the same.
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Fixes: 26721b02 ("zd1211rw: convert tasklets to use new tasklet_setup() API")
      Signed-off-by: default avatarAllen Pais <allen.lkml@gmail.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      Link: https://lore.kernel.org/r/20200831043425.281538-1-allen.lkml@gmail.com
      5d4650ae
  2. 31 Aug, 2020 13 commits
  3. 27 Aug, 2020 15 commits