Commits · fb408e6ccc32404a05783911b6f3fed56bd17b06 · nexedi / linux

20 Jul, 2011 40 commits

get rid of pointless checks for dentry->sb == NULL · fb408e6c
Al Viro authored Jul 07, 2011
```
it never is...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
fb408e6c

Make ->d_sb assign-once and always non-NULL · a4464dbc

Al Viro authored Jul 07, 2011

New helper (non-exported, fs/internal.h-only): __d_alloc(sb, name).
Allocates dentry, sets its ->d_sb to given superblock and sets
->d_op accordingly.  Old d_alloc(NULL, name) callers are converted
to that (all of them know what superblock they want).  d_alloc()
itself is left only for parent != NULl case; uses __d_alloc(),
inserts result into the list of parent's children.

Note that now ->d_sb is assign-once and never NULL *and*
->d_parent is never NULL either.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

a4464dbc

unexport kern_path_parent() · e3c3d9c8
Al Viro authored Jun 27, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
e3c3d9c8
switch vfs_path_lookup() to struct path · e0a01249
Al Viro authored Jun 27, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
e0a01249

kill lookup_create() · ed75e95d

Al Viro authored Jun 27, 2011

folded into the only caller (kern_path_create())
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

ed75e95d

devtmpfs: get rid of bogus mkdir in create_path() · 5da4e689

Al Viro authored Jun 27, 2011

We do _NOT_ want to mkdir the path itself - we are preparing to
mknod it, after all.  Normally it'll fail with -ENOENT and
just do nothing, but if somebody has created the parent in
the meanwhile, we'll get buggered...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

5da4e689

switch devtmpfs to kern_path_create() · 69753a0f
Al Viro authored Jun 27, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
69753a0f

switch devtmpfs object creation/removal to separate kernel thread · 2780f1ff

Al Viro authored Jun 27, 2011

... and give it a namespace where devtmpfs would be mounted on root,
thus avoiding abuses of vfs_path_lookup() (it was never intended to
be used with LOOKUP_PARENT).  Games with credentials are also gone.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

2780f1ff

make sure that nsproxy_cache is initialized early enough · 66577193
Al Viro authored Jun 28, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
66577193
switch do_spufs_create() to user_path_create(), fix double-unlock · 1ba10681
Al Viro authored Jun 26, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
1ba10681

new helpers: kern_path_create/user_path_create · dae6ad8f

Al Viro authored Jun 26, 2011

combination of kern_path_parent() and lookup_create().  Does *not*
expose struct nameidata to caller.  Syscalls converted to that...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

dae6ad8f

kill LOOKUP_CONTINUE · 49084c3b

Al Viro authored Jun 25, 2011

LOOKUP_PARENT is equivalent to it now
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

49084c3b

nfs: LOOKUP_{OPEN,CREATE,EXCL} is set only on the last step · 8aeb376c
Al Viro authored Jun 25, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
8aeb376c
cifs_lookup(): LOOKUP_OPEN is set only on the last component · 43527803
Al Viro authored Jun 25, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
43527803
ceph: LOOKUP_OPEN is set only when it's the last component · a127e0af
Al Viro authored Jun 25, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
a127e0af
jfs_ci_revalidate() is safe from RCU mode · 5c0f360b
Al Viro authored Jun 25, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
5c0f360b
LOOKUP_CREATE and LOOKUP_RENAME_TARGET can be set only on the last step · 407938e7
Al Viro authored Jun 25, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
407938e7

no need to check for LOOKUP_OPEN in ->create() instances · dd7dd556

Al Viro authored Jun 25, 2011

... it will be set in nd->flag for all cases with non-NULL nd
(i.e. when called from do_last()).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

dd7dd556

don't pass nameidata to vfs_create() from ecryptfs_create() · bf6c7f6c

Al Viro authored Jun 25, 2011

Instead of playing with removal of LOOKUP_OPEN, mangling (and
restoring) nd->path, just pass NULL to vfs_create().  The whole
point of what's being done there is to suppress any attempts
to open file by underlying fs, which is what nd == NULL indicates.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

bf6c7f6c

don't transliterate lower bits of ->intent.open.flags to FMODE_... · 8a5e929d
Al Viro authored Jun 25, 2011
```
->create() instances are much happier that way...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
8a5e929d

Don't pass nameidata when calling vfs_create() from mknod() · 554a8b9f

Al Viro authored Jun 23, 2011

All instances can cope with that now (and ceph one actually
starts working properly).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

554a8b9f

fix mknod() on nfs4 (hopefully) · f7c85868

Al Viro authored Jun 22, 2011

a) check the right flags in ->create() (LOOKUP_OPEN, not LOOKUP_CREATE)
b) default (!LOOKUP_OPEN) open_flags is O_CREAT|O_EXCL|FMODE_READ, not 0
c) lookup_instantiate_filp() should be done only with LOOKUP_OPEN;
otherwise we need to issue CLOSE, lest we leak stateid on server.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

f7c85868

nameidata_to_nfs_open_context() doesn't need nameidata, actually... · 51141598

Al Viro authored Jun 22, 2011

just open flags; switched to passing just those and
renamed to create_nfs_open_context()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

51141598

nfs_open_context doesn't need struct path either · 3d4ff43d
Al Viro authored Jun 22, 2011
```
just dentry, please...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
3d4ff43d
nfs4_opendata doesn't need struct path either · 82a2c1b7
Al Viro authored Jun 22, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
82a2c1b7

nfs4_closedata doesn't need to mess with struct path · 643168c2

Al Viro authored Jun 22, 2011

instead of path_get()/path_put(), we can just use nfs_sb_{,de}active()
to pin the superblock down.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

643168c2

cifs: fix the type of cifs_demultiplex_thread() · 7c97c200

Al Viro authored Jun 21, 2011

... and get rid of a bogus typecast, while we are at it; it's not
just that we want a function returning int and not void, but cast
to pointer to function taking void * and returning void would be
(void (*)(void *)) and not (void *)(void *), TYVM...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

7c97c200

ecryptfs_inode_permission() doesn't need to bail out on RCU · beefebf1

Al Viro authored Jun 21, 2011

... now that inode_permission() can take MAY_NOT_BLOCK and handle it
properly.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

beefebf1

kill IPERM_FLAG_RCU · 729cdb3a

Al Viro authored Jun 21, 2011

not used anymore
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

729cdb3a

->permission() sanitizing: document API changes · 76fe3276
Al Viro authored Jun 20, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
76fe3276
merge do_revalidate() into its only caller · d2d9e9fb
Al Viro authored Jun 20, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
d2d9e9fb

no reason to keep exec_permission() separate now · 4ad5abb3

Al Viro authored Jun 20, 2011

cache footprint alone makes it a bad idea...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

4ad5abb3

massage generic_permission() to treat directories on a separate path · d594e7ec
Al Viro authored Jun 20, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
d594e7ec

->permission() sanitizing: don't pass flags to exec_permission() · eecdd358

Al Viro authored Jun 20, 2011

pass mask instead; kill security_inode_exec_permission() since we can use
security_inode_permission() instead.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

eecdd358

selinux: don't transliterate MAY_NOT_BLOCK to IPERM_FLAG_RCU · cf1dd1da
Al Viro authored Jun 20, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
cf1dd1da
->permission() sanitizing: don't pass flags to ->inode_permission() · e74f71eb
Al Viro authored Jun 20, 2011
```
pass that via mask instead.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
e74f71eb
->permission() sanitizing: don't pass flags to ->permission() · 10556cb2
Al Viro authored Jun 20, 2011
```
not used by the instances anymore.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
10556cb2

->permission() sanitizing: don't pass flags to generic_permission() · 2830ba7f

Al Viro authored Jun 20, 2011

redundant; all callers get it duplicated in mask & MAY_NOT_BLOCK and none of
them removes that bit.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

2830ba7f

->permission() sanitizing: don't pass flags to ->check_acl() · 7e40145e
Al Viro authored Jun 20, 2011
```
not used in the instances anymore.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
7e40145e
->permission() sanitizing: pass MAY_NOT_BLOCK to ->check_acl() · 9c2c7039
Al Viro authored Jun 20, 2011
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
```
9c2c7039