• unknown's avatar
    Impl 2 of WL2278 - Dynamic port allocation of cluster nodes. · 233a33da
    unknown authored
    In "client connect thread", let the client read the port to connect to using
    ndb_mgm_get_connection_int_parameter.
    
    The request for the port is resent on every connect attempt.
    
    
    ndb/include/mgmapi/mgmapi_debug.h:
      Make ndb_mgm_get_connection_int_parameter return a Uint32 value - this is what Properties etc use, so we'll be consistent.
    ndb/include/transporter/TransporterRegistry.hpp:
      Add NdbMgmHandle to constructor. This is used to get the port number
      to connect to from mgmd. Defaults to NULL, although things will go badly
      if you don't change this (by calling the new set_mgm_handle method) pretty
      quickly.
      
      Add set_mgm_handle(NdbMgmHandle) method.
       - sets the MgmHandle to use when requesting from mgmd what port to connect to a node on.
    ndb/src/common/transporter/Transporter.hpp:
      Make remote port not a const.
      Add method to set remote port - set_r_port(unsigned int)
      
      Make getLocalNodeId return localNodeId, not remoteNodeId.
    ndb/src/common/transporter/TransporterRegistry.cpp:
      TransporterRegistry::TransporterRegistry()
       - accept NdbMgmHandle parameter
       - set m_mgm_handle to this
      
      TransporterRegistry::start_clients_thread()
       - If we're connecting to a node, and the server_port (from the config) is <=0,
      	we request the port number to connect to from mgmd.
      
      (note: in testing, the <=0 check was commented out so the code was run.
      There is no harm in always running it, it's just an extra round-trip to mgmd
      that we may not need).
    ndb/src/kernel/main.cpp:
      Set the mgm_handle for globalTransporterRegistry soon after we have set up theConfig (which sets up the mgmHandle).
    ndb/src/mgmapi/mgmapi.cpp:
      - Remove dead #else on #if 1
      
      - Print an error message and warning if the parser returns NULL.
        this will no longer silently fail, it will give output with
        information to help the programmer find out where things went wrong.
        In normal operation, this codepath should never be hit.
      
      - fix handlers for 'get|set connection parameter' calls.
    ndb/src/mgmsrv/MgmtSrvr.cpp:
      - Create TransporterFacade with the mgmHandle.
      - Don't worry about the order of node1 and node2 in getConnectionDbParameter
      - use a proper DBUG_RETURN in getConnectionParameter
    ndb/src/mgmsrv/Services.cpp:
      - fix reply to 'get connection parameter'
      - optimise reply size.
    ndb/src/ndbapi/TransporterFacade.cpp:
      - create TransporterRegistry with m_mgm_handle
      - set m_mgm_handle in constructor
    ndb/src/ndbapi/TransporterFacade.hpp:
      Introduce m_mgm_handle member.
    ndb/src/ndbapi/ndb_cluster_connection.cpp:
      create TransporterFacade (with mgmHandle) after the ConfigRetriever has been created
    233a33da
ndb_cluster_connection.cpp 5.93 KB