• Staale Smedseng's avatar
    Bug #49829 Many "hides virtual function" warnings with · 0c07d7c4
    Staale Smedseng authored
    SunStudio
          
    SunStudio compilers of late warn about methods that might hide
    methods in base classes due to the use of overloading combined
    with overriding. SunStudio also warns about variables defined
    in local socpe or method arguments that have the same name as
    a member attribute of the class.
          
    This patch renames methods that might hide base class methods,
    to make it easier both for humans and compilers to see what is
    actually called. It also renames variables in local scope.
    
    
    sql/field.cc:
      Local scope variable or method argument same as class 
      attribute.
    sql/item_cmpfunc.cc:
      Local scope variable or method argument same as class 
      attribute.
    sql/item_create.cc:
      Renaming base class create() to create_func().
    sql/item_create.h:
      Renaming base class create() to create_func().
    sql/protocol.cc:
      Local scope variable or method argument same as class 
      attribute.
    sql/sql_profile.cc:
      Local scope variable or method argument same as class 
      attribute.
    sql/sql_select.cc:
      Local scope variable or method argument same as class 
      attribute.
    sql/sql_yacc.yy:
      Renaming base class create() to create_func().
    storage/federated/ha_federated.cc:
      Local scope variable or method argument same as class 
      attribute.
    storage/myisammrg/ha_myisammrg.cc:
      Local scope variable or method argument same as class 
      attribute.
    0c07d7c4
item_create.h 5.43 KB