• unknown's avatar
    BUG#9626 · 446d4631
    unknown authored
     - Fix valgrind warnings
     - Remove static db, schema and table name buffers from Ndb.cpp
    
    
    mysys/thr_alarm.c:
      Initialise sact to zero
    ndb/include/kernel/ndb_limits.h:
      Set MAX_ATTR_NAME_SIZE to NAME_LEN which is tha maximum in MySQL
    ndb/include/kernel/signaldata/GetTabInfo.hpp:
      Clean up
    ndb/include/ndbapi/Ndb.hpp:
      Remove NDB_MAX_INTERNAL_NAME_LENGTH and all char buffers for schema, db and tablename.
      Made them dynamic and moved to NdbImpl.hpp
    ndb/include/ndbapi/ndbapi_limits.h:
      Remove the static length's of attr, db, schema and table name.
    ndb/src/common/transporter/Packer.cpp:
      Set theSignalId to ~0 when unpacking signal
    ndb/src/ndbapi/Ndb.cpp:
      Moved schema, database and tablename to NdbImpl.hpp
    ndb/src/ndbapi/NdbDictionaryImpl.cpp:
      Add NdbIndexImpl::init and NdbEventImpl::init
      Init all vars in NdbIndexImpl, NdbEventImpl, NdbTableImpl and NdbIndexImpl
      Delete the pseudo column NDB$RANGE_NO
      Copy tablename to internal buff in NdbDictInterface to get proper alignment.
      Convert length of table name from bytes words, when setting sz of LinearSectionPtr
      Set LinearSectionPtr array size to number of LinearSections used - save some stack.
    ndb/src/ndbapi/NdbDictionaryImpl.hpp:
      Add NdbEventImpl::init and NdbIndexImpl::init
      Remove clearNewProperties and copyNewProperties, it's easier to check if all vars are initied if it's done in the same func.
      Add buffer for tabname ti NdbDictInterface, memset it to 0 in initializer.
    ndb/src/ndbapi/NdbImpl.hpp:
      Use BaseString for table, schema and db names.
    ndb/src/ndbapi/Ndbinit.cpp:
      Move schema and db name to NdbImpl and use BaseString
    ndb/src/ndbapi/ndb_cluster_connection.cpp:
      Destroy ndb_global_event_buffer_mutex and ndb_print_state_mutex
    sql/ha_ndbcluster.cc:
      Check if pTrans is not null before calling closeTransaction
      Remove NDB_MAX_ATTR_NAME_SIZE
      Remove truncation of attr names. When attr name length is same in NDB as in MySQL this will be checked in functin check_column_name
    446d4631
Packer.cpp 13.7 KB