• Marko Mäkelä's avatar
    MDEV-26376 pars_info_bind_id() unnecessarily copies strings · 4cd063b9
    Marko Mäkelä authored
    pars_info_bind_id(): Remove the parameter copy_name. It was always
    being passed as constant TRUE or true. It turns out that copying
    the string is completely unnecessary. In all calls except the one
    in fts_get_select_columns_str() and fts_doc_fetch_by_doc_id(),
    the parameter is being passed as a compile-time constant, and therefore
    the pointer cannot become stale. In that special call, the string
    that is being passed is allocated from the same memory heap that
    pars_info_bind_id() would have been using.
    
    pars_info_add_id(): Remove (unused declaration).
    4cd063b9
fts0sql.cc 7.56 KB