• unknown's avatar
    Fix for BUG#11211 "GROUP BY doesn't work correctly" · 5e144bf7
    unknown authored
      
    When the GROUP BY clause contains a column reference that can be resolved to
    both an aliased column in the SELECT list, and to a column in the FROM clause,
    the group column is resolved to the column in the FROM clause (for ANSI conformance).
    However, it may be so that the user's intent is just the other way around, and he/she
    gets the query results grouped by a completely different column than expexted.
    This patch adds a warning in such cases that tells the user that there is potential
    ambiguity in the group column.
    
    sql/sql_select.cc
    - Added a warning when a GROUP column is ambiguous due to that there is a
      column reference with the same name both in the SELECT and FROM clauses.
      In this case we resolve to the column in FROM clause and warn the user
      of a possible ambiguity.
    - More extensive comments.
    - Changed the function to return bool instead of int (as in other places).
    
    mysql-test/t/group_by.test
      Added test for BUG#11211.
    
    mysql-test/r/group_by.result
      Added test for BUG#11211.
    
    
    mysql-test/r/group_by.result:
      Import patch 11211.diff
    mysql-test/t/group_by.test:
      Import patch 11211.diff
    sql/sql_select.cc:
      Import patch 11211.diff
    BitKeeper/etc/ignore:
      Added ndb/src/dummy.cpp to the ignore list
    mysql-test/r/alias.result:
      Added warning for potentially ambiguous column.
    mysql-test/r/having.result:
      Added warning for potentially ambiguous column.
    5e144bf7
having.result 9.2 KB