• kroki/tomash@moonlight.intranet's avatar
    BUG#21726: Incorrect result with multiple invocations of LAST_INSERT_ID · 5ea8adfa
    kroki/tomash@moonlight.intranet authored
    Non-upper-level INSERTs (the ones in the body of stored procedure,
    stored function, or trigger) into a table that have AUTO_INCREMENT
    column didn't affected the result of LAST_INSERT_ID() on this level.
    
    The problem was introduced with the fix of bug 6880, which in turn was
    introduced with the fix of bug 3117, where current insert_id value was
    remembered on the first call to LAST_INSERT_ID() (bug 3117) and was
    returned from that function until it was reset before the next
    _upper-level_ statement (bug 6880).
    
    The fix for bug#21726 brings back the behaviour of version 4.0, and
    implements the following: remember insert_id value at the beginning
    of the statement or expression (which at that point equals to
    the first insert_id value generated by the previous statement), and
    return that remembered value from LAST_INSERT_ID() or @@LAST_INSERT_ID.
    
    Thus, the value returned by LAST_INSERT_ID() is not affected by values
    generated by current statement, nor by LAST_INSERT_ID(expr) calls in
    this statement.
    
    Version 5.1 does not have this bug (it was fixed by WL 3146).
    5ea8adfa
sql_load.cc 35.1 KB