• unknown's avatar
    Fixed bug #27954. · 72142bbe
    unknown authored
    This bug affects multi-row INSERT ... ON DUPLICATE into table
    with PRIMARY KEY of AUTO_INCREMENT field and some additional UNIQUE indices.
    If the first row in multi-row INSERT contains duplicated values of UNIQUE
    indices, then following rows of multi-row INSERT (with either duplicated or
    unique key field values) may me applied to _arbitrary_ records of table as
    updates.
    This bug was introduced in 5.0. Related code was widely rewritten in 5.1, and
    5.1 is already free of this problem. 4.1 was not affected too.
    
    When updating the row during INSERT ON DUPLICATE KEY UPDATE, we called
    restore_auto_increment(), which set next_insert_id back to 0, but we
    forgot to set clear_next_insert_id back to 0.
    restore_auto_increment() function has been fixed.
    
    
    sql/sql_class.h:
      Fixed bug #27954.
      Added commentary for THD::clear_next_insert_id variable.
    sql/handler.cc:
      Fixed bug #27954.
      When updating the row during INSERT ON DUPLICATE KEY UPDATE, we called
      restore_auto_increment(), which set next_insert_id back to 0, but we
      forgot to set clear_next_insert_id back to 0.
      restore_auto_increment() function has been fixed.
    mysql-test/t/insert_update.test:
      Added test case for bug #27954.
    mysql-test/r/insert_update.result:
      Added test case for bug #27954.
    72142bbe
handler.cc 76.2 KB