• unknown's avatar
    First part of redo/undo for key pages · 5d6ee443
    unknown authored
    Added key_nr to st_maria_keydef for faster keyinfo->keynr conversion
    For transactional tables, shift record number in keys up with 1 bit to have place to indicate if transid follows
    Checksum for MyISAM now ignores NULL and not used part of VARCHAR
    Renamed some variables that caused shadow compiler warnings
    Moved extra() call when waiting for tables to not be used to after tables are removed from cache.
    Fixed crashing bugs when using Maria TEMPORARY tables with TRUNCATE. Removed 'hack' code in sql directory to go around this bug.
    pagecache_unlock_by_ulink() now has extra argument to say if page was changed.
    Give error message if we fail to open control file
    Mark page cache variables as not flushable
    
    
    include/maria.h:
      Made min page cache larger (needed for pinning key page)
      Added key_nr to st_maria_keydef for faster keyinfo->keynr conversion
      Added write_comp_flag to move some runtime code to maria_open()
    include/my_base.h:
      Added new error message to be used when handler initialization failed
    include/my_global.h:
      Renamed dummy to swap_dummy to avoid conflicts with local 'dummy' variables
    include/my_handler.h:
      Added const to some parameters
    mysys/array.c:
      More DBUG
    mysys/my_error.c:
      Fixed indentation
    mysys/my_handler.c:
      Added const to some parameters
      Added missing error messages
    sql/field.h:
      Renamed variables to avoid variable shadowing
    sql/handler.h:
      Renamed parameter to avoid variable name conflict
    sql/item.h:
      Renamed variables to avoid variable shadowing
    sql/log_event_old.h:
      Renamed variables to avoid variable shadowing
    sql/set_var.h:
      Renamed variables to avoid variable shadowing
    sql/sql_delete.cc:
      Removed maria hack for temporary tables
      Fixed indentation
    sql/sql_table.cc:
      Moved extra() call when waiting for tables to not be used to after tables are removed from cache.
      This was needed to ensure we don't do a PREPARE_FOR_DROP or similar call while the table is still in use.
    sql/table.cc:
      Copy page_checksum from share
      Removed Maria hack
    storage/maria/Makefile.am:
      Added new files
    storage/maria/ha_maria.cc:
      Renamed records -> record_count and info -> create_info to avoid variable name conflicts
      Mark page cache variables as not flushable
    storage/maria/ma_blockrec.c:
      Moved _ma_unpin_all_pages() to ma_key_recover.c
      Moved init of info->pinned_pages to ma_open.c
      Moved _ma_finalize_row() to maria_key_recover.h
      Renamed some variables to avoid variable name conflicts
      Mark page_link.changed for blocks we change directly
      Simplify handling of undo link when writing LOGREC_UNDO_ROW_INSERT (old code crashed when having redo for index)
    storage/maria/ma_blockrec.h:
      Removed extra empty line
    storage/maria/ma_checkpoint.c:
      Remove not needed trnman.h
    storage/maria/ma_close.c:
      Free pinned pages (which are now always allocated)
    storage/maria/ma_control_file.c:
      Give error message if we fail to open control file
    storage/maria/ma_delete.c:
      Changes for redo logging (first part, logging of underflow not yet done)
      - Log undo-key-delete
      - Log delete of key
      - Updated arguments to _ma_fetch_keypage(), _ma_dispose(), _ma_write_keypage(), _ma_insert()
      - Added new arguments to some functions to be able to write redo information
      - Mark key pages as changed when we write with PAGECACHE_LOCK_LEFT_WRITELOCKED
      
      Remove one not needed _ma_write_keypage() in d_search() when upper level will do the write anyway
      Changed 2 bmove_upp() to bmove() as this made code easer to understand
      More function comments
      Indentation fixes
    storage/maria/ma_ft_update.c:
      New arguments to _ma_write_keypage()
    storage/maria/ma_loghandler.c:
      Fixed some DBUG_PRINT messages
      Simplify code
      Added new log entrys for key page redo
      Renamed some variables to avoid variable name shadowing
    storage/maria/ma_loghandler.h:
      Moved some defines here
      Added define for storing key number on key pages
      Added new translog record types
      Added enum for type of operations in LOGREC_REDO_INDEX
    storage/maria/ma_open.c:
      Always allocate info.pinned_pages (we need now also for normal key page usage)
      Update keyinfo->key_nr
      Added virtual functions to convert record position o number to be stored on key pages
      Update keyinfo->write_comp_flag to value of search flag to be used when writing key
    storage/maria/ma_page.c:
      Added redo for key pages
      - Extended _ma_fetch_keypage() with type of lock to put on page and address to used MARIA_PINNED_PAGE
      - _ma_fetch_keypage() now pin's pages if needed
      - Extended _ma_write_keypage() with type of locks to be used
      - ma_dispose() now locks info->s->state.key_del from other threads
      - ma_dispose() writes redo log record
      - ma_new() locks info->s->state.key_del from other threads if it was used
      - ma_new() now pins read page
      
      Other things:
      - Removed some not needed arguments from _ma_new() and _ma_dispose)
      - Added some new variables to simplify code
      - If EXTRA_DEBUG is used, do crc on full page to catch not unitialized bytes
    storage/maria/ma_pagecache.h:
      Applied patch from Sanja to add extra argument to pagecache_unlock_by_ulink() to mark if page was changed
      Added some defines for pagecache priority levels that one can use
    storage/maria/ma_range.c:
      Added new arguments for call to _ma_fetch_keypage()
    storage/maria/ma_recovery.c:
      - Added hooks for new translog types:
        REDO_INDEX, REDO_INDEX_NEW_PAGE, REDO_INDEX_FREE_PAGE, UNDO_KEY_INSERT, UNDO_KEY_DELETE and
        UNDO_KEY_DELETE_WITH_ROOT.
      - Moved variable declarations to start of function (portability fixes)
      - Removed some not needed initializations
      - Set only relevant state changes for each redo/undo entry
    storage/maria/lockman.c:
      Removed end space
    storage/maria/ma_check.c:
      Removed end space
    storage/maria/ma_create.c:
      Removed end space
    storage/maria/ma_locking.c:
      Removed end space
    storage/maria/ma_packrec.c:
      Removed end space
    storage/maria/ma_pagecache.c:
      Removed end space
    storage/maria/ma_panic.c:
      Removed end space
    storage/maria/ma_rt_index.c:
      Added new arguments for call to _ma_fetch_keypage(), _ma_write_keypage(), _ma_dispose() and _ma_new()
      Fixed indentation
    storage/maria/ma_rt_key.c:
      Added new arguments for call to _ma_fetch_keypage()
    storage/maria/ma_rt_split.c:
      Added new arguments for call to _ma_new()
      Use new keypage header
      Added new arguments for call to _ma_write_keypage()
    storage/maria/ma_search.c:
      Updated comments & indentation
      Added new arguments for call to _ma_fetch_keypage()
      Made some variables and arguments const
      Added virtual functions for converting row position to number to be stored in key
      use MARIA_RECORD_POS of record position instead of my_off_t
      Record in MARIA_KEY_PARAM how page was changed one key insert (needed for REDO)
    storage/maria/ma_sort.c:
      Removed end space
    storage/maria/ma_statrec.c:
      Updated arguments for call to _ma_rec_pos()
    storage/maria/ma_test1.c:
      Fixed too small buffer to init_pagecache()
      Fixed bug when using insert_count and test_flag
    storage/maria/ma_test2.c:
      Use more resonable pagecache size
      Remove not used code
      Reset blob_length to fix wrong output message
    storage/maria/ma_test_all.sh:
      Fixed wrong test
    storage/maria/ma_write.c:
      Lots of new code to handle REDO of key pages
      No logic changes because of REDO code, mostly adding new arguments and adding new code for logging 
      
      Added new arguments for calls to _ma_fetch_keypage(), _ma_write_keypage() and similar functions
      Move setting of comp_flag in ma_ck_wrte_btree() from runtime to maria_open()
      Zerofill new used pages for:
      - To remove possible sensitive data left in buffer
      - To get idenitical data on pages after running redo
      - Better compression of pages if archived
    storage/maria/maria_chk.c:
      Added information if table is crash safe
    storage/maria/maria_def.h:
      New virtual function to convert between record position on key and normal record position
      Aded mutex and extra variables to handle locking of share->state.key_del
      Moved some structure variables to get things more aligned
      Added extra arguments to MARIA_KEY_PARAM to be able to remember what was changed on key page on key insert
      Added argument to MARIA_PINNED_PAGE to indicate if page was changed
      Updated prototypes for functions
      Added some structures for signaling changes in REDO handling
    storage/maria/unittest/ma_pagecache_single.c:
      Updated arguments for changed function calls
    storage/myisam/mi_check.c:
      Made calc_check_checksum virtual
    storage/myisam/mi_checksum.c:
      Update checksums to ignore null columns
    storage/myisam/mi_create.c:
      Mark if table has null column (to know when we have to use mi_checksum())
    storage/myisam/mi_open.c:
      Added virtual function for calculating checksum to be able to easily ignore NULL fields
    storage/myisam/mi_test2.c:
      Fixed bug
    storage/myisam/myisamdef.h:
      Added virtual function for calculating checksum during check table
      Removed ha_key_cmp() as this is in handler.h
    storage/maria/ma_key_recover.c:
      New BitKeeper file ``storage/maria/ma_key_recover.c''
    storage/maria/ma_key_recover.h:
      New BitKeeper file ``storage/maria/ma_key_recover.h''
    storage/maria/ma_key_redo.c:
      New BitKeeper file ``storage/maria/ma_key_redo.c''
    5d6ee443
ma_key_redo.c 12.7 KB