• unknown's avatar
    Better error reporting in mysql-test-run (don't hide the important message · 800bbfa0
    unknown authored
    with 'head').
    Test fix (this sync_with_master was nonsense).
    Now all tests pass in 4.0 in autobuild.
    
    
    mysql-test/mysql-test-run.sh:
      Error reporting (how mysql-test-run filters the messages which mysqltest prints
      on stderr) is not reliable. It does a 'head the first line only' which in
      my case caused me to lose some time, because in fact the worrying message was
      on the second line (logically, the one which caused the die() is at the
      end of the $TIMEFILE file, not at the beginning).
      Doing a 'tail' is better but not perfect (depending on the build, one may get
      "Maximum memory usage" as the last line); it's always good to have all messages
      and spot the important one oneself. So we print all $TIMEFILE (that's a few lines
      at most).
    mysql-test/t/rpl_rotate_logs.test:
      Dont sync_with_master as the SQL slave thread may be stopped at this moment;
      just wait_for_slave_to_stop. Doing sync_with_master caused a non-deterministic
      behaviour, because (note that save_master_pos was called to early) sometimes
      MASTER_POS_WAIT() started before the SQL thread died (because of unique
      violation) so returned 0, other times it started after the SQL thread died
      so returned NULL (which is reported by mysqltest as an error, on stderr).
    800bbfa0
rpl_rotate_logs.test 3.68 KB