• unknown's avatar
    Bug#30273 - merge tables: Can't lock file (errno: 155) · e223c320
    unknown authored
    The patch for Bug 26379 (Combination of FLUSH TABLE and
    REPAIR TABLE corrupts a MERGE table) fixed this bug too.
    However it revealed a new bug that crashed the server.
    
    Flushing a merge table at the moment when it is between open
    and attach of children crashed the server.
    
    The flushing thread wants to abort locks on the flushed table.
    It calls ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
    on the TABLE object of the other thread.
    
    Changed ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
    to accept non-attached children. ha_myisammrg::lock_count() returns
    the number of MyISAM tables in the MERGE table so that the memory
    allocation done by get_lock_data() is done correctly, even if the
    children become attached before ha_myisammrg::store_lock() is
    called. ha_myisammrg::store_lock() will not return any lock if the
    children are not attached.
    
    This is however a change in the handler interface. lock_count()
    can now return a higher number than store_lock() stores locks.
    This is more safe than the reverse implementation would be.
    get_lock_data() in the SQL layer is adjusted accordingly. It sets
    MYSQL_LOCK::lock_count based on the number of locks returned by
    the handler::store_lock() calls, not based on the numbers returned
    by the handler::lock_count() calls. The latter are only used for
    allocation of memory now.
    
    No test case. The test suite cannot reliably run FLUSH between
    lock_count() and store_lock() of another thread. The bug report
    contains a program that can repeat the problem with some
    probability.
    
    
    include/myisammrg.h:
      Bug#30273 - merge tables: Can't lock file (errno: 155)
      Added mutex to struct st_myrg_info (MYRG_INFO).
    sql/handler.h:
      Bug#30273 - merge tables: Can't lock file (errno: 155)
      Extended comments for handler::lock_count() and
      handler::store_lock().
    sql/lock.cc:
      Bug#30273 - merge tables: Can't lock file (errno: 155)
      Changed get_lock_data() so that the final lock_count is taken
      from the number of locks returned from handler::store_lock()
      instead of from handler::lock_count().
    sql/sql_base.cc:
      Fixed a purecov comment. (unrelated to the rest of the changeset)
    storage/myisammrg/ha_myisammrg.cc:
      Bug#30273 - merge tables: Can't lock file (errno: 155)
      Changed ha_myisammrg::lock_count() and ha_myisammrg::store_lock()
      to accept non-attached children.
      Protected ha_myisammrg::store_lock() by MYRG_INFO::mutex.
    storage/myisammrg/myrg_close.c:
      Bug#30273 - merge tables: Can't lock file (errno: 155)
      Added MYRG_INFO::mutex destruction to myrg_parent_close().
    storage/myisammrg/myrg_open.c:
      Bug#30273 - merge tables: Can't lock file (errno: 155)
      Added MYRG_INFO::mutex initialization to myrg_parent_open().
      Protected myrg_attach_children() and myrg_detach_children()
      by MYRG_INFO::mutex.
      Fixed a purecov comment. (unrelated to the rest of the changeset)
    e223c320
lock.cc 48.4 KB