• Kristian Nielsen's avatar
    MDEV-7847: "Slave worker thread retried transaction 10 time(s) in vain, giving... · 880f2273
    Kristian Nielsen authored
    MDEV-7847: "Slave worker thread retried transaction 10 time(s) in vain, giving up", followed by replication hanging
    
    This patch fixes a bug in the error handling in parallel replication, when one
    worker thread gets a failure and other worker threads processing later
    transactions have to rollback and abort.
    
    The problem was with the lifetime of group_commit_orderer objects (GCOs).
    A GCO is freed when we register that its last event group has committed. This
    relies on register_wait_for_prior_commit() and wait_for_prior_commit() to
    ensure that the fact that T2 has committed implies that any earlier T1 has
    also committed, and can thus no longer execute mark_start_commit().
    
    However, in the error case, the code was skipping the
    register_wait_for_prior_commit() and wait_for_prior_commit() calls. Thus
    commit ordering was not guaranteed, and a GCO could be freed too early. Then a
    later mark_start_commit() would reference deallocated GCO, which could lead to
    lost wakeup (causing slave threads to hang) or other corruption.
    
    This patch makes also the error case respect commit order. This way, also the
    error case gets the GCO lifetime correct, and the hang no longer occurs.
    880f2273
log.cc 287 KB