• sjaakola's avatar
    MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL) · 88a4be75
    sjaakola authored
    This patch is the plan D variant for fixing potetial mutex locking
    order exercised by BF aborting and KILL command execution.
    
    In this approach, KILL command is replicated as TOI operation.
    This guarantees total isolation for the KILL command execution
    in the first node: there is no concurrent replication applying
    and no concurrent DDL executing. Therefore there is no risk of
    BF aborting to happen in parallel with KILL command execution
    either. Potential mutex deadlocks between the different mutex
    access paths with KILL command execution and BF aborting cannot
    therefore happen.
    
    TOI replication is used, in this approach,  purely as means
    to provide isolated KILL command execution in the first node.
    KILL command should not (and must not) be applied in secondary
    nodes. In this patch, we make this sure by skipping KILL
    execution in secondary nodes, in applying phase, where we
    bail out if applier thread is trying to execute KILL command.
    This is effective, but skipping the applying of KILL command
    could happen much earlier as well.
    
    This patch also fixes mutex locking order and unprotected
    THD member accesses on bf aborting case. We try to hold
    THD::LOCK_thd_data during bf aborting. Only case where it
    is not possible is at wsrep_abort_transaction before
    call wsrep_innobase_kill_one_trx where we take InnoDB
    mutexes first and then THD::LOCK_thd_data.
    
    This will also fix possible race condition during
    close_connection and while wsrep is disconnecting
    connections.
    
    Added wsrep_bf_kill_debug test case
    Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
    88a4be75
wsrep_thd.cc 26.9 KB