• Anushree Prakash B's avatar
    Bug#27259654 - ISSUES FOUND BY PVS-STUDIO STATIC ANALYZER · 9c6777c0
    Anushree Prakash B authored
    DESCRIPTION
    ===========
    PVS-Studio static code analyzer found several suspicious
    fragments of code across various files.
    
    i)   sizeof() is using the pointer
    ii)  memcpy() doesn't copy the whole string.
    iii) enumeration constant 'wkb_multilinestring' is used as
         a variable of a Boolean-type.
    iv) 'throw' keyword is missing from std::runtime_error()
    
    FIX
    ===
    i)   Use sizeof({actual object/data type})
    ii)  Use strncpy() and set last char as '\0'
    iii) N/A (Issue has already been fixed)
    iv)  Add 'throw' before the exception.
    
    RB: 21502
    9c6777c0
common.cc 13.1 KB